From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE947C433E2 for ; Mon, 14 Sep 2020 06:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FD532078D for ; Mon, 14 Sep 2020 06:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600065071; bh=oWZ+hyC/32Qv3MwnW06BWwblz6/DmjeTm+paTPOKFZM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=mjx4KntGTJiBLxzrsSGnI23KG83O4ZXhGCCP1DkrcU6bcSN6SB2CCUVc5mANxBSUV IHrO6DN5iC1doD24HWJOtwWtf3VGoMqXs6Jc1eC7MYZOkI/qHY2tDBeBjwUqz8L6Rq 9zql/qaWUi633Wp00KW/GCzLPrrYI4PmXCOe+anc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726064AbgINGbJ (ORCPT ); Mon, 14 Sep 2020 02:31:09 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44610 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726003AbgINGbG (ORCPT ); Mon, 14 Sep 2020 02:31:06 -0400 Received: by mail-wr1-f66.google.com with SMTP id s12so17297654wrw.11 for ; Sun, 13 Sep 2020 23:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hl8hTr4cbxm9Qx8HdIMf4rTLZh56bTncsMLVlRaBM0M=; b=U2JylFc/qbDETSc/Gn39LFem0D59h1GOormD/xV01f9N7yBm1BHRQRte0RrlOOFr9a E/hwDKQp6RaXwx9Oji9DJtPcnSSk7an7GyVB8mvfXM8epSOctITPGboHOh3uxRyfhywL DzApe5sMZAlPawXyiAYvbnIZiBfdCSwrG0R0FjnwjZX8q1YNqBpCLBIJMUz3yW6gVmxu VCpYmLYQ9RvDDd4R2SShwYPv7wdoeVhUdZRQ5TD/GtSZtzocKYjE8PcfWZxBokYoWibb 9oMGgbFqprY2Y5QssmI4WwAd/sWOXCggPr8j3noqSUJvTiM/G1WtV7m7C/k9TGSIxmwT GhGQ== X-Gm-Message-State: AOAM532TqRJ/q598P280auiNb9cGgk9qKOfEYX3eskEtUvMEX7hKmz3o WtHmz5AjmlFR02Dnam0lM/Hczg1LthGs/EA+OqFAKdzLqF8= X-Google-Smtp-Source: ABdhPJyWumlfmsIA9ArzNwL6HHaJHiCpsVPkutojGzRa5zdjLVMvcbEYdaAh1y1uZYN1rYDrTs9IgRWv9etGj4RLn7A= X-Received: by 2002:adf:a418:: with SMTP id d24mr6319402wra.80.1600065064551; Sun, 13 Sep 2020 23:31:04 -0700 (PDT) MIME-Version: 1.0 References: <20200913210313.1985612-1-jolsa@kernel.org> <20200913210313.1985612-15-jolsa@kernel.org> In-Reply-To: <20200913210313.1985612-15-jolsa@kernel.org> From: Namhyung Kim Date: Mon, 14 Sep 2020 15:30:53 +0900 Message-ID: Subject: Re: [PATCH 14/26] perf tools: Add mmap3 events to --show-mmap-events option To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Song Liu , "Frank Ch. Eigler" , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 6:04 AM Jiri Olsa wrote: > > Displaying mmap3 events for --show-mmap-events option, > the build id is displayed within <> braces: > > $ perf script --show-mmap-events > kill 12148 13893.519014: PERF_RECORD_MMAP3 12148/12148: <43938d0803c5e3130ea679cd569aaf44b98d9ae8> [0x560e7d7f.. > kill 12148 13893.519420: PERF_RECORD_MMAP3 12148/12148: <1805c738c8f3ec0f47b7ea09080c28f34d18a82b> [0x7f9e7dfc.. > > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-script.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index d839983cfb88..9c09581d5cb0 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -2342,6 +2342,38 @@ static int process_mmap2_event(struct perf_tool *tool, > event->mmap2.tid); > } > > +static int process_mmap3_event(struct perf_tool *tool, > + union perf_event *event, > + struct perf_sample *sample, > + struct machine *machine) > +{ > + struct thread *thread; > + struct perf_script *script = container_of(tool, struct perf_script, tool); > + struct perf_session *session = script->session; > + struct evsel *evsel = perf_evlist__id2evsel(session->evlist, sample->id); > + > + if (perf_event__process_mmap3(tool, event, sample, machine) < 0) > + return -1; > + > + thread = machine__findnew_thread(machine, event->mmap3.pid, event->mmap3.tid); > + if (thread == NULL) { > + pr_debug("problem processing MMAP2 event, skipping it.\n"); MMAP3 ? Thanks Namhyung > + return -1; > + } > + > + if (!evsel->core.attr.sample_id_all) { > + sample->cpu = 0; > + sample->time = 0; > + sample->tid = event->mmap3.tid; > + sample->pid = event->mmap3.pid; > + } > + perf_sample__fprintf_start(script, sample, thread, evsel, > + PERF_RECORD_MMAP3, stdout); > + perf_event__fprintf(event, machine, stdout); > + thread__put(thread); > + return 0; > +} > + > static int process_switch_event(struct perf_tool *tool, > union perf_event *event, > struct perf_sample *sample, > @@ -2498,6 +2530,7 @@ static int __cmd_script(struct perf_script *script) > if (script->show_mmap_events) { > script->tool.mmap = process_mmap_event; > script->tool.mmap2 = process_mmap2_event; > + script->tool.mmap3 = process_mmap3_event; > } > if (script->show_switch_events || (scripting_ops && scripting_ops->process_switch)) > script->tool.context_switch = process_switch_event; > -- > 2.26.2 >