From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8905BC433ED for ; Sun, 25 Apr 2021 18:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62EB66128B for ; Sun, 25 Apr 2021 18:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231149AbhDYSBS (ORCPT ); Sun, 25 Apr 2021 14:01:18 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:36587 "EHLO mail-lf1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbhDYSBR (ORCPT ); Sun, 25 Apr 2021 14:01:17 -0400 Received: by mail-lf1-f51.google.com with SMTP id n138so84980332lfa.3 for ; Sun, 25 Apr 2021 11:00:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zt7My1IBpJP2EA1l/SHv+IPmhO+PkKbRTxsodKXSMQE=; b=nA//pf32F4/9j+K+6v6mrhAekQ2egrQkdPOAAph88QlfSxyou5QXDYTVFdrkBSgzpK o3Nrl5zJD7SDZOae/IuW/1oTBtfFBzaQWvbEwTbcZX4G5oIlVB/Un8jH9n+qO2EkYRJl sCyVyI/RdFUKGyZyrHaOK1KyDsEu06w/t/dj2ftTGj6V8KgogIIom2RVDzSexOC6jjyX LIwkSrDz6sIvCZ917e9QqkpoXhc5Rt4vxC+kum5pMfJvhFkQ5ja/NGxssgWxhOweNeuV +0H5W//1eshIZN3Bzi0MqyAYiUcy5aVPHqfj88qFoi4/03iTEJEp6V5Maa0XS+b8mXRz VJHw== X-Gm-Message-State: AOAM533SfeFsH6I0pRpttfsnX5I1Min2Q1LTjHNyqZ7HnFUArfMY7bdJ AHgxvFPzK9xRwyhk6E7aAl+bgbR0R3EuYa3QBHU= X-Google-Smtp-Source: ABdhPJwpDxu/QZPUnbUIHajdlf5Ge5NQZLhQV9mkuVrRfCJtbzfQt8WE0CqYahouSpTcD8om7s6OK7bZjrPJeEQC79E= X-Received: by 2002:a05:6512:b26:: with SMTP id w38mr10027995lfu.152.1619373635567; Sun, 25 Apr 2021 11:00:35 -0700 (PDT) MIME-Version: 1.0 References: <20210423023833.1430520-1-namhyung@kernel.org> In-Reply-To: From: Namhyung Kim Date: Mon, 26 Apr 2021 03:00:24 +0900 Message-ID: Subject: Re: [PATCH] perf stat: Use aggregated counts directly To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Mark Rutland , Alexander Shishkin , LKML , Andi Kleen , Ian Rogers , Jin Yao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 12:50 AM Jiri Olsa wrote: > > On Thu, Apr 22, 2021 at 07:38:33PM -0700, Namhyung Kim wrote: > > The ps->res_stats is for repeated runs, so the interval code should > > not touch it. Actually the aggregated counts are available in the > > counter->counts->aggr, so we can (and should) use it directly IMHO. > > > > No functional change intended. > > it looks ok, but it should fix the noise output then, right? Yeah, but only if -r and -I options are used at the same time. > > Acked-by: Jiri Olsa Thanks, Namhyung > > > > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/util/stat-display.c | 8 ++++---- > > tools/perf/util/stat.c | 12 ------------ > > 2 files changed, 4 insertions(+), 16 deletions(-) > > > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > > index d3137bc17065..a38fa6527586 100644 > > --- a/tools/perf/util/stat-display.c > > +++ b/tools/perf/util/stat-display.c > > @@ -807,11 +807,11 @@ static void counter_aggr_cb(struct perf_stat_config *config __maybe_unused, > > bool first __maybe_unused) > > { > > struct caggr_data *cd = data; > > - struct perf_stat_evsel *ps = counter->stats; > > + struct perf_counts_values *aggr = &counter->counts->aggr; > > > > - cd->avg += avg_stats(&ps->res_stats[0]); > > - cd->avg_enabled += avg_stats(&ps->res_stats[1]); > > - cd->avg_running += avg_stats(&ps->res_stats[2]); > > + cd->avg += aggr->val; > > + cd->avg_enabled += aggr->ena; > > + cd->avg_running += aggr->run; > > } > > > > /* > > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c > > index 2db46b9bebd0..d3ec2624e036 100644 > > --- a/tools/perf/util/stat.c > > +++ b/tools/perf/util/stat.c > > @@ -437,18 +437,6 @@ int perf_stat_process_counter(struct perf_stat_config *config, > > > > aggr->val = aggr->ena = aggr->run = 0; > > > > - /* > > - * We calculate counter's data every interval, > > - * and the display code shows ps->res_stats > > - * avg value. We need to zero the stats for > > - * interval mode, otherwise overall avg running > > - * averages will be shown for each interval. > > - */ > > - if (config->interval || config->summary) { > > - for (i = 0; i < 3; i++) > > - init_stats(&ps->res_stats[i]); > > - } > > - > > if (counter->per_pkg) > > evsel__zero_per_pkg(counter); > > > > -- > > 2.31.1.498.g6c1eba8ee3d-goog > > >