From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991AbbCSOTX (ORCPT ); Thu, 19 Mar 2015 10:19:23 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33722 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754651AbbCSOTV (ORCPT ); Thu, 19 Mar 2015 10:19:21 -0400 MIME-Version: 1.0 In-Reply-To: <20150319140031.GH2983@kernel.org> References: <20150313112046.GA28773@danjae.skbroadband> <1426251114-198991-1-git-send-email-wangnan0@huawei.com> <550A6FA6.7080805@huawei.com> <20150319072624.GA24055@sejong> <20150319140031.GH2983@kernel.org> From: Namhyung Kim Date: Thu, 19 Mar 2015 23:19:00 +0900 X-Google-Sender-Auth: qeDMk7oYMZuh6If9EAayfutFHhI Message-ID: Subject: Re: [PATCH] perf: report: don't allow empty argument for '-t'. To: Arnaldo Carvalho de Melo Cc: Wang Nan , Jiri Olsa , "linux-kernel@vger.kernel.org" , Ingo Molnar , lizefan@huawei.com, pi3orama@163.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Thu, Mar 19, 2015 at 11:00 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 19, 2015 at 04:26:24PM +0900, Namhyung Kim escreveu: >> On Thu, Mar 19, 2015 at 02:41:42PM +0800, Wang Nan wrote: >> > Hi Namhyung Kim, >> >> Hello, >> >> > >> > Do you have any comment on it? >> >> As I said in previous reply, I think perf 'diff' and 'mem' have same >> problem. So how about fix them altogether? > > So you are ok with this change, right? Can I cound that as an ack? I.e. > he could send the other fixes as separate patch(es). I'm okay with it Acked-by: Namhyung Kim Thanks, Namhyung