From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Gy5C=EC=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 424ABC4363A
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Oct 2020 05:00:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id E739521707
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Oct 2020 05:00:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1603774846;
	bh=nQczs1Nh1FpV0mlEGqTRyqoNokF2eh7CBNHmcXY9bwg=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From;
	b=ztI47hYtaLzPqJ8672/DTYYfePII36WqnBFXjQleTqOTw1j2LgHgKcaXiRc4Zdbcj
	 4p5MVK7ddASbxOvKEK7OgGYlhcFutXBgQuZNLlgf31tDf8kq9tHQE7QbRhuDLRimtY
	 0P54simdGSvvXc6XeYsQydh/k1D1f++pWwuz4yro=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2505589AbgJ0FAp (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 27 Oct 2020 01:00:45 -0400
Received: from mail-wr1-f68.google.com ([209.85.221.68]:35433 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2436452AbgJ0FAp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Oct 2020 01:00:45 -0400
Received: by mail-wr1-f68.google.com with SMTP id n15so402713wrq.2
        for <linux-kernel@vger.kernel.org>; Mon, 26 Oct 2020 22:00:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=hXPt7C+f3W4WvPcu+w1HOqYJwVh5MZK/Q2VH9P6oCkY=;
        b=nMz7dR9SEyveVBMENt2z1vTZNdb2zzWQfzOeZdLs06vnxhGlQN4HANPQHsG9mJYTzJ
         rYAvhSZlIUq1nnzfpYVPArG1MiN0QsLk8g3WiE4QxK3iiYcZvFI+ga468ePb39+FGG6M
         yRErDg8Bfm6wHcgheGMG5Hs6R2ljCo3VDLU6zaS/iJ/AKzEMb470a6kEqaKwGzmmzZwE
         9VuYYZwf1ZUCTU6+dahE77MpIL4D6UgXInGG9t0/y7NnALspkADM87luGytX1TtXhct+
         KNouwltEniMlPuIDidJZQOgdJnLmEqGmnLZ+AE132UxoTMPDL8RMwPb8lJVl+5jyBhyb
         JDPg==
X-Gm-Message-State: AOAM532UvhEM3iu/zyEybNc/Cx+w9HSJZzpu78+hGIs6bw522F71a34e
        LdwqslzEKfS4kGIUuhVARGkMRjK3QnerDDKk/5c=
X-Google-Smtp-Source: ABdhPJxPiq9QcBJihfpWptE/+LU7XGpxmep0igw+qJBas4bEJCcD3/dwVhI7rR94TGMvh/vwdyeO5/MBo1OSk2NViIs=
X-Received: by 2002:adf:a345:: with SMTP id d5mr521340wrb.55.1603774844067;
 Mon, 26 Oct 2020 22:00:44 -0700 (PDT)
MIME-Version: 1.0
References: <20201024025918.453431-1-namhyung@kernel.org> <20201024025918.453431-2-namhyung@kernel.org>
 <20201026114009.GD2726983@krava> <CAM9d7chdStkY7-tRjw9Fo+3wKdhrDYAkbNT0b-g6ftGoaZfMDQ@mail.gmail.com>
 <20201026175349.GA2449445@kernel.org>
In-Reply-To: <20201026175349.GA2449445@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 27 Oct 2020 14:00:33 +0900
Message-ID: <CAM9d7ciYY-b6e24W=ZsUdaLmjn=dYWxBg6BMm4TxosckbcGrmg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] perf stat: Support regex pattern in --for-each-cgroup
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnaldo,

On Tue, Oct 27, 2020 at 2:53 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Mon, Oct 26, 2020 at 09:32:34PM +0900, Namhyung Kim escreveu:
> > Hi Jiri,
> >
> > On Mon, Oct 26, 2020 at 8:40 PM Jiri Olsa <jolsa@redhat.com> wrote:
> > > also perhaps we want to warn if there's no match found:
> > >
> > >         $ sudo ./perf stat -a -e cpu-clock,cycles --for-each-cgroup ^foo sleep 1
> > >
> > >          Performance counter stats for 'system wide':
> > >
> > >
> > >                1.002375575 seconds time elapsed
> > >
> >
> > Right, will check this case.
>
> Hum, I thought that could be done on top of this one, but then, the
> ambiguity of:
>
> 1. No samples for a cgroups matching that expression
>
> 2. No cgroups match that expression
>
> Is real and warrants a warning for the 'no cgroups match the
> --for-each-group regexp' case.

The 1 will be handled by perf stat showing <not counted> and
I'll add a warning for the item 2 like below:

  # perf stat -a -e cycles --for-each-cgroup ^foo sleep 1
  no cgroup matched: ^foo

   Usage: perf stat [<options>] [<command>]

        --for-each-cgroup <name>
                          expand events for each cgroup

Thanks
Namhyung