From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38A0ECAAD8 for ; Thu, 22 Sep 2022 04:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbiIVEIT (ORCPT ); Thu, 22 Sep 2022 00:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230371AbiIVEHy (ORCPT ); Thu, 22 Sep 2022 00:07:54 -0400 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35783AF0D2; Wed, 21 Sep 2022 21:06:10 -0700 (PDT) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-11e9a7135easo12152435fac.6; Wed, 21 Sep 2022 21:06:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=siMkRhF/SLAewvNkB/FUmhDXG1LTV2qd6SPVClT7RXM=; b=C4mhES5BtjVJNUwSFQaZTZsj0CD4u9wtDykPtVeSPaNVsbEWNrn1BYPtLlZIbYDKaZ Qd8eGmfGlzPfW9Y3JCXkAlkYO6miiZFvy2I9Bw2qy2awCvlJ7RNTlgg0Pc7O+FGLnWOg 3xxFgJJllc4QcqbquQbYcM+kGMk/PergZgCIa0ui84ijZElAX/1+18xsxnLIeDA9jfMu iR7CIkforn71dPL4nCcyQN9QH9AK+DNvXrLuym5+xAOfJDstP4gH9RX7c6uX/UzfF9gW UAjGgSs3lRlVCrWLaNGJV971mvxhB0O7TBje0PT2tQcTutU07oobpFjM/Do6WgGx/2eb fi/w== X-Gm-Message-State: ACrzQf0CD6PRr9mlTyxVPNuGW0/CvwQYuo0p1pwBdgjhNfEBuOnhL1PG KTPqr2lTm9Y61H+r6s1YYImmBTHcpzE1QlzlYulVdSfX X-Google-Smtp-Source: AMsMyM4y6qxzP6Yh1L9Q0h9wWC2dT6c/ICcvE7FfxlDfZYPCF7u7MfOowlgP/hMhzqyR2mupWed9yStTEMlJTwn1eAA= X-Received: by 2002:a05:6870:524b:b0:12c:cfd2:81c0 with SMTP id o11-20020a056870524b00b0012ccfd281c0mr802693oai.209.1663819532230; Wed, 21 Sep 2022 21:05:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Namhyung Kim Date: Wed, 21 Sep 2022 21:05:20 -0700 Message-ID: Subject: Re: [PATCH v3 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[] To: Tejun Heo Cc: cgroups , Zefan Li , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Christian Brauner , linux-kernel , Kernel Team , Pablo Neira Ayuso , Arnaldo Carvalho de Melo , Jiri Olsa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Mon, Aug 15, 2022 at 2:17 PM Tejun Heo wrote: > > On Fri, Jul 29, 2022 at 01:10:16PM -1000, Tejun Heo wrote: > > Every cgroup knows all its ancestors through its ->ancestor_ids[]. There's > > no advantage to remembering the IDs instead of the pointers directly and > > this makes the array useless for finding an actual ancestor cgroup forcing > > cgroup_ancestor() to iteratively walk up the hierarchy instead. Let's > > replace cgroup->ancestor_ids[] with ->ancestors[] and remove the walking-up > > from cgroup_ancestor(). > > > > While at it, improve comments around cgroup_root->cgrp_ancestor_storage. > > > > This patch shouldn't cause user-visible behavior differences. > > > > v2: Update cgroup_ancestor() to use ->ancestors[]. > > > > v3: cgroup_root->cgrp_ancestor_storage's type is updated to match > > cgroup->ancestors[]. Better comments. > > > > Signed-off-by: Tejun Heo > > Acked-by: Namhyung Kim > > Applied to cgroup/for-6.1. I've realized that perf stat change needs backward compatibility. Will send a fix soon. Thanks, Namhyung From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namhyung Kim Subject: Re: [PATCH v3 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[] Date: Wed, 21 Sep 2022 21:05:20 -0700 Message-ID: References: Mime-Version: 1.0 Return-path: In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: cgroups , Zefan Li , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Christian Brauner , linux-kernel , Kernel Team , Pablo Neira Ayuso , Arnaldo Carvalho de Melo , Jiri Olsa Hi Tejun, On Mon, Aug 15, 2022 at 2:17 PM Tejun Heo wrote: > > On Fri, Jul 29, 2022 at 01:10:16PM -1000, Tejun Heo wrote: > > Every cgroup knows all its ancestors through its ->ancestor_ids[]. There's > > no advantage to remembering the IDs instead of the pointers directly and > > this makes the array useless for finding an actual ancestor cgroup forcing > > cgroup_ancestor() to iteratively walk up the hierarchy instead. Let's > > replace cgroup->ancestor_ids[] with ->ancestors[] and remove the walking-up > > from cgroup_ancestor(). > > > > While at it, improve comments around cgroup_root->cgrp_ancestor_storage. > > > > This patch shouldn't cause user-visible behavior differences. > > > > v2: Update cgroup_ancestor() to use ->ancestors[]. > > > > v3: cgroup_root->cgrp_ancestor_storage's type is updated to match > > cgroup->ancestors[]. Better comments. > > > > Signed-off-by: Tejun Heo > > Acked-by: Namhyung Kim > > Applied to cgroup/for-6.1. I've realized that perf stat change needs backward compatibility. Will send a fix soon. Thanks, Namhyung