All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taehee Yoo <ap420073@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: core: reduce recursion limit value
Date: Tue, 16 Jun 2020 19:49:00 +0900	[thread overview]
Message-ID: <CAMArcTWXDb3RX3NjkU22Q9J417XKOt5ghzmQw5Yt0w=UGzH-nQ@mail.gmail.com> (raw)
In-Reply-To: <20200615152148.GE16460@breakpoint.cc>

On Tue, 16 Jun 2020 at 00:21, Florian Westphal <fw@strlen.de> wrote:
>

Hi Florian,
Thank you for the review!

> Taehee Yoo <ap420073@gmail.com> wrote:
> > In the current code, ->ndo_start_xmit() can be executed recursively only
> > 10 times because of stack memory.
> > But, in the case of the vxlan, 10 recursion limit value results in
> > a stack overflow.
> [..]
>
> > Fixes: 97cdcf37b57e ("net: place xmit recursion in softnet data")
>
> That commit did not change the recursion limit,
> 11a766ce915fc9f86 ("net: Increase xmit RECURSION_LIMIT to 10.") did?

You're right.
I will send a v2 patch.

Thanks!

      reply	other threads:[~2020-06-16 10:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 15:00 [PATCH net] net: core: reduce recursion limit value Taehee Yoo
2020-06-15 15:21 ` Florian Westphal
2020-06-16 10:49   ` Taehee Yoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMArcTWXDb3RX3NjkU22Q9J417XKOt5ghzmQw5Yt0w=UGzH-nQ@mail.gmail.com' \
    --to=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.