From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26724C43381 for ; Fri, 22 Feb 2019 07:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E35FB207E0 for ; Fri, 22 Feb 2019 07:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qws/uKDK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726247AbfBVHtC (ORCPT ); Fri, 22 Feb 2019 02:49:02 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:39704 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfBVHtC (ORCPT ); Fri, 22 Feb 2019 02:49:02 -0500 Received: by mail-ot1-f67.google.com with SMTP id n8so1134949otl.6 for ; Thu, 21 Feb 2019 23:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ps2vwFpYmLCHRs8qc7Azl4NoCLz61dYA4FysUNBeNNw=; b=Qws/uKDKLG0SyAsOEKV5w8clBAwnNAyI7jSqjx2SoQ98N4HQ5TkVbvZil/uoByJ+cR ZisKXUBergc51KjJKlkSx6+ZqL/ILD/PrIy1di8hgYaGMOe78qeKcGn2fT5/ONTVmjgX LzsijY6/smqWppDXMMFlm8G6dwlU2pOtFqn7Oz+Y0xWwVxlq4fnWA7jYwtgkkuOw9m+3 TQ3JyHU/vSkAoNvgUHPvHy1bXVybjgl2QAGf7QMNfvXbl+vX3dmHOqzVMCChoARWOZIZ pgt32N5wC1c7bjC4Iygmemm3YMK1kif9llPEmO4H4Z5FNE9JfWA0qP8uHIZaQTqn1s3t 9nxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ps2vwFpYmLCHRs8qc7Azl4NoCLz61dYA4FysUNBeNNw=; b=J0Ln2JAoUpG/3/6ofWwznKAWrWW2nu5EN7t+aWGAhsePhJUZaj8gpshcwm8QUySH/A 5gGvei0on42Xj1lFxFqhgg7/HR+UlRA8BgHt+N2g6bVyclaf6AMi4AI9571tBRHQ0vt3 6jldM+PJkMFmEEMtNzs4XoaanSZw4h3FaLPsiRKwJghKMIDJdUYXn+1PrXr8KHxUoNpx fVK2T5QiRikySVlWbNtPob0h/Fp9h8XXjBTytknWCB+cv/6/XV2/PEJTvAqEmn8PvCeV 6ADcydsC1iHqTGlR9RZwDShJiFxK01R9g4IANTKW9gjGb6Tea63GpixR5gXdJPTOk4bm lZ2A== X-Gm-Message-State: AHQUAuYOBqsedQ3dWwGwU5h+CrI1dW2HIWy7r3aL/c1NXDtqHWC5YgzF zCz985II2ze9I7J4LMzBrqGkLpdWul2yR+lRKJQ= X-Google-Smtp-Source: AHgI3Ib4txVUThoYJrTBJmxxzGhTGgQsMVEjdJcy1tJoqmQxtTavo72Cu4oL7ZRLu9vQUqK1VTdD0Mq9jWpiBZPlpJc= X-Received: by 2002:a9d:75d6:: with SMTP id c22mr1950908otl.46.1550821741873; Thu, 21 Feb 2019 23:49:01 -0800 (PST) MIME-Version: 1.0 References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> <1550715283-23579-2-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Tonghao Zhang Date: Fri, 22 Feb 2019 15:48:25 +0800 Message-ID: Subject: Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported To: Or Gerlitz Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > > > From: Tonghao Zhang > > > > If we try to offload decapsulation actions to VFs hw, we get the log [1]. > > but the switching was on the tunnel type (if (tunnel_type == [...]) - Yes, but we try to offload tc flow to VF device. For example the p2p1_0 is VF, but not rep tc qdisc add dev p2p1_0 ingress ethtool -K p2p1_0 hw-tc-offload on tc filter add dev p2p1_0 protocol ip chain 0 parent ffff: prio 1 flower skip_sw dst_mac 00:10:56:fb:64:e8 dst_ip 10.100.3.104 src_ip 10.100.4.0/24 enc_dst_ip 192.168.240.128 enc_key_id 100 enc_dst_port 4789 action tunnel_key unset > what rules caused you to get here? > what was the ingress device and what was the egress (mirred) device? the ingress device is p2p1_0 (VF), and the egress (mirred) device is not used > > > It's not friendly, because the kind of net device is null, and we don't > > know what '0' means. > > > > [1] "mlx5_core 0000:05:01.2 vf_0: decapsulation offload is not supported for net device (0)"