From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80358C4346E for ; Tue, 29 Sep 2020 06:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E2D320BED for ; Tue, 29 Sep 2020 06:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NxNiZNJ+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727582AbgI2GD6 (ORCPT ); Tue, 29 Sep 2020 02:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgI2GD6 (ORCPT ); Tue, 29 Sep 2020 02:03:58 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63C2C061755 for ; Mon, 28 Sep 2020 23:03:57 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id nw23so13303034ejb.4 for ; Mon, 28 Sep 2020 23:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbzGI2E63rvacCgT4IMKli2vxVX3CttMz/Tx1YiiZz4=; b=NxNiZNJ+OG8oxMmSK7C6prgulO6SqIcircN1UxT/zdOGR92Uemo+KDnwi9gT0syDgZ /nEIFdDUiHPieQZrs5fA5lGMztANsWA41JiobgsR/bSJVTABbJD4Vc/BtrGBXsUepY1F 5Nk/m+D46iZ8n5qs56ejH60OiZN4zjU392fNgEQTUtWNNZHWytx0r/ZTvBRcvuybUqad XkKz/qBEEeMc1x44VTnwc8bc/TITwSu2UbsZz+4WjbfvaHc+UDVdGegNcrPwroG18wAW JQALySM+3lHTMbiMVH+ODU2to/AvBeeM5u/wd2bhoatGd6GCTcyFz4zWkTmQUD0VSiEf fxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbzGI2E63rvacCgT4IMKli2vxVX3CttMz/Tx1YiiZz4=; b=ogvc41EM2MJeW8OTO+FTOsG/hSb065bkoXFKF5TQ4SppOC/ZRYbx6DHm2c4W4wkbBc eDVx1p8VKLmWDYJjQClOmDjA6XiRtuu2cVK5YfvNp5zlTgjjgK8i8JKH5nedKLZYbS0t +48gtOS2Q/K+gPOFY2XnVLTzIIC1TxHpkyDfvW5PYiPCbRaN9p/iqnCNZuj+JCvBhxe3 uRP4j/KsSzdx7+RrhFx0EbojZwaI89avZidV08x0QAg7z3tLfxVdaCxqWHovwiazl4b7 9sjAjOEjKslB9OGhLX3Ns5OKK//UJCyzehN7fHe0DIGWTyiNIgxyEH6FeluiLBMNJsZj TMpg== X-Gm-Message-State: AOAM532rg9NOJ+JTL5IW9dG4QqIuLTGdja1ndDrHTFJopfj2KIgFzOkK uJ3qTmW9T82X7KHv6GG3VoPnGZrkljOYAuVadZI= X-Google-Smtp-Source: ABdhPJx4NzKw/Sv5M31LactrcvvEGd5J1cmI3BJLFWADl29QUTQ+on8SInzw2zCQ0mO4/8iDIsy3zhNZ2eCoIisHQX8= X-Received: by 2002:a17:906:178d:: with SMTP id t13mr2350935eje.410.1601359436511; Mon, 28 Sep 2020 23:03:56 -0700 (PDT) MIME-Version: 1.0 References: <20200928033915.82810-1-xiangxia.m.yue@gmail.com> <20200928151531-mutt-send-email-mst@kernel.org> <20200929015624-mutt-send-email-mst@kernel.org> In-Reply-To: <20200929015624-mutt-send-email-mst@kernel.org> From: Tonghao Zhang Date: Tue, 29 Sep 2020 14:01:32 +0800 Message-ID: Subject: Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO To: "Michael S. Tsirkin" Cc: Jason Wang , virtualization@lists.linux-foundation.org, Linux Kernel Network Developers , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 29, 2020 at 1:57 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:40:22AM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue@gmail.com wrote: > > > > From: Tonghao Zhang > > > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > > when this interface added to them. Now when disable the LRO, the > > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > > > > > I am a bit confused by this tag. Did this change bring about > > > disabling checksum when LRO is disabled? I am not sure > > > I follow how ... > > Hi Michael > > It's not right fix tag. > > The commit a02e8964eaf9 ("virtio-net: ethtool configurable LRO"), > > disable the csum, when we disable the LRO > > OK then, pls send a correct Fixes tag when you repost this ... Hi Michael I repost this patch, please review. thanks. http://patchwork.ozlabs.org/project/netdev/patch/20200929015806.19171-1-xiangxia.m.yue@gmail.com/ > > > > Cc: Michael S. Tsirkin > > > > Cc: Jason Wang > > > > Cc: Willem de Bruijn > > > > Signed-off-by: Tonghao Zhang > > > > --- > > > > drivers/net/virtio_net.c | 8 +++++++- > > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > > index 7145c83c6c8c..21b71148c532 100644 > > > > --- a/drivers/net/virtio_net.c > > > > +++ b/drivers/net/virtio_net.c > > > > @@ -63,6 +63,11 @@ static const unsigned long guest_offloads[] = { > > > > VIRTIO_NET_F_GUEST_CSUM > > > > }; > > > > > > > > +#define GUEST_OFFLOAD_LRO_MASK ((1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_ECN) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_UFO)) > > > > + > > > > struct virtnet_stat_desc { > > > > char desc[ETH_GSTRING_LEN]; > > > > size_t offset; > > > > @@ -2531,7 +2536,8 @@ static int virtnet_set_features(struct net_device *dev, > > > > if (features & NETIF_F_LRO) > > > > offloads = vi->guest_offloads_capable; > > > > else > > > > - offloads = 0; > > > > + offloads = vi->guest_offloads_capable & > > > > + ~GUEST_OFFLOAD_LRO_MASK; > > > > > > > > err = virtnet_set_guest_offloads(vi, offloads); > > > > if (err) > > > > -- > > > > 2.23.0 > > > > > > > > > -- > > Best regards, Tonghao > -- Best regards, Tonghao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653D3C4346E for ; Tue, 29 Sep 2020 06:04:04 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F23220BED for ; Tue, 29 Sep 2020 06:04:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NxNiZNJ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F23220BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E047C86FF8; Tue, 29 Sep 2020 06:04:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PAyQXR6ppBNw; Tue, 29 Sep 2020 06:04:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 55C0B86FCF; Tue, 29 Sep 2020 06:04:03 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3FEAFC016F; Tue, 29 Sep 2020 06:04:03 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4857EC0051 for ; Tue, 29 Sep 2020 06:04:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 427FB8527F for ; Tue, 29 Sep 2020 06:04:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kT3kryuO7U5e for ; Tue, 29 Sep 2020 06:03:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 2824C80614 for ; Tue, 29 Sep 2020 06:03:58 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id z23so13216741ejr.13 for ; Mon, 28 Sep 2020 23:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbzGI2E63rvacCgT4IMKli2vxVX3CttMz/Tx1YiiZz4=; b=NxNiZNJ+OG8oxMmSK7C6prgulO6SqIcircN1UxT/zdOGR92Uemo+KDnwi9gT0syDgZ /nEIFdDUiHPieQZrs5fA5lGMztANsWA41JiobgsR/bSJVTABbJD4Vc/BtrGBXsUepY1F 5Nk/m+D46iZ8n5qs56ejH60OiZN4zjU392fNgEQTUtWNNZHWytx0r/ZTvBRcvuybUqad XkKz/qBEEeMc1x44VTnwc8bc/TITwSu2UbsZz+4WjbfvaHc+UDVdGegNcrPwroG18wAW JQALySM+3lHTMbiMVH+ODU2to/AvBeeM5u/wd2bhoatGd6GCTcyFz4zWkTmQUD0VSiEf fxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbzGI2E63rvacCgT4IMKli2vxVX3CttMz/Tx1YiiZz4=; b=XjflpwYn/B3u5mBLTdFw8R0DtJQRVdtUuZ84aMi/LQRBPZSC2UFrPQmveBrU5TbWGb HsX6jQ9ZYU9KOz8GiT8PZxxdFnNMirBIa2DgLNqGCrRrFkR6gpz/NSTOpl17WL14YQBR KmFYG2ReGmjPY2YIgIlHQob8sSsZ09Ivr9Lv4eZTIaFvjdO+lvEhFFrLgZG1m9xWaGbh 9Ma3Mu2WY6O6DWNNq1nJiioUtemRhwyNYDzsZYlt3PS7kpXC2QHfAbSAFwwnvmngIgUj 6msvSK7UBCfrcSz8nQXQByXUrKSq70EBHU5nmugDzjs2lyqpRmRMtzttMwG4HXjatXyx LxCA== X-Gm-Message-State: AOAM532Bmf+sgxImmWQ5wSbijfCK8xjbjm4vojiR8Haz/NjLhAMZnkcy MgfqJi4/+NIIhjIG5/WRDvyBHxPPGK4LNgoQzSM= X-Google-Smtp-Source: ABdhPJx4NzKw/Sv5M31LactrcvvEGd5J1cmI3BJLFWADl29QUTQ+on8SInzw2zCQ0mO4/8iDIsy3zhNZ2eCoIisHQX8= X-Received: by 2002:a17:906:178d:: with SMTP id t13mr2350935eje.410.1601359436511; Mon, 28 Sep 2020 23:03:56 -0700 (PDT) MIME-Version: 1.0 References: <20200928033915.82810-1-xiangxia.m.yue@gmail.com> <20200928151531-mutt-send-email-mst@kernel.org> <20200929015624-mutt-send-email-mst@kernel.org> In-Reply-To: <20200929015624-mutt-send-email-mst@kernel.org> From: Tonghao Zhang Date: Tue, 29 Sep 2020 14:01:32 +0800 Message-ID: Subject: Re: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO To: "Michael S. Tsirkin" Cc: Linux Kernel Network Developers , Willem de Bruijn , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Sep 29, 2020 at 1:57 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:40:22AM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue@gmail.com wrote: > > > > From: Tonghao Zhang > > > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > > when this interface added to them. Now when disable the LRO, the > > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > > > > > I am a bit confused by this tag. Did this change bring about > > > disabling checksum when LRO is disabled? I am not sure > > > I follow how ... > > Hi Michael > > It's not right fix tag. > > The commit a02e8964eaf9 ("virtio-net: ethtool configurable LRO"), > > disable the csum, when we disable the LRO > > OK then, pls send a correct Fixes tag when you repost this ... Hi Michael I repost this patch, please review. thanks. http://patchwork.ozlabs.org/project/netdev/patch/20200929015806.19171-1-xiangxia.m.yue@gmail.com/ > > > > Cc: Michael S. Tsirkin > > > > Cc: Jason Wang > > > > Cc: Willem de Bruijn > > > > Signed-off-by: Tonghao Zhang > > > > --- > > > > drivers/net/virtio_net.c | 8 +++++++- > > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > > index 7145c83c6c8c..21b71148c532 100644 > > > > --- a/drivers/net/virtio_net.c > > > > +++ b/drivers/net/virtio_net.c > > > > @@ -63,6 +63,11 @@ static const unsigned long guest_offloads[] = { > > > > VIRTIO_NET_F_GUEST_CSUM > > > > }; > > > > > > > > +#define GUEST_OFFLOAD_LRO_MASK ((1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_ECN) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_UFO)) > > > > + > > > > struct virtnet_stat_desc { > > > > char desc[ETH_GSTRING_LEN]; > > > > size_t offset; > > > > @@ -2531,7 +2536,8 @@ static int virtnet_set_features(struct net_device *dev, > > > > if (features & NETIF_F_LRO) > > > > offloads = vi->guest_offloads_capable; > > > > else > > > > - offloads = 0; > > > > + offloads = vi->guest_offloads_capable & > > > > + ~GUEST_OFFLOAD_LRO_MASK; > > > > > > > > err = virtnet_set_guest_offloads(vi, offloads); > > > > if (err) > > > > -- > > > > 2.23.0 > > > > > > > > > -- > > Best regards, Tonghao > -- Best regards, Tonghao _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization