All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Greg Rose <gvrose8192@gmail.com>
Subject: Re: [PATCH v3] datapath: Avoid using stack larger than 1024.
Date: Fri, 30 Jun 2017 12:38:55 +0800	[thread overview]
Message-ID: <CAMDZJNX3hQ2AK3WUdd9vjfyVCAPauYVV9bK4bGYh=9B53jbqyA@mail.gmail.com> (raw)
In-Reply-To: <CAOrHB_B7PpKMdVn8JNG9B-R6i80Zxn8rEBBptCSKCTz6TdsU6g@mail.gmail.com>

Thanks for your works. I send v3 for net-next and add "Acked-by".
If it is applied, I will backport it to dev@openvswitch.org.

On Fri, Jun 30, 2017 at 1:45 AM, Pravin Shelar <pshelar@ovn.org> wrote:
> On Wed, Jun 28, 2017 at 6:38 PM, Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
>> When compiling OvS-master on 4.4.0-81 kernel,
>> there is a warning:
>>
>>     CC [M]  /root/ovs/datapath/linux/datapath.o
>>     /root/ovs/datapath/linux/datapath.c: In function
>>     'ovs_flow_cmd_set':
>>     /root/ovs/datapath/linux/datapath.c:1221:1: warning:
>>     the frame size of 1040 bytes is larger than 1024 bytes
>>     [-Wframe-larger-than=]
>>
>> This patch factors out match-init and action-copy to avoid
>> "Wframe-larger-than=1024" warning. Because mask is only
>> used to get actions, we new a function to save some
>> stack space.
>>
>> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>> ---
> Looks good, you have to submit patch against net-next for upstream OVS
> module first.

      reply	other threads:[~2017-06-30  4:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  1:38 [PATCH v3] datapath: Avoid using stack larger than 1024 Tonghao Zhang
2017-06-29 17:45 ` Pravin Shelar
2017-06-30  4:38   ` Tonghao Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMDZJNX3hQ2AK3WUdd9vjfyVCAPauYVV9bK4bGYh=9B53jbqyA@mail.gmail.com' \
    --to=xiangxia.m.yue@gmail.com \
    --cc=gvrose8192@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.