From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Subject: Re: [PATCH v5 2/2] sock: Move the socket inuse to namespace.
Date: Fri, 8 Dec 2017 13:28:22 +0800
Message-ID: <CAMDZJNXPtcNf4zHjbkJWwfvToXt-i7mxfm5VDf+0FSR4ZFV_Hg@mail.gmail.com>
References: <1512665148-2413-1-git-send-email-xiangxia.m.yue@gmail.com>
 <1512665148-2413-2-git-send-email-xiangxia.m.yue@gmail.com> <1512667208.25033.13.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: David Miller <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Willem de Bruijn <willemb@google.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-oi0-f68.google.com ([209.85.218.68]:44612 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751106AbdLHF2X (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Dec 2017 00:28:23 -0500
Received: by mail-oi0-f68.google.com with SMTP id l6so6513518oih.11
        for <netdev@vger.kernel.org>; Thu, 07 Dec 2017 21:28:23 -0800 (PST)
In-Reply-To: <1512667208.25033.13.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Dec 8, 2017 at 1:20 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote=
:
> On Thu, 2017-12-07 at 08:45 -0800, Tonghao Zhang wrote:
>> In some case, we want to know how many sockets are in use in
>> different _net_ namespaces. It's a key resource metric.
>>
>
> ...
>
>> +static void sock_inuse_add(struct net *net, int val)
>> +{
>> +     if (net->core.prot_inuse)
>> +             this_cpu_add(*net->core.sock_inuse, val);
>> +}
>
> This is very confusing.
>
> Why testing net->core.prot_inuse for NULL is needed at all ?
>
> Why not testing net->core.sock_inuse instead ?
>
Hi Eric and Cong, oh it's a typo. it's net->core.sock_inuse there. Why
we should check the net->core.sock_inuse
Now show you the code:

cleanup_net will call all of the network namespace exit methods,
rcu_barrier, and then remove the _net_ namespace.

cleanup_net:
    list_for_each_entry_reverse(ops, &pernet_list, list)
         ops_exit_list(ops, &net_exit_list);

    rcu_barrier(); /* for netlink sock, the =E2=80=98deferred_put_nlk_sk=E2=
=80=99 will
be called. But sock_inuse has been released. */


    /* Finally it is safe to free my network namespace structure */
    list_for_each_entry_safe(net, tmp, &net_exit_list, exit_list) {}



Release the netlink sock created in kernel(not hold the _net_ namespace):

netlink_release
       call_rcu(&nlk->rcu, deferred_put_nlk_sk);

deferred_put_nlk_sk
       sk_free(sk);


I may add a comment for sock_inuse_add in v6.