From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3E3C43381 for ; Fri, 22 Feb 2019 07:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46F1120823 for ; Fri, 22 Feb 2019 07:40:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHylzvUj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726273AbfBVHkP (ORCPT ); Fri, 22 Feb 2019 02:40:15 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39488 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfBVHkO (ORCPT ); Fri, 22 Feb 2019 02:40:14 -0500 Received: by mail-oi1-f195.google.com with SMTP id b4so1029323oif.6 for ; Thu, 21 Feb 2019 23:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gJy8JQpi6iHQRoNBumwrVqlN4AHikS4Q64A1/IR/sgU=; b=fHylzvUjm+CdoBg9I4gOtz0LvUI0sTXgL5/OiicepwRTaWoDW7s9LfmUGwVrceJ2sB ztjSApEz5Hv0D+//XBwcrfP1sZ3O3GEaaJnXj0/QzDKdUDjZo3EfYk/Nxp/1PwFVWKXb A+Q/bBvNcyHF/MQEoNDYQGky26N5eKSGW2MvjIK/wtK4MR9/rUIEiwP5p/EraWnUafeX 6TeO1xL3fGmsc3AneGlSMRUJbjDi9BrYwLshL9zjhipcl+V3ITQXEZRVfYgAv3LypTVH q7/ohOdvOKw5mpXacKdWACJjdMZpR5EUkK8vMJ09N11D2wg2kmSsnNPElbNjjBkGARHS nq/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gJy8JQpi6iHQRoNBumwrVqlN4AHikS4Q64A1/IR/sgU=; b=VcKFKcBFb+wxdZ5S6FGn99+YtCVmKIGj6eLjq9ZVZ73/Jl2WOAl5Fe+8pvjqWBJMUS PDXI0XYa0z0cHuOiGbQPyhNAUe3PgCoQOAs19T9jDtxnsvq9NVPqeX4/Zsj3yxAmSR5p IohluDUPIhx0IXfhmWD28QdID7i5UWCCfFqA0fYcWD8yj9tjqQ0EU+8TTWJ9q7+Mqzgw NFc60oonevYaoM3DzUFHvLQIIuNbbh8rWLr3Veek4gotaT6R6uiEBGorQQdldljSgpJp W29UUgZCUZMc2MMsUrZJdKOlx2TpuQyLJewlLakKUpsgLuoGLdVIs1k7iXOjqTCpDIxP zHqw== X-Gm-Message-State: AHQUAuaH76ccQMGaPr+WNO2RjmjqdDSeSmWhAsjSm5fUrGHpWSrUahHK vLUA9vLXlw+i3ZUQ0kFHjh3amRT/tFH2bs5UZXE= X-Google-Smtp-Source: AHgI3IajGi3ziKHQRPNrAhvgjS9mY1klLWCd072q6PEHFTFrTYGwPdrf2aPkPTAws2Qy95IsyvdkVUlXuehGDTW6U8I= X-Received: by 2002:aca:d50d:: with SMTP id m13mr1658023oig.101.1550821214228; Thu, 21 Feb 2019 23:40:14 -0800 (PST) MIME-Version: 1.0 References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Tonghao Zhang Date: Fri, 22 Feb 2019 15:39:38 +0800 Message-ID: Subject: Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero To: Or Gerlitz Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 22, 2019 at 12:27 AM Or Gerlitz wrote: > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, max_modify_header_actions); > > > > + if (!max_actions) { > > + NL_SET_ERR_MSG_MOD(extack, > > + "don't support pedit actions, can't offload"); > > + netdev_warn(priv->netdev, "don't support pedit actions, can't offload\n"); > > it's not going to work if we keep filling the driver with duplicated > error messages, stick to extack only v2 will be sent > Also, when you respin with comments provided on this submission, > please send also cover letter > which is going to be "[PATCH net-next 00/05] ... " use > --cover-letter for git format-patch and edit it after creation OK