From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIEtvemlr?= Subject: Re: [PATCH 0/4] support for write combining Date: Mon, 30 Apr 2018 10:07:07 +0200 Message-ID: References: <1523455637-31719-1-git-send-email-rk@semihalf.com> <20180411144251.GA33124@bricha3-MOBL.ger.corp.intel.com> <20180427113030.GA101968@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Marcin Wojtas , =?UTF-8?Q?Micha=C5=82_Krawczyk?= , "Tzalik, Guy" , evgenys@amazon.com, "Matushevsky, Alexander" , "Chauskin, Igor" , Ferruh Yigit To: Bruce Richardson Return-path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 7AE21DED for ; Mon, 30 Apr 2018 10:07:09 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id m18-v6so10990229lfb.0 for ; Mon, 30 Apr 2018 01:07:09 -0700 (PDT) In-Reply-To: <20180427113030.GA101968@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Bruce, It should work because decision about kind of mapping is made in patch 3 based on PMD request. ENA use only one BAR in wc mode and two other without caching, therefore not making remap in igb_uio rather not spoil anything. I added patch 1 because this variable is provided also outside the DPDK to Linux generic functions. I cannot test it with all drivers, therefore I make it configurable. But general combination of wc and not wc PMD should work, because of patch 3. Also if WC is enabled by PMD (like in patch 4) not all BARs will by mapped, but only those which has prefetchable flag enabled. Best regards, Rafal Kozik