From: Jinpu Wang <jinpu.wang@ionos.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Mike Snitzer" <snitzer@redhat.com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
"Roger Pau Monné" <roger.pau@citrix.co>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com
Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
Date: Thu, 20 Jan 2022 09:46:23 +0100 [thread overview]
Message-ID: <CAMGffE=+ENBdRfugG4k3yB_ca3rqwnaKFXC4+8=CZ=LGvggA6w@mail.gmail.com> (raw)
In-Reply-To: <20220120083746.GA5622@lst.de>
On Thu, Jan 20, 2022 at 9:37 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote:
> > this changes lead to IO error all the time, because bio_add_page return len.
> > We need if (bio_add_page(bio, virt_to_page(data), datalen,
> > offset_in_page(data)) < datalen)
>
> Does this version look good to you?
>
> http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631
Yes, lgtm, thank you!
Reviewed-by: Jack Wang <jinpu.wang@ionons.com>
Tested-by: Jack Wang <jinpu.wang@ionos.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jinpu Wang <jinpu.wang@ionos.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-nilfs@vger.kernel.org, "Mike Snitzer" <snitzer@redhat.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Roger Pau Monné" <roger.pau@citrix.co>,
dm-devel@redhat.com, "Md . Haris Iqbal" <haris.iqbal@ionos.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org,
"Andrew Morton" <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, "Pavel Begunkov" <asml.silence@gmail.com>,
drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
Date: Thu, 20 Jan 2022 09:46:23 +0100 [thread overview]
Message-ID: <CAMGffE=+ENBdRfugG4k3yB_ca3rqwnaKFXC4+8=CZ=LGvggA6w@mail.gmail.com> (raw)
In-Reply-To: <20220120083746.GA5622@lst.de>
On Thu, Jan 20, 2022 at 9:37 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote:
> > this changes lead to IO error all the time, because bio_add_page return len.
> > We need if (bio_add_page(bio, virt_to_page(data), datalen,
> > offset_in_page(data)) < datalen)
>
> Does this version look good to you?
>
> http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631
Yes, lgtm, thank you!
Reviewed-by: Jack Wang <jinpu.wang@ionons.com>
Tested-by: Jack Wang <jinpu.wang@ionos.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jinpu Wang <jinpu.wang-vEVw2sk9H7kAvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: "Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Mike Snitzer" <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Philipp Reisner"
<philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>,
"Ryusuke Konishi"
<konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Konstantin Komarov"
<almaz.alexandrovich-m5I1DM4ARimttCpgsWEBFlaTQe2KTcn/@public.gmane.org>,
"Roger Pau Monné"
<roger.pau-Sxgqhf6Nn4Bhl2p70BpVqQ@public.gmane.org>,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
"Md . Haris Iqbal"
<haris.iqbal-vEVw2sk9H7kAvxtiuMwx3w@public.gmane.org>,
"Lars Ellenberg"
<lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
ntfs3-cunTk1MwBs/YUNznpcFYbw@public.gmane.org,
"Pavel Begunkov"
<asml.silence-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
Date: Thu, 20 Jan 2022 09:46:23 +0100 [thread overview]
Message-ID: <CAMGffE=+ENBdRfugG4k3yB_ca3rqwnaKFXC4+8=CZ=LGvggA6w@mail.gmail.com> (raw)
In-Reply-To: <20220120083746.GA5622-jcswGhMUV9g@public.gmane.org>
On Thu, Jan 20, 2022 at 9:37 AM Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
>
> On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote:
> > this changes lead to IO error all the time, because bio_add_page return len.
> > We need if (bio_add_page(bio, virt_to_page(data), datalen,
> > offset_in_page(data)) < datalen)
>
> Does this version look good to you?
>
> http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631
Yes, lgtm, thank you!
Reviewed-by: Jack Wang <jinpu.wang-6tqlonuGt1TQT0dZR+AlfA@public.gmane.org>
Tested-by: Jack Wang <jinpu.wang-vEVw2sk9H7kAvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2022-01-20 8:46 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 7:19 improve the bio allocation interface Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 01/19] fs: remove mpage_alloc Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 02/19] nilfs2: remove nilfs_alloc_seg_bio Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 03/19] nfs/blocklayout: remove bl_alloc_init_bio Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 04/19] ntfs3: remove ntfs_alloc_bio Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 05/19] dm: bio_alloc can't fail if it is allowed to sleep Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 06/19] dm-crypt: remove clone_init Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 08/19] dm-thin: " Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 09/19] drbd: bio_alloc can't fail if it is allow to sleep Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-19 0:20 ` Jinpu Wang
2022-01-19 0:20 ` [dm-devel] " Jinpu Wang
2022-01-19 0:48 ` Jinpu Wang
2022-01-19 0:48 ` [dm-devel] " Jinpu Wang
2022-01-20 8:37 ` Christoph Hellwig
2022-01-20 8:37 ` Christoph Hellwig
2022-01-20 8:37 ` [dm-devel] " Christoph Hellwig
2022-01-20 8:46 ` Jinpu Wang [this message]
2022-01-20 8:46 ` Jinpu Wang
2022-01-20 8:46 ` [dm-devel] " Jinpu Wang
2022-01-18 7:19 ` [PATCH 11/19] rnbd-src: remove struct rnbd_dev_blk_io Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-19 15:32 ` Jinpu Wang
2022-01-19 15:32 ` [dm-devel] " Jinpu Wang
2022-01-18 7:19 ` [PATCH 12/19] xen-blkback: bio_alloc can't fail if it is allow to sleep Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] [PATCH 13/19] block: move blk_next_bio to bio.c Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 22:10 ` Chaitanya Kulkarni
2022-01-18 22:10 ` Chaitanya Kulkarni
2022-01-18 22:10 ` [dm-devel] " Chaitanya Kulkarni
2022-01-18 7:19 ` [PATCH 14/19] block: pass a block_device and opf to blk_next_bio Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 22:11 ` Chaitanya Kulkarni
2022-01-18 22:11 ` Chaitanya Kulkarni
2022-01-18 22:11 ` [dm-devel] " Chaitanya Kulkarni
2022-01-20 8:34 ` Christoph Hellwig
2022-01-20 8:34 ` Christoph Hellwig
2022-01-20 8:34 ` [dm-devel] " Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] [PATCH 15/19] block: pass a block_device and opf to bio_alloc_bioset Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 22:12 ` Chaitanya Kulkarni
2022-01-18 22:12 ` Chaitanya Kulkarni
2022-01-18 22:12 ` [dm-devel] " Chaitanya Kulkarni
2022-01-18 7:19 ` [PATCH 16/19] block: pass a block_device and opf to bio_alloc_kiocb Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 22:12 ` Chaitanya Kulkarni
2022-01-18 22:12 ` Chaitanya Kulkarni
2022-01-18 22:12 ` [dm-devel] " Chaitanya Kulkarni
2022-01-18 7:19 ` [PATCH 17/19] block: pass a block_device and opf to bio_alloc Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 22:14 ` Chaitanya Kulkarni
2022-01-18 22:14 ` Chaitanya Kulkarni
2022-01-18 22:14 ` [dm-devel] " Chaitanya Kulkarni
2022-01-18 7:19 ` [PATCH 18/19] block: pass a block_device and opf to bio_init Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 22:15 ` Chaitanya Kulkarni
2022-01-18 22:15 ` Chaitanya Kulkarni
2022-01-18 22:15 ` [dm-devel] " Chaitanya Kulkarni
2022-01-18 7:19 ` [PATCH 19/19] block: pass a block_device and opf to bio_reset Christoph Hellwig
2022-01-18 7:19 ` Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] " Christoph Hellwig
2022-01-18 22:16 ` Chaitanya Kulkarni
2022-01-18 22:16 ` Chaitanya Kulkarni
2022-01-18 22:16 ` [dm-devel] " Chaitanya Kulkarni
2022-01-19 13:27 ` improve the bio allocation interface Jens Axboe
2022-01-19 13:27 ` Jens Axboe
2022-01-19 13:27 ` [dm-devel] " Jens Axboe
2022-01-24 9:10 improve the bio allocation interface v2 Christoph Hellwig
2022-01-24 9:10 ` [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMGffE=+ENBdRfugG4k3yB_ca3rqwnaKFXC4+8=CZ=LGvggA6w@mail.gmail.com' \
--to=jinpu.wang@ionos.com \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=konishi.ryusuke@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=roger.pau@citrix.co \
--cc=snitzer@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.