Re: [PATCH v9 02/25] RDMA/rtrs: public interface header to establish RDMA connections

From: Jinpu Wang <jinpu.wang@cloud.ionos.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jack Wang <jinpuwang@gmail.com>,
	linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Leon Romanovsky <leon@kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Danil Kipnis <danil.kipnis@cloud.ionos.com>,
	Roman Penyaev <rpenyaev@suse.de>,
	Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Subject: Re: [PATCH v9 02/25] RDMA/rtrs: public interface header to establish RDMA connections
Date: Mon, 2 Mar 2020 09:39:56 +0100	[thread overview]
Message-ID: <CAMGffE=X6s0DSKL2c-AmBa6_shvJggNJ0aqCx0C9SbLh-fR3nw@mail.gmail.com> (raw)
In-Reply-To: <e1d8d2ca-78cf-f3ee-2286-1c96e5cfefc7@acm.org>

On Sun, Mar 1, 2020 at 1:31 AM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 2020-02-21 02:46, Jack Wang wrote:
> > +/**
> > + * enum rtrs_clt_con_type() type of ib connection to use with a given
> > + * rtrs_permit
> > + * @USR_CON - use connection reserved vor "service" messages
> > + * @IO_CON - use a connection reserved for IO
> > + */
>
> vor -> for?

right, will fix. German version -.-
>
>
> > +enum rtrs_clt_con_type {
> > +     RTRS_USR_CON,
> > +     RTRS_IO_CON
> > +};
>
> The name "USR" is confusing. How about changing this into "ADMIN"?

Sounds good.
>
>
> > +/*
> > + * Here goes RTRS server API
> > + */
>
> How about splitting this header file into one header file for the client
> API and another header file for the server API? I expect that most users
> will only include one of these header files but not both.
The initial RFC, we did have 2 separate headers, one for the client
and one for the server, due to the fact most users
will only include one of the headers.
https://lore.kernel.org/linux-block/1490352343-20075-1-git-send-email-jinpu.wangl@profitbricks.com/

Later we've made rtrs can be more flexible, in a way user can load
client and server on the same server at the same time, and both
headers are merged to one.

I appreciate your feedback, thanks Bart!

Regards!