From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964986AbbBBNvG (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Feb 2015 08:51:06 -0500
Received: from mail-wi0-f180.google.com ([209.85.212.180]:57569 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964968AbbBBNvD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Feb 2015 08:51:03 -0500
MIME-Version: 1.0
In-Reply-To: <CAMGffEkm+tB6OE72tvcLybE0cFeDu+x9b_irqeF8MGbTvxp+mw@mail.gmail.com>
References: <CAMGffEkm+tB6OE72tvcLybE0cFeDu+x9b_irqeF8MGbTvxp+mw@mail.gmail.com>
From: Jinpu Wang <jinpu.wang@profitbricks.com>
Date: Mon, 2 Feb 2015 14:50:41 +0100
Message-ID: <CAMGffEkoqH9ukAc8JxQWsaAvoNT8JP9RUPCDJeMB4_Do6g7MWg@mail.gmail.com>
Subject: Re: [BUG]rmmod null_blk lead to general protection fault on 3.19.0-rc6
To: Jens Axboe <axboe@fb.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jens,

I found 2 patches commits (74170118b & e09aae7e)from
https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/log/?h=for-linus

After apply those 2 patches, the bug was fixed.
Is it possible to include those 2 patches in official 3.19.0?



On Mon, Feb 2, 2015 at 12:11 PM, Jinpu Wang <jinpu.wang@profitbricks.com> wrote:
> When rmmod null_blk lead to GPF below:
>
> [   29.193712] IPv6: ADDRCONF(NETDEV_CHANGE): ib0: link becomes ready
> [   62.216289] general protection fault: 0000 [#1] SMP DEBUG_PAGEALLOC
> [   62.216586] Dumping ftrace buffer:
> [   62.216660]    (ftrace buffer empty)
> [   62.216730] Modules linked in: ib_ipoib ib_uverbs ib_umad mlx4_ib
> mlx4_en rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr null_blk(-)
> mlx4_core
> [   62.217755] CPU: 1 PID: 3928 Comm: rmmod Not tainted 3.19.0-rc6debug #1
> [   62.217824] Hardware name: To be filled by O.E.M. To be filled by
> O.E.M./M5A97 R2.0, BIOS 2501 04/07/2014
> [   62.217900] task: ffff880233450000 ti: ffff8802289a8000 task.ti:
> ffff8802289a8000
> [   62.217966] RIP: 0010:[<ffffffff8138c293>]  [<ffffffff8138c293>]
> blk_mq_tag_wakeup_all+0x13/0x90
> [   62.218095] RSP: 0018:ffff8802289abe68  EFLAGS: 00010202
> [   62.218170] RAX: ffff8800b534d480 RBX: 0000000000000000 RCX: 0000000000000001
> [   62.218247] RDX: 000000006b6b6b6b RSI: 0000000000000001 RDI: 6b6b6b6b6b6b6b6b
> [   62.218316] RBP: ffff8802289abe88 R08: 0000000000000038 R09: 0000000000000000
> [   62.218969] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
> [   62.219038] R13: ffff880232b20a20 R14: 00007f7cad118090 R15: 0000000000000800
> [   62.219107] FS:  00007f7cac1ac700(0000) GS:ffff880235200000(0000)
> knlGS:0000000000000000
> [   62.219175] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [   62.219288] CR2: 00007f11a69e4095 CR3: 0000000230d54000 CR4: 00000000000407e0
> [   62.219401] Stack:
> [   62.219514]  0000000000000000 ffff880232b20000 ffff880232b20a20
> 00007f7cad118090
> [   62.219912]  ffff8802289abea8 ffffffff8138985e ffff880232b20000
> ffff880232b20000
> [   62.220333]  ffff8802289abec8 ffffffff8137cfd6 ffff880232b20000
> ffff880232b20730
> [   62.220724] Call Trace:
> [   62.220834]  [<ffffffff8138985e>] blk_mq_wake_waiters+0x4e/0x80
> [   62.220952]  [<ffffffff8137cfd6>] blk_set_queue_dying+0x26/0x90
> [   62.221068]  [<ffffffff8137d075>] blk_cleanup_queue+0x35/0x2a0
> [   62.221187]  [<ffffffffa004b7f4>] null_exit+0x57/0x8c [null_blk]
> [   62.221308]  [<ffffffff81112a98>] SyS_delete_module+0x1b8/0x220
> [   62.221456]  [<ffffffff817db3d2>] system_call_fastpath+0x12/0x17
> [   62.221580] Code: 40 08 b8 01 00 00 00 5d c3 66 66 66 66 66 66 2e
> 0f 1f 84 00 00 00 00 00 66 66 66 66 90 55 48 89 e5 41 56 41 55 41 54
> 53 41 89 f4 <44> 8b 6f 28 48 89 fb 41 be 08 00 00 00 49 63 c5 48 c1 e0
> 07 48
> [   62.227747] RIP  [<ffffffff8138c293>] blk_mq_tag_wakeup_all+0x13/0x90
> [   62.227917]  RSP <ffff8802289abe68>
> [   62.228138] ---[ end trace 349782d190908f70 ]---
>
>
> --
> Best Regards,
>
> Jack Wang