All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinpu Wang <jinpu.wang@ionos.com>
To: Gioh Kim <gi-oh.kim@ionos.com>
Cc: linux-rdma@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	Leon Romanovsky <leon@kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Haris Iqbal <haris.iqbal@ionos.com>,
	Gioh Kim <gi-oh.kim@cloud.ionos.com>
Subject: Re: [PATCH 1/4] RDMA/rtrs-clt: Add a minimum latency multipath policy
Date: Wed, 7 Apr 2021 11:23:39 +0200	[thread overview]
Message-ID: <CAMGffEn47V33+EwLXyDiKcZ6zMvD-QufAAfPcVgHNGveKrkR+A@mail.gmail.com> (raw)
In-Reply-To: <20210406120553.197848-2-gi-oh.kim@ionos.com>

On Tue, Apr 6, 2021 at 2:06 PM Gioh Kim <gi-oh.kim@ionos.com> wrote:
>
> From: Gioh Kim <gi-oh.kim@cloud.ionos.com>
>
> This patch adds new multipath policy: min-latency.
> Client checks the latency of each path when it sends the heart-beat.
> And it sends IO to the path with the minimum latency.
>
> Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 18 +++++--
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c       | 57 +++++++++++++++++++-
>  drivers/infiniband/ulp/rtrs/rtrs-clt.h       |  1 +
>  drivers/infiniband/ulp/rtrs/rtrs-pri.h       |  2 +
>  drivers/infiniband/ulp/rtrs/rtrs.c           |  3 ++
>  5 files changed, 77 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> index c502dcbae9bb..bc46b7a99ba0 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> @@ -101,6 +101,8 @@ static ssize_t mpath_policy_show(struct device *dev,
>         case MP_POLICY_MIN_INFLIGHT:
>                 return sysfs_emit(page, "min-inflight (MI: %d)\n",
>                                   clt->mp_policy);
> +       case MP_POLICY_MIN_LATENCY:
> +               return sprintf(page, "min-latency (ML: %d)\n", clt->mp_policy);
sysfs_emit should be used here, Gioh please fix it.

Thanks

  reply	other threads:[~2021-04-07  9:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 12:05 [PATCH 0/4] New multipath policy for RTRS client Gioh Kim
2021-04-06 12:05 ` [PATCH 1/4] RDMA/rtrs-clt: Add a minimum latency multipath policy Gioh Kim
2021-04-07  9:23   ` Jinpu Wang [this message]
2021-04-07 10:23     ` Gioh Kim
2021-04-06 12:05 ` [PATCH 2/4] RDMA/rtrs-clt: new sysfs attribute to print the latency of each path Gioh Kim
2021-04-07  9:21   ` Jinpu Wang
2021-04-06 12:05 ` [PATCH 3/4] RDMA/rtrs-clt: Check state of the rtrs_clt_sess before reading its stats Gioh Kim
2021-04-06 12:05 ` [PATCH 4/4] Documentation/ABI/rtrs-clt: Add descriptions for min-latency policy Gioh Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMGffEn47V33+EwLXyDiKcZ6zMvD-QufAAfPcVgHNGveKrkR+A@mail.gmail.com \
    --to=jinpu.wang@ionos.com \
    --cc=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=gi-oh.kim@cloud.ionos.com \
    --cc=gi-oh.kim@ionos.com \
    --cc=haris.iqbal@ionos.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.