From: Gwendal Grignou <gwendal@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Benson Leung <bleung@chromium.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
kernel@collabora.com, Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC
Date: Wed, 21 Feb 2018 15:52:31 -0800 [thread overview]
Message-ID: <CAMHSBOUTrkyANDovR1eV4c80ci2hf3tm+0rPTijojHuBm-gH2g@mail.gmail.com> (raw)
In-Reply-To: <20180219224602.22582-1-enric.balletbo@collabora.com>
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> From: Vincent Palatin <vpalatin@chromium.org>
>
> If we cannot communicate with the EC chip to detect the protocol version
> and its features, it's very likely useless to continue. Else we will
> commit all kind of uninformed mistakes (using the wrong protocol, the
> wrong buffer size, mixing the EC with other chips).
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> Acked-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> drivers/mfd/cros_ec.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index d61024141e2b..74780f2964a1 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>
> mutex_init(&ec_dev->lock);
>
> - cros_ec_query_all(ec_dev);
> + err = cros_ec_query_all(ec_dev);
> + if (err) {
> + dev_err(dev, "Cannot identify the EC: error %d\n", err);
> + return err;
> + }
>
> if (ec_dev->irq) {
> err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
> --
> 2.16.1
>
next prev parent reply other threads:[~2018-02-21 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 22:46 [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC Enric Balletbo i Serra
2018-02-21 23:52 ` Gwendal Grignou [this message]
2018-03-07 15:12 ` Lee Jones
2018-03-07 15:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMHSBOUTrkyANDovR1eV4c80ci2hf3tm+0rPTijojHuBm-gH2g@mail.gmail.com \
--to=gwendal@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.