All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 2/2] builtin: make builtins more builtin
Date: Tue, 7 Nov 2017 09:22:08 +0100	[thread overview]
Message-ID: <CAMHZB6FCx_gpEJDj3Q-kdTG8L89PsOxjYB+S7FaBQ_y9Ek41=A@mail.gmail.com> (raw)
In-Reply-To: <CANeU7Qn+gSxPy+RMGGTJ4rmhwZyMLkzpGQt2-G+jYNtgRCd4qw@mail.gmail.com>

On Tue, Nov 7, 2017 at 2:38 AM, Christopher Li <sparse@chrisli.org> wrote:
>
> Hi Luc,
>
> I like the direction this patch is heading.
>
> I think you can change the  declare_builtin to be driven by table (C
> structure array).
> Rather than explicit function call. That will both save code do you
> don't need to deal with
> the variance part.

Using a table is certainly the usual way of doing this sort of things
but here, given that we can have between 0 & 6 arguments, it's
much less useful.
But I'm ready to change my mind if someone can give me numbers
showing a significant gain in speed or size if a table is used.

Regards,
-- Luc

      reply	other threads:[~2017-11-07  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 20:16 [PATCH 0/2] make builtins more built-in Luc Van Oostenryck
2017-11-06 20:16 ` [PATCH 1/2] builtin: add ctype for const {void,char} * Luc Van Oostenryck
2017-11-06 20:16 ` [PATCH 2/2] builtin: make builtins more builtin Luc Van Oostenryck
2017-11-07  1:38   ` Christopher Li
2017-11-07  8:22     ` Luc Van Oostenryck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMHZB6FCx_gpEJDj3Q-kdTG8L89PsOxjYB+S7FaBQ_y9Ek41=A@mail.gmail.com' \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.