From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F960C48BE5 for ; Mon, 21 Jun 2021 08:02:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EB1D6102A for ; Mon, 21 Jun 2021 08:02:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB1D6102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51B4C6B0070; Mon, 21 Jun 2021 04:02:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CB766B0072; Mon, 21 Jun 2021 04:02:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344536B0074; Mon, 21 Jun 2021 04:02:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 01A046B0070 for ; Mon, 21 Jun 2021 04:01:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 804D6180AD81F for ; Mon, 21 Jun 2021 08:01:59 +0000 (UTC) X-FDA: 78276987558.10.0AF5EFE Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 3E37DC0633E6 for ; Mon, 21 Jun 2021 08:00:59 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id d13so23769312ljg.12 for ; Mon, 21 Jun 2021 01:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yK9BcEw+ihRkglw+y3qeUXuf2P+oHtnf4faYNKKBTB0=; b=K505KvFXjZNa+odBPr9WV3/bSNHmsxJmi49MIiv7z+4FRLep/B0i9xcUtyiu2dtQLW lI+dC5hTXjStCHo0wXXyPuMlTFBu3Rv9PNiZjccMymf5K/ISfDldPveiXZgonLcXdR1g Ot0T98F3epochrHAVOtvwjkQFnnQXto+zGn3jR8A2Am8I595QSdBDQKXVAH4johoMxx6 +ZT544pK3ybGk2jtiMszvGo7rygqtpOiq+RkmQCkX7UBGTCiIE9hg3ITwjPq1Lj07RFv zMFC6cpkKzgCN5rMafhIdk93uYMmG37DooDhR29BaoNcHJpEo9V6xOSOiR3Z2O3WmR00 nkZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yK9BcEw+ihRkglw+y3qeUXuf2P+oHtnf4faYNKKBTB0=; b=CGsFbW/eZuJhrG/nQF53x+dPaiI8VM9D5JI70UPSbugSclRORX2cuznoVl+ZQr3hBW 6FhyuJ93L6p1K5atDTBUNSz+9jTpX75qwyvumRZsv2C6WJ1RKcL8a1lIkshK/PonmCgz EHfpu6tUcWAC9+TdAHD+CBw+wtBr17SVgiLghMEKAbYLI2iOeuz+D2RYQCUnc7/n4VU3 DPFEjGI5jS7teDAka9c/W6P6UE8EeA6w2yrxv2p46p7w0j93KsbTkCBBjaamJ5PxmsBp pIs3qsHSfdmn+F68A/dZuoF3ZPNRwJUjDhaDUnDoEBDjpapCCx4uvDKXHtmqBDbm51Fr 4vUA== X-Gm-Message-State: AOAM531eu1OIDF1g4FgfwifK2/0fQhW/RIp0Ci9uwdU+5crCsCebyeyw CUEKqX0HNHLtj877VBN1KaGQ8g5PfxBYpddLyrA= X-Google-Smtp-Source: ABdhPJwXw4EIEfY7ZxcNqYmAiOuNFuUMK6YbQlXvJ/HRgWQEYbEjKtDvwpnXRyTIxsp1X6RkMjE77+7xtkXiBwfAGTE= X-Received: by 2002:a2e:9788:: with SMTP id y8mr20114545lji.100.1624262456826; Mon, 21 Jun 2021 01:00:56 -0700 (PDT) MIME-Version: 1.0 References: <20210619093151.1492174-1-linmiaohe@huawei.com> In-Reply-To: <20210619093151.1492174-1-linmiaohe@huawei.com> From: Vitaly Wool Date: Mon, 21 Jun 2021 10:00:45 +0200 Message-ID: Subject: Re: [PATCH 0/6] Cleanup and fixup for z3fold To: Miaohe Lin Cc: Andrew Morton , LKML , Linux-MM Content-Type: multipart/alternative; boundary="000000000000c2dc8d05c54212ac" Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=K505KvFX; spf=pass (imf03.hostedemail.com: domain of vitalywool@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=vitalywool@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: kbsoau6qfmh7u3fyzpszak67mjo3skkr X-Rspamd-Queue-Id: 3E37DC0633E6 X-Rspamd-Server: rspam06 X-HE-Tag: 1624262459-458121 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000c2dc8d05c54212ac Content-Type: text/plain; charset="UTF-8" On Sat, Jun 19, 2021 at 11:32 AM Miaohe Lin wrote: > Hi all, > This series contains cleanups to remove unused function, redefine macro > to improve readability and so on. Also this fixes several bugs in z3fold, > such as memory leak in z3fold_destroy_pool(). More details can be found > in the respective changelogs. Thanks! > > Miaohe Lin (6): > mm/z3fold: define macro NCHUNKS as TOTAL_CHUNKS - ZHDR_CHUNKS > mm/z3fold: avoid possible underflow in z3fold_alloc() > mm/z3fold: remove magic number in z3fold_create_pool() > mm/z3fold: remove unused function handle_to_z3fold_header() > mm/z3fold: fix potential memory leak in z3fold_destroy_pool() > mm/z3fold: use release_z3fold_page_locked() to release locked z3fold > page > > mm/z3fold.c | 37 ++++++++++++++----------------------- > 1 file changed, 14 insertions(+), 23 deletions(-) > > Thanks for looking into this! Reviewed-by: Vitaly Wool --000000000000c2dc8d05c54212ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Jun 19, 2021 at 11:32 AM Miao= he Lin <linmia= ohe@huawei.com> wrote:
Hi all,
This series contains cleanups to remove unused function, redefine macro
to improve readability and so on. Also this fixes several bugs in z3fold, such as memory leak in z3fold_destroy_pool(). More details can be found
in the respective changelogs. Thanks!

Miaohe Lin (6):
=C2=A0 mm/z3fold: define macro NCHUNKS as TOTAL_CHUNKS - ZHDR_CHUNKS
=C2=A0 mm/z3fold: avoid possible underflow in z3fold_alloc()
=C2=A0 mm/z3fold: remove magic number in z3fold_create_pool()
=C2=A0 mm/z3fold: remove unused function handle_to_z3fold_header()
=C2=A0 mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
=C2=A0 mm/z3fold: use release_z3fold_page_locked() to release locked z3fold=
=C2=A0 =C2=A0 page

=C2=A0mm/z3fold.c | 37 ++++++++++++++-----------------------
=C2=A01 file changed, 14 insertions(+), 23 deletions(-)

Thanks for looking into this!

Rev= iewed-by: Vitaly Wool <vital= y.wool@konsulko.com>
--000000000000c2dc8d05c54212ac--