All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Trevor Woerner <twoerner@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/2] sysvinit/rc: show text progress
Date: Wed, 23 Dec 2020 15:27:50 -0800	[thread overview]
Message-ID: <CAMKF1so1E7Dw8Uwy8epT0UanOv0QcdcPqzobSV+tOMURHPK5uQ@mail.gmail.com> (raw)
In-Reply-To: <20201222070029.40230-1-twoerner@gmail.com>

On Mon, Dec 21, 2020 at 11:00 PM Trevor Woerner <twoerner@gmail.com> wrote:
>
> In addition to the progress bar, show which startup routine is running by
> using the "MSG" facility of psplash.
>

This is ok but lets make it optional and controlled via some knob. End
products usually want clean graphics

> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  meta/recipes-core/sysvinit/sysvinit/rc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/sysvinit/sysvinit/rc b/meta/recipes-core/sysvinit/sysvinit/rc
> index d0d3149821..6995930ee9 100755
> --- a/meta/recipes-core/sysvinit/sysvinit/rc
> +++ b/meta/recipes-core/sysvinit/sysvinit/rc
> @@ -27,6 +27,7 @@ startup_progress() {
>      fi
>      #echo "PROGRESS is $progress $runlevel $first_step + ($step of $num_steps) $step_change $progress_size"
>      if type psplash-write >/dev/null 2>&1; then
> +        PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "MSG $(basename $1 .sh | cut -c 4-)" || true
>          PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "PROGRESS $progress" || true
>      fi
>  }
> @@ -53,7 +54,7 @@ startup() {
>                 "$@"
>                 ;;
>    esac
> -  startup_progress
> +  startup_progress "$1"
>  }
>
>    # Ignore CTRL-C only in this shell, so we can interrupt subprocesses.
> --
> 2.30.0.rc0
>
>
> 
>

  reply	other threads:[~2020-12-23 23:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22  7:00 [PATCH 1/2] sysvinit/rc: show text progress Trevor Woerner
2020-12-23 23:27 ` Khem Raj [this message]
2020-12-24  2:42   ` [OE-core] " Trevor Woerner
2020-12-24 13:38   ` Trevor Woerner
2020-12-24 19:39     ` Khem Raj
     [not found] <1652F7C39C28176B.11411@lists.openembedded.org>
2020-12-22  7:04 ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1so1E7Dw8Uwy8epT0UanOv0QcdcPqzobSV+tOMURHPK5uQ@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.