All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] arch-armv7a.inc: default to Thumb2 instruction set for armv7a and above
Date: Fri, 18 May 2018 16:40:19 -0700	[thread overview]
Message-ID: <CAMKF1so7fh4Vc9-KkeQpjArm+Wzj4g=OOzsD3qChiWnV_q0Wuw@mail.gmail.com> (raw)
In-Reply-To: <1526683840-20390-1-git-send-email-armccurdy@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

On Fri, May 18, 2018 at 3:50 PM Andre McCurdy <armccurdy@gmail.com> wrote:

> Although there may still be specific cases which can benefit from the
> ARM instruction set, the Thumb2 instruction set is generally a better
> default for armv7a class CPUs. Distros such as Debian and Fedora have
> been targeting Thumb2 by default for some time.
>
> Note that setting ARM_INSTRUCTION_SET has no effect unless
> TUNE_FEATURES contains "thumb" (which is controlled by the "t" suffix
> in DEFAULTTUNE, e.g. armv7vehf-neon -vs- armv7vethf-neon, etc) so out
> of tree machine configs may need to update their DEFAULTTUNE to take
> advantage of this change.



I think this is a good change and we shoudl take it in thumb2 is default
ISA
for other major distros as well

Oe based distros who ship feeds might be affected

>
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/conf/machine/include/arm/arch-armv7a.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
> b/meta/conf/machine/include/arm/arch-armv7a.inc
> index bad1c27..a2663d8 100644
> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> @@ -1,4 +1,5 @@
>  DEFAULTTUNE ?= "armv7athf"
> +ARM_INSTRUCTION_SET ?= "thumb"
>
>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2538 bytes --]

  reply	other threads:[~2018-05-18 23:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 22:50 [PATCH] arch-armv7a.inc: default to Thumb2 instruction set for armv7a and above Andre McCurdy
2018-05-18 23:40 ` Khem Raj [this message]
2018-05-19  5:42   ` Martin Jansa
2018-05-19  6:48     ` Andre McCurdy
2018-05-19  7:11       ` Martin Jansa
2018-05-19  7:31         ` Andre McCurdy
2018-05-19  7:41           ` Martin Jansa
2018-05-21 17:15             ` Andre McCurdy
2018-05-22  9:58 Jef.Driesen
2018-05-22 10:33 ` Khem Raj
2018-06-04 21:33   ` Andre McCurdy
2018-06-26 19:52     ` Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1so7fh4Vc9-KkeQpjArm+Wzj4g=OOzsD3qChiWnV_q0Wuw@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.