From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id B52D3E00E85; Thu, 10 May 2018 17:56:06 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (raj.khem[at]gmail.com) * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [74.125.83.50 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 34AB6E009CF for ; Thu, 10 May 2018 17:56:05 -0700 (PDT) Received: by mail-pg0-f50.google.com with SMTP id i194-v6so1692834pgd.0 for ; Thu, 10 May 2018 17:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o1MVnUvflWQrl5mTOJEMbU4xJ+wEYCFu0C3ONjBG5/c=; b=utHFvT/OYBMggP7A2yzkvXHD5ZbApcfb+z57G3Spfu2ZcUQCDX2iVSG96CJ9ScfJeU fwbLOc2UMmV8a2tzZCIB7d8eANJEQj7e8Z6tVes36DMta3/pBXeCF5j+d4ZpFBZNjyEJ TYNf8tuTuGap0llxH5t8giCE6SWvxcdAZId5Ns2dxg2j0JlvDepMRRx6OtfuZYASxN7M Z0p9vrY+NcrlMM0YqE3WgRFr/HhKVOpdVYXsXjhxjQJ2OvMg9M+Bw6o1YlEXOSjI2PD/ s4wtRqtKM1OfInn1isTFFxeCp/mO5iMq1xMzPNewJj/XS5jb5MZadGDwFallkBAKacaF j1Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o1MVnUvflWQrl5mTOJEMbU4xJ+wEYCFu0C3ONjBG5/c=; b=mOJskDAUNar8SZ0z6rmcFWMJpIh2+t57vRuAgtXu3Upd5c3YRRvoFrVRh5SAT6yjDH 2y8BTwANkOPERZkFEnKQWCyHcvMox1QUGoQm6nUMngWpY+7OrdYljafpYHdy7t2MBsWz XBSCBjk4TbxBYlr/eFqrCcKfN+1Gxxg9YcJQxHjkR20VkIKUV2DZod9MOy8k3JokbZzm oq+dkoyeRtQmmcqYB7a75HCQG+KLpVQGraROP3GKDnDFyFS2Er/DtEAggYtMTfUyWG1F 2trY3NsKGEdU5Li1vUGPSC38Pi2hVngJGKesKHduNmutL56WBuFoXDwEK0Geq5PkeqYi tWcg== X-Gm-Message-State: ALKqPwfOOJ9ii10sibHW6vHPhPoe7NleT/y94PeTHt8ThOgQDonv/0S4 /ZYXEgKllDzpG73OmL53sW7TGJnCXn5ORNUqwT0= X-Google-Smtp-Source: AB8JxZpdfqFzypmV/yt2MbKSmVZ3aE6qT3OzgIFiXlOxNxJhOAODvs141Ca/8rSvdmoXnImsqRXDF8N96nns7wuhQ4A= X-Received: by 2002:a62:7f91:: with SMTP id a139-v6mr3359839pfd.25.1526000165357; Thu, 10 May 2018 17:56:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.139.145 with HTTP; Thu, 10 May 2018 17:55:34 -0700 (PDT) In-Reply-To: References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> From: Khem Raj Date: Thu, 10 May 2018 17:55:34 -0700 Message-ID: To: Andre McCurdy Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [OE-core] [RFT] GCC 8.1 X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 00:56:06 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 4:11 PM, Andre McCurdy wrote: > On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >> On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >>> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >>> > see >>> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >>> >>> Removing -fno-omit-frame-pointer isn't the same as adding >>> -fomit-frame-pointer. Frame pointers may get enabled depending on the >>> optimisation level etc (ie not only by -fno-omit-frame-pointer). >> >> Should I send v2 adding -fomit-frame-pointer instead of removing >> -fno-omit-frame-pointer? >> >> The v1 fixes the issue for me with default config + DEBUG_BUILD. > > The v1 patch isn't wrong, it's just incomplete (the problem could come > back if someone changes optimisation level or switches gcc to clang, > etc). > > My choice would be a v2 patch which adds -fomit-frame-pointer to > CFLAGS unconditionally for all ARM builds when Thumb is enabled. That > should fix the problem for all optimisation levels etc and avoids > building the main strace binary differently depending on whether or > not ptest is enabled. explicitly adding this option is a poor choice especially for debug builds where we should let the -On level decide and not explicitly ask for either enable/disable frame-pointers that will also make it compiler proof. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41]) by mail.openembedded.org (Postfix) with ESMTP id 8290B7540D; Fri, 11 May 2018 00:56:04 +0000 (UTC) Received: by mail-pg0-f41.google.com with SMTP id p9-v6so1685665pgc.9; Thu, 10 May 2018 17:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o1MVnUvflWQrl5mTOJEMbU4xJ+wEYCFu0C3ONjBG5/c=; b=utHFvT/OYBMggP7A2yzkvXHD5ZbApcfb+z57G3Spfu2ZcUQCDX2iVSG96CJ9ScfJeU fwbLOc2UMmV8a2tzZCIB7d8eANJEQj7e8Z6tVes36DMta3/pBXeCF5j+d4ZpFBZNjyEJ TYNf8tuTuGap0llxH5t8giCE6SWvxcdAZId5Ns2dxg2j0JlvDepMRRx6OtfuZYASxN7M Z0p9vrY+NcrlMM0YqE3WgRFr/HhKVOpdVYXsXjhxjQJ2OvMg9M+Bw6o1YlEXOSjI2PD/ s4wtRqtKM1OfInn1isTFFxeCp/mO5iMq1xMzPNewJj/XS5jb5MZadGDwFallkBAKacaF j1Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o1MVnUvflWQrl5mTOJEMbU4xJ+wEYCFu0C3ONjBG5/c=; b=AUa1kaYVLHRjrhQ/UWXts91eCmq1J00LudVzWqYM2fL0xnOFH9xOtQASEHDn7l90uv aQbzI7PPdRR8x5OiryNu/EK/krUjASd/HW+wv79mPwWrchAOkkwxkuzPzixjCEBslBiK sV/aFHsD/9JtPKuz6Ul7h5dx6x8s6qIXIOc7Mcbn17m3IsH/VdL8e1LKaLr+0Pkpj/kp rgBaxAjHkuXlfe7gmy4gWTvS8/fh+3P0zuSuRsEM3wp25+UEtpKDkFdkpRCIU05YayN4 UlxOMJo7XaFqpgJA+QDD2Coai4NEKCCZ9uw+8bUqt+rCWzGZDYFQ2PJ18I3ZNwf9Tqsc /Wig== X-Gm-Message-State: ALKqPwfY6/3Lf7f4s8Q2slF8u93SRVImNZsRM7j5H5oCrONkOogWdzl0 8Vq622Gw7GL1smtvsPa2mTkz2lpOIhK61YtgwRw= X-Google-Smtp-Source: AB8JxZpdfqFzypmV/yt2MbKSmVZ3aE6qT3OzgIFiXlOxNxJhOAODvs141Ca/8rSvdmoXnImsqRXDF8N96nns7wuhQ4A= X-Received: by 2002:a62:7f91:: with SMTP id a139-v6mr3359839pfd.25.1526000165357; Thu, 10 May 2018 17:56:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.139.145 with HTTP; Thu, 10 May 2018 17:55:34 -0700 (PDT) In-Reply-To: References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> From: Khem Raj Date: Thu, 10 May 2018 17:55:34 -0700 Message-ID: To: Andre McCurdy Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [RFT] GCC 8.1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 00:56:04 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 4:11 PM, Andre McCurdy wrote: > On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >> On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >>> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >>> > see >>> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >>> >>> Removing -fno-omit-frame-pointer isn't the same as adding >>> -fomit-frame-pointer. Frame pointers may get enabled depending on the >>> optimisation level etc (ie not only by -fno-omit-frame-pointer). >> >> Should I send v2 adding -fomit-frame-pointer instead of removing >> -fno-omit-frame-pointer? >> >> The v1 fixes the issue for me with default config + DEBUG_BUILD. > > The v1 patch isn't wrong, it's just incomplete (the problem could come > back if someone changes optimisation level or switches gcc to clang, > etc). > > My choice would be a v2 patch which adds -fomit-frame-pointer to > CFLAGS unconditionally for all ARM builds when Thumb is enabled. That > should fix the problem for all optimisation levels etc and avoids > building the main strace binary differently depending on whether or > not ptest is enabled. explicitly adding this option is a poor choice especially for debug builds where we should let the -On level decide and not explicitly ask for either enable/disable frame-pointers that will also make it compiler proof.