* [PATCH] util-linux: Use PCRE for hardlink
@ 2019-12-04 19:32 Khem Raj
2019-12-04 20:00 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-12-04 19:32 UTC (permalink / raw)
To: openembedded-core
Use PCRE, this enables using posix extended Regexps on cmdline
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-core/util-linux/util-linux.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 1fa82363b1..8f867aa9b4 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
#gtk-doc is not enabled as it requires xmlto which requires util-linux
inherit autotools gettext manpages pkgconfig systemd update-alternatives python3-dir bash-completion ptest
-DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
+DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.xz \
--
2.24.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 19:32 [PATCH] util-linux: Use PCRE for hardlink Khem Raj
@ 2019-12-04 20:00 ` Richard Purdie
2019-12-04 20:12 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2019-12-04 20:00 UTC (permalink / raw)
To: Khem Raj, openembedded-core
On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> Use PCRE, this enables using posix extended Regexps on cmdline
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-core/util-linux/util-linux.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux.inc
> b/meta/recipes-core/util-linux/util-linux.inc
> index 1fa82363b1..8f867aa9b4 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
>
> #gtk-doc is not enabled as it requires xmlto which requires util-
> linux
> inherit autotools gettext manpages pkgconfig systemd update-
> alternatives python3-dir bash-completion ptest
> -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
>
> MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> SRC_URI =
> "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.x
> z \
Given it works today without that, shouldn't it be a PACKAGECONFIG?
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 20:00 ` Richard Purdie
@ 2019-12-04 20:12 ` Khem Raj
2019-12-04 20:18 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-12-04 20:12 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > Use PCRE, this enables using posix extended Regexps on cmdline
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > b/meta/recipes-core/util-linux/util-linux.inc
> > index 1fa82363b1..8f867aa9b4 100644
> > --- a/meta/recipes-core/util-linux/util-linux.inc
> > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> >
> > #gtk-doc is not enabled as it requires xmlto which requires util-
> > linux
> > inherit autotools gettext manpages pkgconfig systemd update-
> > alternatives python3-dir bash-completion ptest
> > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> >
> > MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > SRC_URI =
> > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.x
> > z \
>
> Given it works today without that, shouldn't it be a PACKAGECONFIG?
its default with other main linux distros. I thought since what we
were doing was not
default, I did not see a need for packageconfig. I can certain do a v2
with packageconfig
and enabling it by default, is that better ?
>
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 20:12 ` Khem Raj
@ 2019-12-04 20:18 ` Richard Purdie
2019-12-04 20:21 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2019-12-04 20:18 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > > Use PCRE, this enables using posix extended Regexps on cmdline
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > > b/meta/recipes-core/util-linux/util-linux.inc
> > > index 1fa82363b1..8f867aa9b4 100644
> > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> > >
> > > #gtk-doc is not enabled as it requires xmlto which requires
> > > util-
> > > linux
> > > inherit autotools gettext manpages pkgconfig systemd update-
> > > alternatives python3-dir bash-completion ptest
> > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> > >
> > > MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > > SRC_URI =
> > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.t
> > > ar.x
> > > z \
> >
> > Given it works today without that, shouldn't it be a PACKAGECONFIG?
>
> its default with other main linux distros. I thought since what we
> were doing was not
> default, I did not see a need for packageconfig. I can certain do a
> v2 with packageconfig and enabling it by default, is that better ?
We're embedded so we're supposed to expose this kind of config and tend
to the more minimal ;-)
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 20:18 ` Richard Purdie
@ 2019-12-04 20:21 ` Khem Raj
2019-12-04 20:22 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-12-04 20:21 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > > > Use PCRE, this enables using posix extended Regexps on cmdline
> > > >
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > > > b/meta/recipes-core/util-linux/util-linux.inc
> > > > index 1fa82363b1..8f867aa9b4 100644
> > > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> > > >
> > > > #gtk-doc is not enabled as it requires xmlto which requires
> > > > util-
> > > > linux
> > > > inherit autotools gettext manpages pkgconfig systemd update-
> > > > alternatives python3-dir bash-completion ptest
> > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> > > >
> > > > MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > > > SRC_URI =
> > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.t
> > > > ar.x
> > > > z \
> > >
> > > Given it works today without that, shouldn't it be a PACKAGECONFIG?
> >
> > its default with other main linux distros. I thought since what we
> > were doing was not
> > default, I did not see a need for packageconfig. I can certain do a
> > v2 with packageconfig and enabling it by default, is that better ?
>
> We're embedded so we're supposed to expose this kind of config and tend
> to the more minimal ;-)
I was more looking into native and nativesdk variants where this could
be more important.
>
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 20:21 ` Khem Raj
@ 2019-12-04 20:22 ` Richard Purdie
2019-12-04 20:25 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2019-12-04 20:22 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Wed, 2019-12-04 at 12:21 -0800, Khem Raj wrote:
> On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> > > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
> > > <richard.purdie@linuxfoundation.org> wrote:
> > > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > > > > Use PCRE, this enables using posix extended Regexps on
> > > > > cmdline
> > > > >
> > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > > ---
> > > > > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > > > > b/meta/recipes-core/util-linux/util-linux.inc
> > > > > index 1fa82363b1..8f867aa9b4 100644
> > > > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> > > > >
> > > > > #gtk-doc is not enabled as it requires xmlto which requires
> > > > > util-
> > > > > linux
> > > > > inherit autotools gettext manpages pkgconfig systemd update-
> > > > > alternatives python3-dir bash-completion ptest
> > > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> > > > >
> > > > > MAJOR_VERSION =
> > > > > "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > > > > SRC_URI =
> > > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${B
> > > > > P}.t
> > > > > ar.x
> > > > > z \
> > > >
> > > > Given it works today without that, shouldn't it be a
> > > > PACKAGECONFIG?
> > >
> > > its default with other main linux distros. I thought since what
> > > we
> > > were doing was not
> > > default, I did not see a need for packageconfig. I can certain do
> > > a
> > > v2 with packageconfig and enabling it by default, is that better
> > > ?
> >
> > We're embedded so we're supposed to expose this kind of config and
> > tend
> > to the more minimal ;-)
>
> I was more looking into native and nativesdk variants where this
> could be more important.
Sure, but your patch changes the target version too...
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] util-linux: Use PCRE for hardlink
2019-12-04 20:22 ` Richard Purdie
@ 2019-12-04 20:25 ` Khem Raj
0 siblings, 0 replies; 7+ messages in thread
From: Khem Raj @ 2019-12-04 20:25 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Wed, Dec 4, 2019 at 12:22 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2019-12-04 at 12:21 -0800, Khem Raj wrote:
> > On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> > > > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
> > > > <richard.purdie@linuxfoundation.org> wrote:
> > > > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> > > > > > Use PCRE, this enables using posix extended Regexps on
> > > > > > cmdline
> > > > > >
> > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > > > ---
> > > > > > meta/recipes-core/util-linux/util-linux.inc | 2 +-
> > > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > > > > > b/meta/recipes-core/util-linux/util-linux.inc
> > > > > > index 1fa82363b1..8f867aa9b4 100644
> > > > > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > > > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "
> > > > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
> > > > > >
> > > > > > #gtk-doc is not enabled as it requires xmlto which requires
> > > > > > util-
> > > > > > linux
> > > > > > inherit autotools gettext manpages pkgconfig systemd update-
> > > > > > alternatives python3-dir bash-completion ptest
> > > > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
> > > > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
> > > > > >
> > > > > > MAJOR_VERSION =
> > > > > > "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
> > > > > > SRC_URI =
> > > > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${B
> > > > > > P}.t
> > > > > > ar.x
> > > > > > z \
> > > > >
> > > > > Given it works today without that, shouldn't it be a
> > > > > PACKAGECONFIG?
> > > >
> > > > its default with other main linux distros. I thought since what
> > > > we
> > > > were doing was not
> > > > default, I did not see a need for packageconfig. I can certain do
> > > > a
> > > > v2 with packageconfig and enabling it by default, is that better
> > > > ?
> > >
> > > We're embedded so we're supposed to expose this kind of config and
> > > tend
> > > to the more minimal ;-)
> >
> > I was more looking into native and nativesdk variants where this
> > could be more important.
>
> Sure, but your patch changes the target version too...
>
sent a v2
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-04 20:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 19:32 [PATCH] util-linux: Use PCRE for hardlink Khem Raj
2019-12-04 20:00 ` Richard Purdie
2019-12-04 20:12 ` Khem Raj
2019-12-04 20:18 ` Richard Purdie
2019-12-04 20:21 ` Khem Raj
2019-12-04 20:22 ` Richard Purdie
2019-12-04 20:25 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.