All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Mikko Rapeli <mikko.rapeli@bmw.de>
Cc: Anuj Mittal <anuj.mittal@intel.com>,
	 Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] security_flags.inc: Use -O with -D_FORTIFY_SOURCE
Date: Wed, 10 Feb 2021 10:02:54 -0800	[thread overview]
Message-ID: <CAMKF1soExCkLsKd9A3Z_E0y9BqZpPE+f_t57B_xivaZmAhm9hA@mail.gmail.com> (raw)
In-Reply-To: <YCOd2Ru/zB/fZedT@korppu>

On Wed, Feb 10, 2021 at 12:48 AM Mikko Rapeli <mikko.rapeli@bmw.de> wrote:
>
> Hi,
>
> On Tue, Feb 09, 2021 at 11:37:39PM -0800, Khem Raj wrote:
> > In this case -O  will take effect sadly. and it seems to be that
> > autconf munges the compiler cmdline
> > while generating CFLAGS in generated Makefiles and appends the value
> > of -On coming from CC
> > variable last.
> >
> > I think right solution would be to add same -O<level> as specified in
> > SELECTED_OPTIMIZATION so it remains
> > in sync always, I have sent a patch to ml. Could you test it out and
> > let me know if it works for you as well.
>
> Or let it go? A lot of recipes amend their own optimization flags and override
> distro wide optimization and other compiler flags. I once fixes all recipes
> in a project which were not obeying Os until buildhistory showed change in binary
> sizes... that was a lot of work for a PoC..
>

I think we need to solve this. I have seen many cases where configure
tests silently fails due to these warnings and we
don't necessarily notice it because configure just disables the failed
part and the package might not fail to build

We still are fine if a package is overriding these flags but we want
to be consistent about what we pass.

> Cheers,
>
> -Mikko
> 
>

      parent reply	other threads:[~2021-02-10 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06  6:31 [PATCH] security_flags.inc: Use -O with -D_FORTIFY_SOURCE Khem Raj
2021-02-10  4:47 ` [OE-core] " Anuj Mittal
2021-02-10  7:37   ` Khem Raj
2021-02-10  8:48     ` Mikko Rapeli
2021-02-10  9:56       ` Andre McCurdy
2021-02-10 18:09         ` Khem Raj
2021-02-10 18:02       ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1soExCkLsKd9A3Z_E0y9BqZpPE+f_t57B_xivaZmAhm9hA@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=anuj.mittal@intel.com \
    --cc=mikko.rapeli@bmw.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.