From: Khem Raj <raj.khem@gmail.com>
To: Dengke Du <dengke.du@windriver.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH] snappy: add -fPIC flags
Date: Tue, 28 Aug 2018 09:45:32 -0700 [thread overview]
Message-ID: <CAMKF1soJ5kaqW+XKAgCPtNwZE08yuzz5TCOKt7eVX=TitSYBDA@mail.gmail.com> (raw)
In-Reply-To: <1535441994-32199-1-git-send-email-dengke.du@windriver.com>
On Tue, Aug 28, 2018 at 12:29 AM Dengke Du <dengke.du@windriver.com> wrote:
>
> Let the libsnappy.a be position independent code, so other packages can use it
> to make shared PIC library, such as ceph.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
> meta-oe/recipes-extended/snappy/snappy_1.1.7.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-extended/snappy/snappy_1.1.7.bb b/meta-oe/recipes-extended/snappy/snappy_1.1.7.bb
> index 6f1978a..70223be 100644
> --- a/meta-oe/recipes-extended/snappy/snappy_1.1.7.bb
> +++ b/meta-oe/recipes-extended/snappy/snappy_1.1.7.bb
> @@ -19,3 +19,4 @@ inherit cmake pkgconfig
>
> PACKAGECONFIG ??= ""
> PACKAGECONFIG[lzo] = "-DHAVE_LIBLZO2=1,-DHAVE_LIBLZO2=0,lzo,"
> +TARGET_CFLAGS += "-fPIC"
perhaps adding the -fPIC flag to CPPFLAGS is better since adding to
it would mean it applies to C and C++ compilers equally
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2018-08-28 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 7:39 [meta-oe][PATCH] snappy: add -fPIC flags Dengke Du
2018-08-28 16:45 ` Khem Raj [this message]
2018-08-29 2:10 ` Dengke Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1soJ5kaqW+XKAgCPtNwZE08yuzz5TCOKt7eVX=TitSYBDA@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=dengke.du@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.