Remove a recipe's do_install_append() function in an append file

Remove a recipe's do_install_append() function in an append file

[Cody Piersall]

Hello,

I am building zsh from meta-oe layer, and it has a do_install_append()
function defined like this:

do_install_append () {
    rm -fr ${D}/usr/share
}

which gets rid of lots lots of useful functionality, like
context-aware autocompletion.  Can a bbappend file get rid of that
function, or do I need to edit the actual recipe? I've attempted
defining an empty do_install_append() { : } but it didn't work.

Thanks,
Cody

Re: Remove a recipe's do_install_append() function in an append file

[Matthew McClintock]

On Thu, Mar 23, 2017 at 5:28 PM, Cody Piersall <cody@arrc.ou.edu> wrote:
> Hello,
>
> I am building zsh from meta-oe layer, and it has a do_install_append()
> function defined like this:
>
> do_install_append () {
>     rm -fr ${D}/usr/share
> }
>
> which gets rid of lots lots of useful functionality, like
> context-aware autocompletion.  Can a bbappend file get rid of that
> function, or do I need to edit the actual recipe? I've attempted
> defining an empty do_install_append() { : } but it didn't work.

We hit this sometime so curious if anyone has better suggestions. But
you can add a do_install_prepend to save the data somewhere, and an
append to put it back. Also, you can use the priority of your layer
could come into play here.

-M

Re: Remove a recipe's do_install_append() function in an append file

[Khem Raj]

On Thu, Mar 23, 2017 at 3:28 PM, Cody Piersall <cody@arrc.ou.edu> wrote:
> Hello,
>
> I am building zsh from meta-oe layer, and it has a do_install_append()
> function defined like this:
>
> do_install_append () {
>     rm -fr ${D}/usr/share
> }
>
> which gets rid of lots lots of useful functionality, like
> context-aware autocompletion.  Can a bbappend file get rid of that
> function, or do I need to edit the actual recipe? I've attempted
> defining an empty do_install_append() { : } but it didn't work.
>

if its in a bbappend, there is not much you can do about undoing it except
to not apply the bbappend or modify it directly.

So you can send a patch to meta-oe to convince that its a good idea to keep
/usr/share for zsh, or you can carry a local patch to meta-oe where you undo it


> Thanks,
> Cody
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: Remove a recipe's do_install_append() function in an append file

[Lennart Sorensen]

On Tue, Mar 28, 2017 at 10:27:15AM -0700, Khem Raj wrote:
> On Thu, Mar 23, 2017 at 3:28 PM, Cody Piersall <cody@arrc.ou.edu> wrote:
> > Hello,
> >
> > I am building zsh from meta-oe layer, and it has a do_install_append()
> > function defined like this:
> >
> > do_install_append () {
> >     rm -fr ${D}/usr/share
> > }
> >
> > which gets rid of lots lots of useful functionality, like
> > context-aware autocompletion.  Can a bbappend file get rid of that
> > function, or do I need to edit the actual recipe? I've attempted
> > defining an empty do_install_append() { : } but it didn't work.
> >
> 
> if its in a bbappend, there is not much you can do about undoing it except
> to not apply the bbappend or modify it directly.
> 
> So you can send a patch to meta-oe to convince that its a good idea to keep
> /usr/share for zsh, or you can carry a local patch to meta-oe where you undo it

Perhaps instead of deleting it, it should be put in another package that
people can choose to install if they want it.  Deleting it certainly
does seem rather unfortunate if someone actulally wanted it.

-- 
Len Sorensen

Re: Remove a recipe's do_install_append() function in an append file

[Khem Raj]

[-- Attachment #1.1: Type: text/plain, Size: 1421 bytes --]



On 3/28/17 11:19 AM, Lennart Sorensen wrote:
> On Tue, Mar 28, 2017 at 10:27:15AM -0700, Khem Raj wrote:
>> On Thu, Mar 23, 2017 at 3:28 PM, Cody Piersall <cody@arrc.ou.edu> wrote:
>>> Hello,
>>>
>>> I am building zsh from meta-oe layer, and it has a do_install_append()
>>> function defined like this:
>>>
>>> do_install_append () {
>>>     rm -fr ${D}/usr/share
>>> }
>>>
>>> which gets rid of lots lots of useful functionality, like
>>> context-aware autocompletion.  Can a bbappend file get rid of that
>>> function, or do I need to edit the actual recipe? I've attempted
>>> defining an empty do_install_append() { : } but it didn't work.
>>>
>>
>> if its in a bbappend, there is not much you can do about undoing it except
>> to not apply the bbappend or modify it directly.
>>
>> So you can send a patch to meta-oe to convince that its a good idea to keep
>> /usr/share for zsh, or you can carry a local patch to meta-oe where you undo it
> 
> Perhaps instead of deleting it, it should be put in another package that
> people can choose to install if they want it.  Deleting it certainly
> does seem rather unfortunate if someone actulally wanted it.
> 

We put common stuff in commonly used layers. Secondly, a patch to
package the content of /usr/share into a package of its own something
like zsh-misc might be OK and we don't have to delete it and keep both
camps happy.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: Remove a recipe's do_install_append() function in an append file

[Cody Piersall]

On Fri, Mar 24, 2017 at 8:53 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> On Fri, 24 Mar 2017, Cody Piersall wrote:
>> I am building zsh from meta-oe layer, and it has a do_install_append()
>> function defined like this:
>>
>> do_install_append () {
>>     rm -fr ${D}/usr/share
>> }
>>
>> which gets rid of lots lots of useful functionality, like
>> context-aware autocompletion.  Can a bbappend file get rid of that
>> function, or do I need to edit the actual recipe? I've attempted
>> defining an empty do_install_append() { : } but it didn't work.
>
>   it might be worth asking why zsh is doing that in the first place.
> if one doesn't want all that stuff, *that* is where an append could be
> used to remove it. i think zsh removing it by default is
> inappropriate.
>
> rday

Good point. I've now posted a patch to the meta-oe mailing list:
http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134575.html

Cody

Re: Remove a recipe's do_install_append() function in an append file

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On 24 March 2017 at 13:49, Cody Piersall <cody@arrc.ou.edu> wrote:

> I am building zsh from meta-oe layer, and it has a do_install_append()
> function defined like this:
>
> do_install_append () {
>     rm -fr ${D}/usr/share
> }
>
> which gets rid of lots lots of useful functionality, like
> context-aware autocompletion.  Can a bbappend file get rid of that
> function, or do I need to edit the actual recipe? I've attempted
> defining an empty do_install_append() { : } but it didn't work.
>

Fixing the zsh recipe to have either separate packages or PACKAGECONFIGs
for the useful stuff would be the proper solution, but a really nasty hack
that might work is:

do_install_remove = "rm -rf ${D}/usr/share"

Ross

[-- Attachment #2: Type: text/html, Size: 1240 bytes --]

Re: Remove a recipe's do_install_append() function in an append file

[Alexander Kanavin]

On 03/24/2017 03:53 PM, Robert P. J. Day wrote:
> On Fri, 24 Mar 2017, Cody Piersall wrote:

>> do_install_append () {
>>     rm -fr ${D}/usr/share
>> }
>>
>> which gets rid of lots lots of useful functionality, like
>> context-aware autocompletion.  Can a bbappend file get rid of that
>> function, or do I need to edit the actual recipe? I've attempted
>> defining an empty do_install_append() { : } but it didn't work.
>
>   it might be worth asking why zsh is doing that in the first place.
> if one doesn't want all that stuff, *that* is where an append could be
> used to remove it. i think zsh removing it by default is
> inappropriate.

That's right; it's better to fix the original recipe and send the patch 
so it can be included in meta-oe. What is written in recipes is not some 
kind of Universal Truth; if you see how things could be done better, go 
ahead and do it.

Alex

Re: Remove a recipe's do_install_append() function in an append file

[Robert P. J. Day]

On Fri, 24 Mar 2017, Cody Piersall wrote:

> Hello,
>
> I am building zsh from meta-oe layer, and it has a do_install_append()
> function defined like this:
>
> do_install_append () {
>     rm -fr ${D}/usr/share
> }
>
> which gets rid of lots lots of useful functionality, like
> context-aware autocompletion.  Can a bbappend file get rid of that
> function, or do I need to edit the actual recipe? I've attempted
> defining an empty do_install_append() { : } but it didn't work.

  it might be worth asking why zsh is doing that in the first place.
if one doesn't want all that stuff, *that* is where an append could be
used to remove it. i think zsh removing it by default is
inappropriate.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Remove a recipe's do_install_append() function in an append file

[Cody Piersall]

Hello,

I am building zsh from meta-oe layer, and it has a do_install_append()
function defined like this:

do_install_append () {
    rm -fr ${D}/usr/share
}

which gets rid of lots lots of useful functionality, like
context-aware autocompletion.  Can a bbappend file get rid of that
function, or do I need to edit the actual recipe? I've attempted
defining an empty do_install_append() { : } but it didn't work.

Thanks,
Cody