From: Khem Raj <raj.khem@gmail.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] meta-oe/numactl: Enable NUMA in the kernel config
Date: Thu, 12 Apr 2018 12:06:36 -0700 [thread overview]
Message-ID: <CAMKF1soTmDp2ntWs49=3Lf5x9Cy0ZmKVXyzC902HE7===CvM_Q@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNAxpF1okjTNRoOS2adu+3Xzfq+N7PuektGarCozGt_6Q@mail.gmail.com>
On Thu, Apr 12, 2018 at 11:26 AM, Alistair Francis <alistair23@gmail.com> wrote:
> On Thu, Apr 12, 2018 at 8:49 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On 4/10/18 10:09 AM, Alistair Francis wrote:
>>> If a user has specified numa in their DISTRO_FEATURES then they should
>>> have NUMA support enabled in the kernel. Without kernel support the
>>> numactl program is not very useful.
>>>
>>
>> This should be done in OE-Core as part of main recipe.
>
> Do you mean in core linux-yocto
> (meta/recipes-kernel/linux/linux-yocto.inc)? That seemed a little odd
> to me as the numactl package comes from the meta-oe layer. I was
> thinking it made sense to keep them together.
>
its controlled by a distro feature which would add right knobs to it in core.
it wont be changing any functionality therefore and hence would be ok
> Alistair
>
>>
>> Note that this patch is sent to oe-core ml but is actually against
>> meta-oe layer which follows oe-devel mailing list.
>>
>>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>>> ---
>>> meta-oe/recipes-kernel/linux/linux-yocto.inc | 2 ++
>>> meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 +
>>> meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 +
>>> meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 +
>>> meta-oe/recipes-support/numactl/numactl/numa.cfg | 2 ++
>>> meta-oe/recipes-support/numactl/numactl_git.bb | 1 +
>>> 6 files changed, 8 insertions(+)
>>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc
>>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>> create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>> create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg
>>>
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>>> new file mode 100644
>>> index 0000000..9533eb6
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>>> @@ -0,0 +1,2 @@
>>> +KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
>>> +
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>>> new file mode 100644
>>> index 0000000..fe1394d
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>>> @@ -0,0 +1,2 @@
>>> +CONFIG_NUMA=y
>>> +CONFIG_ACPI_NUMA=y
>>> diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb b/meta-oe/recipes-support/numactl/numactl_git.bb
>>> index b9cbcf0..ef2dab2 100644
>>> --- a/meta-oe/recipes-support/numactl/numactl_git.bb
>>> +++ b/meta-oe/recipes-support/numactl/numactl_git.bb
>>> @@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \
>>> file://run-ptest \
>>> file://0001-define-run-test-target.patch \
>>> "
>>> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' file://numa.cfg', '', d)}"
>>>
>>> S = "${WORKDIR}/git"
>>>
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2018-04-12 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:09 [PATCH] meta-oe/numactl: Enable NUMA in the kernel config Alistair Francis
2018-04-10 17:32 ` ✗ patchtest: failure for " Patchwork
2018-04-12 15:49 ` [PATCH] " Khem Raj
2018-04-12 18:26 ` Alistair Francis
2018-04-12 19:06 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1soTmDp2ntWs49=3Lf5x9Cy0ZmKVXyzC902HE7===CvM_Q@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=alistair23@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.