From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f47.google.com (mail-pg0-f47.google.com [74.125.83.47]) by mail.openembedded.org (Postfix) with ESMTP id 3E4DC7867C for ; Tue, 20 Feb 2018 16:08:15 +0000 (UTC) Received: by mail-pg0-f47.google.com with SMTP id g2so7278662pgn.7 for ; Tue, 20 Feb 2018 08:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J+ZqwzQOh12kMAgd7wWQW1OZN8EJ1CDEaVKnkWO0DpQ=; b=d4og+a46VPK3LPkoWywoy2bJzIcY24QcLHLvDe3jO7GcLyryQINS8qP9yoPp6Tu+y2 nsUR6l4Yl7m5saoQg7S8wY5f+SZLlbB0nAX0QzHRSKk4M1vqnTcyuktQ1MScvFoHX4g4 Tkk4Oj9gNTvHHkgc+h5E3tQ7K4xXDBPUvqCgaNEfjS3cz9RuE2yCcSigVlmon8g2m0yY vQ0U1YmXtBL9rNlIJUIAhzM3WpfYETZrMWRPHClke6Y/DMoJYLX//PSW7CiwHbMSUsvp uMBnfZBkW+r1T7mKAPj13B/12o0rAQl5kFyQiUoAAe9/TLJ79qKkx6JgNv9oyfUJIbTo GMpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J+ZqwzQOh12kMAgd7wWQW1OZN8EJ1CDEaVKnkWO0DpQ=; b=pn8lwflZBFlMIAqYXYJtTUW+XO2i4HZW0HGMF7sw0zGzjy4UAT/dp2rB0tBZdlVNTO 3wfYU+MdNuhub7v/3Be9h1eW/LcvUJrqeizfGXBOioXXpYK175lJi35GZLGS/ca2lY+b LGEcm7/HfJu0cZil2r/fgnbtTUaMpyPeULo6a5DohJdirDL4JPNe+QY2xKWRAbub3HXH +OtfVgrSenqqbf+C3BDGWfsGnvEVh92p4bjqDqejUg7GODYNsrB5bMATOQ6NcXa/cUyb JwAXNYdOSgu63PGTBstzt22/UyZPerQc8MY7FLRo5lxyZ0o+7RPAFQLO9HkMU/B+XGz0 ZdYw== X-Gm-Message-State: APf1xPCdQgFhSuBZG727K+FJzUAdc74shrjBzOpvaTdEMCYBuI4fZq+V zcLO7oknh49ExePoeHM0WbDrw6N0rZzEjWnqEJw= X-Google-Smtp-Source: AH8x224Fu+DKzbiik14lCBz4+eOhkiIQXXaUAM6wqnViBFKU95j5FLxmQo5OGfTR6nJJqnaFShiIvPe1k4v8XgwPc0s= X-Received: by 10.99.170.73 with SMTP id x9mr69495pgo.393.1519142897158; Tue, 20 Feb 2018 08:08:17 -0800 (PST) MIME-Version: 1.0 References: <1519084455-3915-1-git-send-email-denis@denix.org> <20180220012001.GZ2786@denix.org> <8d340a29-2016-55fa-0fd2-9847e6f9e62b@gmail.com> In-Reply-To: From: Khem Raj Date: Tue, 20 Feb 2018 16:08:06 +0000 Message-ID: To: Martin Jansa Cc: Patches and discussions about the oe-core layer , Otavio Salvador , Denys Dmytriyenko Subject: Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 16:08:16 -0000 Content-Type: multipart/alternative; boundary="94eb2c1bfbbcbf8f120565a70401" --94eb2c1bfbbcbf8f120565a70401 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa wrote: > I'm OK with adding bison-native for all versions. > As long we know that there are no side effects of this dep in kernel builds > > When we added bc-native 2+ years ago: > commit c067e52cffe002de3b39aa1bced308dd532859c1 > Author: Alejandro Hernandez > Date: Thu Oct 2 15:33:23 2014 -0500 > > kernel: Added bc-native as DEPENDS > > The makefile checks for bc during for compilation > > it was also needed only for the latest kernel and we didn't make it > conditional on the kernel version. Now with RSS it's even less dangerous as > the bison-native will appear only in kernel's RSS and as Denys said it's > quite common dependency so many components pull it into RSS anyway. > > On Tue, Feb 20, 2018 at 3:53 PM, Otavio Salvador < > otavio.salvador@ossystems.com.br> wrote: > >> On Tue, Feb 20, 2018 at 7:10 AM, Khem Raj wrote: >> > On 2/19/18 5:20 PM, Denys Dmytriyenko wrote: >> >> >> >> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote: >> >>> >> >>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko >> >>> wrote: >> >>>> >> >>>> From: Denys Dmytriyenko >> >>>> >> >>>> Explicitly depend on bison-native for deterministic builds, as it is >> >>>> required >> >>>> for the build: >> >>>> >> >>>> | HOSTCC scripts/basic/fixdep >> >>>> | GEN ./Makefile >> >>>> | HOSTCC scripts/kconfig/conf.o >> >>>> | YACC scripts/kconfig/zconf.tab.c >> >>>> | /bin/sh: bison: command not found >> >>>> | scripts/Makefile.lib:217: recipe for target >> >>>> 'scripts/kconfig/zconf.tab.c' failed >> >>>> >> >>>> In most cases, this dependency comes indirectly via toolchain >> >>>> dependencies, >> >>>> specifically binutils-cross, which pulls bison-native. Different >> setups, >> >>>> such as with external toolchain, would expose this problem, since >> >>>> correct >> >>>> dependency is not marked explicitly. >> >>>> >> >>>> Signed-off-by: Denys Dmytriyenko >> >>>> --- >> >>>> I'm seeing this now on 4.16-rc2 with external toolchain. >> >>> >> >>> >> >>> I am not against the addition but in fact, it is because 4.16 stopped >> >>> of using pre-generated files and now requires bison to be available. >> >> >> >> >> >> Ok, good, I was wondering why I didn't see it before 4.16... >> >> >> >> >> >>> I am unsure it ought to be on kernel.bbclass at this moment. >> >> >> >> >> >> Why not? Because it's 4.16+ specific? >> >> >> >> By default bison-native dependency gets added implicitly when built >> with >> >> the >> >> toolchain from oe-core, so this doesn't add any extra dependencies, >> only >> >> makes >> >> it explicit. >> >> >> > it will be overcompensating for < 4.16 kernel recipes where this >> dependency >> > is not needed. it might be a legit dependency for another component, >> that >> > doesn't stage this package in kernel recipe-specific sysroot but this >> change >> > will do that. So its not completely innocent change. >> >> I'd be in favor of matching the version and adding it if it is a 4.16 >> or newer kernel. Adding for prior versions seems wrong for me. >> >> -- >> Otavio Salvador O.S. Systems >> http://www.ossystems.com.br http://code.ossystems.com.br >> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 >> > -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > --94eb2c1bfbbcbf8f120565a70401 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Feb 20, 2018 = at 7:41 AM Martin Jansa <marti= n.jansa@gmail.com> wrote:
I'm OK with adding bison-native for all versions.
=


A= s long we know that there are no side effects of this dep in kernel builds= =C2=A0

When we= added bc-native 2+ years ago:
commit c067e52cffe002de3b39aa= 1bced308dd532859c1
Author: Alejandro Hernandez <alejandro.hernan= dez@linux.intel.com>
Date:=C2=A0 =C2=A0Thu Oct 2 15:33:23 = 2014 -0500

=C2=A0 =C2=A0 kernel: Added bc-native a= s DEPENDS
=C2=A0 =C2=A0=C2=A0
=C2=A0 =C2=A0 The makefil= e checks for bc during for compilation

it wa= s also needed only for the latest kernel and we didn't make it conditio= nal on the kernel version. Now with RSS it's even less dangerous as the= bison-native will appear only in kernel's RSS and as Denys said it'= ;s quite common dependency so many components pull it into RSS anyway.

On Tue, Feb 20, 201= 8 at 3:53 PM, Otavio Salvador <otavio.salvador@ossystems.com.br>= wrote:
On Tue, Feb 20, 2018 at 7:10= AM, Khem Raj <r= aj.khem@gmail.com> wrote:
> On 2/19/18 5:20 PM, Denys Dmytriyenko wrote:
>>
>> On Mon, Feb 19, 2018 at 09:36:22PM -0300, Otavio Salvador wrote: >>>
>>> On Mon, Feb 19, 2018 at 8:54 PM, Denys Dmytriyenko <denis@denix.org>
>>> wrote:
>>>>
>>>> From: Denys Dmytriyenko <denys@ti.com>
>>>>
>>>> Explicitly depend on bison-native for deterministic builds= , as it is
>>>> required
>>>> for the build:
>>>>
>>>> |=C2=A0 =C2=A0HOSTCC=C2=A0 scripts/basic/fixdep
>>>> |=C2=A0 =C2=A0GEN=C2=A0 =C2=A0 =C2=A0./Makefile
>>>> |=C2=A0 =C2=A0HOSTCC=C2=A0 scripts/kconfig/conf.o
>>>> |=C2=A0 =C2=A0YACC=C2=A0 =C2=A0 scripts/kconfig/zconf.tab.= c
>>>> | /bin/sh: bison: command not found
>>>> | scripts/Makefile.lib:217: recipe for target
>>>> 'scripts/kconfig/zconf.tab.c' failed
>>>>
>>>> In most cases, this dependency comes indirectly via toolch= ain
>>>> dependencies,
>>>> specifically binutils-cross, which pulls bison-native. Dif= ferent setups,
>>>> such as with external toolchain, would expose this problem= , since
>>>> correct
>>>> dependency is not marked explicitly.
>>>>
>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>>> ---
>>>> I'm seeing this now on 4.16-rc2 with external toolchai= n.
>>>
>>>
>>> I am not against the addition but in fact, it is because 4.16 = stopped
>>> of using pre-generated files and now requires bison to be avai= lable.
>>
>>
>> Ok, good, I was wondering why I didn't see it before 4.16... >>
>>
>>> I am unsure it ought to be on kernel.bbclass at this moment. >>
>>
>> Why not? Because it's 4.16+ specific?
>>
>> By default bison-native dependency gets added implicitly when buil= t with
>> the
>> toolchain from oe-core, so this doesn't add any extra dependen= cies, only
>> makes
>> it explicit.
>>
> it will be overcompensating for < 4.16 kernel recipes where this de= pendency
> is not needed. it might be a legit dependency for another component, t= hat
> doesn't stage this package in kernel recipe-specific sysroot but t= his change
> will do that. So its not completely innocent change.

I'd be in favor of matching the version and adding it if it= is a 4.16
or newer kernel. Adding for prior versions seems wrong for me.

--
Otavio Salvador=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0O.S. Systems
http://www.ossystems.com.br=C2=A0 =C2=A0 =C2=A0 =C2=A0 http://code= .ossystems.com.br
Mobile: +55 (53) 9981-7854=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailma= n/listinfo/openembedded-core
--94eb2c1bfbbcbf8f120565a70401--