From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f66.google.com (mail-qg0-f66.google.com [209.85.192.66]) by mail.openembedded.org (Postfix) with ESMTP id C3C7F60721 for ; Wed, 11 May 2016 21:55:52 +0000 (UTC) Received: by mail-qg0-f66.google.com with SMTP id e35so3907269qge.1 for ; Wed, 11 May 2016 14:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sf2fZPvDEsLhRLS+SqdvNkBVyijAvOiL2rNe4NM04aA=; b=xOSK3ZHywVAkAjKR4o29MsnXbU6SWpAMf+5M0vEz+tfcjbpVxRRIZG5eHL6tW9/34U U+k+f4lw6HCrjvXUNvPH52F+IuoK9YjdLx9wfDd2ey1wGZZ13LFh7CWaczFbzTCaO/f9 CHXbVLHDmbiyo+yDuO6jKX9shVTkHsStwAQx3u929wu1yIaKa2xEDJrCeVzYYlzHhVAO fguZ+M8AtkCasO2JLCJ8oyMJ30Lca9MXwDB9faGdF7lXVJGFAzzhMcKZX/k2yUHqTSLX wcXASVRZysu/fnmFysNwbPTXuzy54NDKagaAlU+KL5w17G9pGU3Pa6qj5iWl3du6w8Vr 9B4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sf2fZPvDEsLhRLS+SqdvNkBVyijAvOiL2rNe4NM04aA=; b=UXqmOB8ehhPgmWNkRRaF2pA+CwzEwa4nYcFRMVBz5ThhzRzbeEi9g/KpPU/NgfOR02 Q1d3+1Ypr6ySB0e8Kr3Yh9YtG3cQCqSPiIDHYCO5VcfHm4EHer5/rVidM5ey04z+MaSX AxzTudcwOW6HuZvp3DD3jjTx3bdpbQOGYkZqpLJy3/IvnA7DwtpZdYo63uZRbjeOVwVe ARVMjJvxOtCH3+BxIxotZjp7zP0yN/qii18dr5wljLEgQP5k1HUexXh32xvjRyM8itf7 lI9WS+MaO32ARVN3iBXpqU9Nz405KuwdfHSvSzr6qd8c8mYwtrXBceSA5u1AcFgGPuKu f0Qw== X-Gm-Message-State: AOPr4FXnxsvfP3o/nSXyvpF7Ajjg/YTpW6Rr3ArDWAT2D3V/YE2Z0MRzWp/SR4QyjYhQXeqIcTOKcppeu/05+g== X-Received: by 10.140.19.174 with SMTP id 43mr6187763qgh.44.1463003753556; Wed, 11 May 2016 14:55:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.130.196 with HTTP; Wed, 11 May 2016 14:55:24 -0700 (PDT) In-Reply-To: References: <2e51e9b5fb3911436afc1becd5feb9351b896fa4.1462987863.git.raj.khem@gmail.com> <1d16314288f1f93b21bacd0016d23abcab52b501.1462987863.git.raj.khem@gmail.com> From: Khem Raj Date: Wed, 11 May 2016 14:55:24 -0700 Message-ID: To: Bruce Ashfield Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 22/42] linux-yocto: Fix build on ppc with gcc-6 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 21:55:55 -0000 Content-Type: text/plain; charset=UTF-8 On Wed, May 11, 2016 at 2:36 PM, Bruce Ashfield wrote: > > > On Wed, May 11, 2016 at 5:30 PM, Khem Raj wrote: >> >> On Wed, May 11, 2016 at 2:27 PM, Bruce Ashfield >> wrote: >> > >> > >> > On Wed, May 11, 2016 at 1:35 PM, Khem Raj wrote: >> >> >> >> Signed-off-by: Khem Raj >> > >> > >> > >> > These shouldn't be carried out of tree. So can you drop the linux-yocto >> > changes from the >> > series, and I'll look at getting them integrated later. >> >> I could but, this series switches to using gcc6 which will start to fail. > > > I can coordinate the fix. We just don't carry patches like this for linux > yocto. As you > can see, your series will no longer apply with the consolidated pull > requests that > I just sent. Just include these patches in your pull request and send a v2. I will then drop it from my list. since these patches should work fine with older gcc as well your changes then can go in first or along with my changes. > > Bruce > >> >> >> > >> > Bruce >> > >> >> >> >> --- >> >> ...ace-Fix-out-of-bounds-array-access-warnin.patch | 50 >> >> ++++++++++++++++++++++ >> >> meta/recipes-kernel/linux/linux-yocto_4.4.bb | 4 +- >> >> 2 files changed, 53 insertions(+), 1 deletion(-) >> >> create mode 100644 >> >> >> >> meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch >> >> >> >> diff --git >> >> >> >> a/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch >> >> >> >> b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch >> >> new file mode 100644 >> >> index 0000000..05315ed >> >> --- /dev/null >> >> +++ >> >> >> >> b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch >> >> @@ -0,0 +1,50 @@ >> >> +From 32acc1d9a5738b02e8815047af8886978aa40ead Mon Sep 17 00:00:00 2001 >> >> +From: Khem Raj >> >> +Date: Mon, 25 Apr 2016 05:47:01 +0000 >> >> +Subject: [PATCH V2] powerpc/ptrace: Fix out of bounds array access >> >> warning >> >> + >> >> +gcc-6 correctly warns about a out of bounds access >> >> + >> >> +arch/powerpc/kernel/ptrace.c:407:24: warning: index 32 denotes an >> >> offset >> >> greater than size of 'u64[32][1] {aka long long unsigned int[32][1]}' >> >> [-Warray-bounds] >> >> + offsetof(struct thread_fp_state, fpr[32][0])); >> >> + ^ >> >> + >> >> +check the end of array instead of beginning of next element to fix >> >> this >> >> + >> >> +Signed-off-by: Khem Raj >> >> +Cc: Kees Cook >> >> +Cc: Michael Ellerman >> >> +Cc: Segher Boessenkool >> >> +--- >> >> +Changes from v1 to v2: >> >> + >> >> +- Check for fpr[32] instead of fpr[31][1] >> >> + >> >> + arch/powerpc/kernel/ptrace.c | 4 ++-- >> >> + 1 file changed, 2 insertions(+), 2 deletions(-) >> >> + >> >> +diff --git a/arch/powerpc/kernel/ptrace.c >> >> b/arch/powerpc/kernel/ptrace.c >> >> +index 737c0d0..b38fd08 100644 >> >> +--- a/arch/powerpc/kernel/ptrace.c >> >> ++++ b/arch/powerpc/kernel/ptrace.c >> >> +@@ -376,7 +376,7 @@ static int fpr_get(struct task_struct *target, >> >> const >> >> struct user_regset *regset, >> >> + >> >> + #else >> >> + BUILD_BUG_ON(offsetof(struct thread_fp_state, fpscr) != >> >> +- offsetof(struct thread_fp_state, fpr[32][0])); >> >> ++ offsetof(struct thread_fp_state, fpr[32])); >> >> + >> >> + return user_regset_copyout(&pos, &count, &kbuf, &ubuf, >> >> + &target->thread.fp_state, 0, -1); >> >> +@@ -404,7 +404,7 @@ static int fpr_set(struct task_struct *target, >> >> const >> >> struct user_regset *regset, >> >> + return 0; >> >> + #else >> >> + BUILD_BUG_ON(offsetof(struct thread_fp_state, fpscr) != >> >> +- offsetof(struct thread_fp_state, fpr[32][0])); >> >> ++ offsetof(struct thread_fp_state, fpr[32])); >> >> + >> >> + return user_regset_copyin(&pos, &count, &kbuf, &ubuf, >> >> + &target->thread.fp_state, 0, -1); >> >> +-- >> >> +1.9.1 >> >> + >> >> diff --git a/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> b/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> index b74903e..fbb592a 100644 >> >> --- a/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> +++ b/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> @@ -22,7 +22,9 @@ SRCREV_machine ?= >> >> "b18090556c1d1b449233cd555c27a04d38272d6d" >> >> SRCREV_meta ?= "9ab4787fe2aea2ae0fcc31a5e067eaba19ef64c8" >> >> >> >> SRC_URI = >> >> >> >> "git://git.yoctoproject.org/linux-yocto-4.4.git;name=machine;branch=${KBRANCH}; >> >> \ >> >> - >> >> >> >> git://git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=yocto-4.4;destsuffix=${KMETA}" >> >> + >> >> >> >> git://git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=yocto-4.4;destsuffix=${KMETA} >> >> \ >> >> + >> >> file://0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch >> >> \ >> >> +" >> >> >> >> LINUX_VERSION ?= "4.4.3" >> >> >> >> -- >> >> 2.8.2 >> >> >> >> -- >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > >> > >> > >> > >> > -- >> > "Thou shalt not follow the NULL pointer, for chaos and madness await >> > thee at >> > its end" > > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await thee at > its end"