From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by mail.openembedded.org (Postfix) with ESMTP id ACD777780A for ; Tue, 20 Feb 2018 18:29:16 +0000 (UTC) Received: by mail-pg0-f67.google.com with SMTP id l131so7445278pga.2 for ; Tue, 20 Feb 2018 10:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RwO60WyHE6VBwTYXKd0QwksP0a0ZuDNQyyVr7gjWI60=; b=UV/XGTEsW7Hktrzgy4ovLa0BN+IRW7Uc5vIOi/c9Ey0Uuwie1hr+/JozAh3Ld93CKD QjnGOIvXVSVf3JuBKLfV2zYAk+no7epACycI+2lrmlxiOwdlW2VR9CBv43nNx9BbDBxb 1A+hpPf4OH+exLhmCVXPuc2v8i/ncUd9NMMQcagTxbCfiKoGjDlKPr3iJ645Dm56Pife x+dbNV1ALLPqgimmeH+3bIzI3uI7x3NRsww7WZDeggblR244W9KXBDBnnzr3YRS1OD0C dLUAfM6wVcZkayry64B/xtYZfV3NPXrZF4/a3qMOD7dlp4cp3ut5GSHLDrADNRkbKBOO wagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RwO60WyHE6VBwTYXKd0QwksP0a0ZuDNQyyVr7gjWI60=; b=dlCpS7dxDZHoD5aNtdYmpvEvEjlSPRkferjkEdGf7f956Q3eh0RkYIAnTAqMRc1rQQ skI83EecFnZCW9vZRFxD1X4H/wCBvMvh8+H/EZTHjQGSqKmbIghxC84EQIngWwj9ASmd MKKXFw+DPF6u1ohc+pN7lpVpi7d+DFEnnAZzNL/gJfUj0gUUGudW9RJwPb0GejgaU8xF dva7gX50Qf4ljGkhyB+WGss6hAOFeRFjl4xYShEiET2SBs08ZyMbNVVnaI/W0A39R95P JAFa/Q+x1IK3VE++ytdqsyarkE75Hdor8ZrHP3OI2YVS86DFZMlyNoji2siFoa6NOgqD iTaQ== X-Gm-Message-State: APf1xPBDsQafctI8dt3w7sjZKxATgKE1VS+YBI25tDdf24sEN80CB7Ic L7z+bkXXtKrXQnX6HqenWo6CUE7pJ2ocrUiz2/Y= X-Google-Smtp-Source: AH8x225jjlJVHkLPJ8AefblNs+PPJaZDNfx5E/0/aC/Od/VuSPQercJ5yLq/nDXLqiUaBjKkqPQcl7R5th0GrnBK9i4= X-Received: by 10.98.229.21 with SMTP id n21mr523369pff.158.1519151357551; Tue, 20 Feb 2018 10:29:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.221.21 with HTTP; Tue, 20 Feb 2018 10:28:47 -0800 (PST) In-Reply-To: <20180220161752.GA2786@denix.org> References: <1519084455-3915-1-git-send-email-denis@denix.org> <20180220012001.GZ2786@denix.org> <8d340a29-2016-55fa-0fd2-9847e6f9e62b@gmail.com> <20180220161752.GA2786@denix.org> From: Khem Raj Date: Tue, 20 Feb 2018 10:28:47 -0800 Message-ID: To: Denys Dmytriyenko Cc: Denys Dmytriyenko , Otavio Salvador , Patches and discussions about the oe-core layer Subject: Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 18:29:16 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 20, 2018 at 8:17 AM, Denys Dmytriyenko wrote: > On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote: >> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa wrote: >> >> > I'm OK with adding bison-native for all versions. >> >> As long we know that there are no side effects of this dep in kernel builds > > You do realize that when you build with oe-core toolchain, every package gets > bison-native dependency automatically? Regardless whether it was requested or > not. If there were side effects, we would have seen it long time ago... Yes I see it seems to be pulled in by toolchain regardless, so for this patch we might just be adding to determinism. but I think it raises question on why toolchain is adding this everywhere, I think we should remove it from toolchain default deps. It will make metadata more consistent across internal/external toolchains