From: Khem Raj <raj.khem@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
Date: Mon, 9 Sep 2019 07:21:16 -0700 [thread overview]
Message-ID: <CAMKF1sp82+VfqstYutVxV5MfmGGBDGMFUsJ3rYWZb2go4CSKcg@mail.gmail.com> (raw)
In-Reply-To: <4719cb39acdead5dd44e1100f0dd9265b0185da2.camel@linuxfoundation.org>
On Mon, Sep 9, 2019 at 12:44 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sun, 2019-09-08 at 20:16 -0700, Khem Raj wrote:
> > This helps recipes where they need to explicitly pass the variable
> > and
> > does not entertain the ones from environment
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/classes/python3native.bbclass | 6 ++++--
> > meta/classes/pythonnative.bbclass | 6 ++++--
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/classes/python3native.bbclass
> > b/meta/classes/python3native.bbclass
> > index d98fb4c758..bed04bd941 100644
> > --- a/meta/classes/python3native.bbclass
> > +++ b/meta/classes/python3native.bbclass
> > @@ -14,8 +14,8 @@ export STAGING_LIBDIR
> > # find_package(PythonLibs REQUIRED)
> > # which ends up using libs/includes from build host
> > # Therefore pre-empt that effort
> > -export
> > PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> > -export
> > PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
> > +PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> > +PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
> >
> > export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata"
> >
> > @@ -24,3 +24,5 @@ export PYTHONNOUSERSITE = "1"
> >
> > # autoconf macros will use their internal default preference
> > otherwise
> > export PYTHON
> > +export PYTHON_LIBRARY
> > +export PYTHON_INCLUDE_DIR
>
> I'm confused as this makes no difference to bitbake and is equivalent.
> exported variables are always set in the datastore...
>
I was still seeing it unset on am ARM builder, I, however, did a
composite change where this change along with another change where
this was used went in together so I need to test this separately
second reeason was to make it adhere to same convention in the
bbclass like other variable e.g. PYTHON which inself could be reeason
good for this change even if it is a nop
> Cheers,
>
> Richard
>
prev parent reply other threads:[~2019-09-09 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 3:16 [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR Khem Raj
2019-09-09 3:32 ` ✗ patchtest: failure for " Patchwork
2019-09-09 7:44 ` [PATCH] " Richard Purdie
2019-09-09 14:21 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1sp82+VfqstYutVxV5MfmGGBDGMFUsJ3rYWZb2go4CSKcg@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.