All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe] nodejs: no internationalization support
@ 2018-09-19 11:15 Raphael Kubo da Costa
  2018-09-19 14:31 ` Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Raphael Kubo da Costa @ 2018-09-19 11:15 UTC (permalink / raw)
  To: openembedded-devel

I originally filed
https://github.com/openembedded/meta-openembedded/issues/93 about this
but was told it's probably better to discuss it on the list.

The nodejs recipe currently builds node with --without-intl. That means
there's no internationalization support. One of the consequences of that
is is that the inspector module is not built at all.

Recent (at least M71 onwards) Chromium releases need the inspector
module as part of the build, so I wonder if the recipe can start
depending on ICU and pass --with-intl=system-icu to configure.py.

Using --with-intl=system-icu might require checking if the ICU version
provided in a branch matches the one Node expects; in the worst case, I
guess --with-intl=small-icu should work).

Is there any specific reason why --without-intl is being passed in the
first place?


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [meta-oe] nodejs: no internationalization support
  2018-09-19 11:15 [meta-oe] nodejs: no internationalization support Raphael Kubo da Costa
@ 2018-09-19 14:31 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2018-09-19 14:31 UTC (permalink / raw)
  To: Raphael Kubo da Costa; +Cc: openembeded-devel

On Wed, Sep 19, 2018 at 4:17 AM Raphael Kubo da Costa
<raphael.kubo.da.costa@intel.com> wrote:
>
> I originally filed
> https://github.com/openembedded/meta-openembedded/issues/93 about this
> but was told it's probably better to discuss it on the list.
>
> The nodejs recipe currently builds node with --without-intl. That means
> there's no internationalization support. One of the consequences of that
> is is that the inspector module is not built at all.
>

right, it is there for size reasons. ICU is kind of large and since
debugger uses it, when we disable ICU debugger is disabled too.

I think we could make it a packageconfig and enable/disable debugger
support that way if you care to send a patch, I can look into
integrating it.

> Recent (at least M71 onwards) Chromium releases need the inspector
> module as part of the build, so I wonder if the recipe can start
> depending on ICU and pass --with-intl=system-icu to configure.py.
>
> Using --with-intl=system-icu might require checking if the ICU version
> provided in a branch matches the one Node expects; in the worst case, I
> guess --with-intl=small-icu should work).
>
> Is there any specific reason why --without-intl is being passed in the
> first place?


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-19 14:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 11:15 [meta-oe] nodejs: no internationalization support Raphael Kubo da Costa
2018-09-19 14:31 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.