From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f42.google.com (mail-pg0-f42.google.com [74.125.83.42]) by mail.openembedded.org (Postfix) with ESMTP id 037BC605FE for ; Tue, 6 Feb 2018 00:47:24 +0000 (UTC) Received: by mail-pg0-f42.google.com with SMTP id w17so216949pgv.6 for ; Mon, 05 Feb 2018 16:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PZFMF2tNJj0Kp1CR+5cBuZgm7XYhznFF+mEalzoVSrI=; b=EyA56g5RMcAQHFZ30oXccC6FpIFQ7JOWXlBuLl8P6M7XahzHJh1VasbXaZTjS09erW 93k7KJ73h4z9a8gcPLrnXK1VhbDmlUg7JjCjidUN2+p/83AZ5mSKafPn6offWzBdym2J LBnozh1xeLC9qAucQfdCssWvs03MuyenHXsP+Fdbnhm69U29TufyxjFhCqxrYLw0c5yr jnqICcY4VvhtKjQR4DZBUz4Ze8tgrX7VGo1gyMY071MUZ/QIDwi93+riIoHEi0xrVN7r UQU0a7vdCzLOkdFhuvARHY3JTUGMyFcqtmoHwspuYjlCB9rqXtOt6QpZRoCEs+EDRvO8 lXyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PZFMF2tNJj0Kp1CR+5cBuZgm7XYhznFF+mEalzoVSrI=; b=r6KekDgPNPYznXvQmu77bKXH8FNHYDd2QPgdzXzVPJL1CdC5AUZy3q8/GtFuugT/IU tdy5cn7Gtod6e7wYz27Uj25yjk+BMDYYFSwHW2gAx2ADjtmTI8PLECOFCRu3Ll1IYPbp X9BH46T8/TwLZ3vVvIgIppnzzLElFbDv+NKQjcakeb0RbF0SRZQ7wWsZUGOo+ZAGET4A tVuECt1JAzQO0EZ2VkqpPWiHpK2n0mA/aX6dXN+d95NdOB+93/cY/DxbUflaCebMqubd rt8pWems7Rf64jT2T3N0l3xyyOenPKPJqC1WW3FHdBbI0DQ8vqgypRGUdkDukNKU2996 xqlQ== X-Gm-Message-State: APf1xPBdn5fbAZ09bADKSgSSU3cosLZF5rWIzZyWH8vooGt+y0Pxak+R h0XOlU4JgRTz1fcDGefyE5pgxyJ5ZhFZcbl8//E= X-Google-Smtp-Source: AH8x224lxb7Hzfrg9MBh6G6wPtfK+H0cxNX2VnC9pWDOPcGMkT1wjoOTjyssgVhHyma22YDdhmIngQBzAHPnbbMIA+w= X-Received: by 10.99.111.68 with SMTP id k65mr481983pgc.446.1517878045830; Mon, 05 Feb 2018 16:47:25 -0800 (PST) MIME-Version: 1.0 References: <20171219221234.21699-1-california.l.sullivan@intel.com> <8686fa07-e2a8-1080-e646-7380437e7338@intel.com> <49611977-aff9-6e13-ab7a-0233208e49b3@intel.com> In-Reply-To: From: Khem Raj Date: Tue, 06 Feb 2018 00:47:14 +0000 Message-ID: To: Cal Sullivan Cc: OE-core Subject: Re: [PATCH] core-image-minimal-initramfs: use initramfs-framework for initialization X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 00:47:25 -0000 Content-Type: multipart/alternative; boundary="94eb2c19d500bbf1e9056480859e" --94eb2c19d500bbf1e9056480859e Content-Type: text/plain; charset="UTF-8" On Mon, Feb 5, 2018 at 4:15 PM Cal Sullivan wrote: > Looking at the test and the output, its expecting /dev/sda3 to be mounted > as /media and /dev/sda4 to be mounted as /mnt. With this test result, there > is no /media, and instead /dev/sda3 is mounted to /mnt. > > That seems odd to me unless that partition either wasn't created or went > entirely undetected. > > I'll take a closer look, I think there's more going on here. > Udev trigger sometimes get ignored have seem that in past > > > --- > Cal > > On 02/05/2018 03:34 PM, Burton, Ross wrote: > > This is causing the qemu boot wic test to fail in oe-selftest: > > 2018-02-05 15:08:41,786 - oe-selftest - INFO - FAIL [64.639s]: test_qemu > (wic.Wic) > 2018-02-05 15:08:41,786 - oe-selftest - INFO - > ---------------------------------------------------------------------- > 2018-02-05 15:08:41,786 - oe-selftest - INFO - Traceback (most recent call > last): > File > "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/core/decorator/__init__.py", > line 32, in wrapped_f > return func(*args, **kwargs) > File > "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/wic.py", > line 58, in wrapped_f > return func(*args, **kwargs) > File > "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/wic.py", > line 637, in test_qemu > self.assertEqual(output, '/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 > /mnt') > AssertionError: '/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 > /media\r\n/dev/sda4 /mnt' != '/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 > /mnt' > /dev/root / > /dev/sda1 /boot > - /dev/sda3 /media > - /dev/sda4 /mnt? ^ > + /dev/sda3 /mnt? ^ > > Presumably this is the initramfs mounting more stuff automatically? I > don't have an opinion right now as to whether this is a problem with the > initramfs or the test case being too strict... > > Ross > > > On 1 February 2018 at 14:03, Burton, Ross wrote: > >> Sorry, missed this. I'll pull it into MUT and throw it at the >> autobuilder... >> >> Ross >> >> On 31 January 2018 at 22:53, Cal Sullivan < >> california.l.sullivan@intel.com> wrote: >> >>> Ping. >>> >>> --- >>> Cal >>> >>> >>> On 01/09/2018 05:00 PM, Cal Sullivan wrote: >>> >>>> Anything wrong with this? Haven't seen it hit any mut branches. >>>> >>>> Thanks, >>>> Cal >>>> >>>> On 12/19/2017 02:12 PM, California Sullivan wrote: >>>> >>>>> initramfs-framework is more modular and expandable. This change was >>>>> proposed in commit 28fc6ba761ed4a47efa7c43e7f7dff5e2fe72b5e >>>>> "core-image-minimal-initramfs: use initramfs-framework by default" but >>>>> reverted due to the selftests >>>>> runqemu.RunqemuTests.test_boot_machine_iso >>>>> and runqemu.RunqemuTests.test_boot_deploy_hddimg failing. Since then, >>>>> the kinks have been worked out, and missing functionality that had been >>>>> missed (non-EFI installation module) has been added. >>>>> >>>>> Since the PACKAGE_INSTALL variable was getting so long with all these >>>>> individual modules getting added, I also introduced a new >>>>> INITRAMFS_SCRIPTS variable to the core-image-minimal-initramfs recipe. >>>>> This variable makes the recipe look much cleaner, and also allows >>>>> easier >>>>> replacement or additions to the scripts. >>>>> >>>>> Fixes [YOCTO #10987]. >>>>> >>>>> Signed-off-by: California Sullivan >>>>> --- >>>>> meta/recipes-core/images/core-image-minimal-initramfs.bb | 10 >>>>> +++++++++- >>>>> 1 file changed, 9 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>>> b/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>>> index 5794a25952a..a9ba91bd310 100644 >>>>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>>> @@ -3,7 +3,15 @@ DESCRIPTION = "Small image capable of booting a >>>>> device. The kernel includes \ >>>>> the Minimal RAM-based Initial Root Filesystem (initramfs), which >>>>> finds the \ >>>>> first 'init' program more efficiently." >>>>> -PACKAGE_INSTALL = "initramfs-live-boot initramfs-live-install >>>>> initramfs-live-install-efi ${VIRTUAL-RUNTIME_base-utils} udev base-passwd >>>>> ${ROOTFS_BOOTSTRAP_INSTALL}" >>>>> +INITRAMFS_SCRIPTS ?= "\ >>>>> + initramfs-framework-base \ >>>>> + initramfs-module-setup-live \ >>>>> + initramfs-module-udev \ >>>>> + initramfs-module-install \ >>>>> + initramfs-module-install-efi \ >>>>> + " >>>>> + >>>>> +PACKAGE_INSTALL = "${INITRAMFS_SCRIPTS} ${VIRTUAL-RUNTIME_base-utils} >>>>> udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}" >>>>> # Do not pollute the initrd image with rootfs features >>>>> IMAGE_FEATURES = "" >>>>> >>>> >>>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >> >> > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --94eb2c19d500bbf1e9056480859e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Feb 5, 2018 a= t 4:15 PM Cal Sullivan <california.l.sullivan@intel.com> wrote:
=20 =20 =20
Looking at the test and the output, its expecting /dev/sda3 to be mounted as /media and /dev/sda4 to be mounted as /mnt. With this test result, there is no /media, and instead /dev/sda3 is mounted to /mnt.

That seems odd to me unless that partition either wasn't created or went entirely undetected.

I'll take a closer look, I think there's more going on = here.

Udev trigger sometimes get ignored have seem that in past=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">


---
Cal

On 02/05/2018 03:34= PM, Burton, Ross wrote:
=20
This is causing the qemu boot wic test to fail in oe-selftest:

2018-02-05 15:08:41,786 - oe-selftest - INFO - FAIL [64.639s]: test_qemu (wic.Wic)
2018-02-05 15:08:41,786 - oe-selftest - INFO - -------------------------------------------------------------------= ---
2018-02-05 15:08:41,786 - oe-selftest - INFO - Traceback (most recent call last):
=C2=A0 File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/bu= ild/meta/lib/oeqa/core/decorator/__init__.py", line 32, in wrapped_f
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/bu= ild/meta/lib/oeqa/selftest/cases/wic.py", line 58, in wrapped_f
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/bu= ild/meta/lib/oeqa/selftest/cases/wic.py", line 637, in test_qemu
=C2=A0 =C2=A0 self.assertEqual(output, '/dev/root /\r\n/dev/sda= 1 /boot\r\n/dev/sda3 /mnt')
AssertionError: '/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 /media\r\n/dev/sda4 /mnt' !=3D '/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 /mnt'
=C2=A0 /dev/root /
=C2=A0 /dev/sda1 /boot
- /dev/sda3 /media
- /dev/sda4 /mnt? =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
+ /dev/sda3 /mnt? =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^

Presumably this is the initramfs mounting more stuff automatically?=C2=A0 I don't have an opinion right now as to wh= ether this is a problem with the initramfs or the test case being too strict...

Ross


On 1 February 2018 at 14:03, Burton, Ross <ross.burton@intel.com> wrote:
Sorry, missed this.=C2=A0 I'll pull it into MUT and throw it at the autobuilder...

Ross

On 31 January 2018 at 22:53, Cal Sullivan <california.l.sullivan@intel.com>= ; wrote:
Ping.

---
Cal


On 01/09/2018 05:00 PM, Cal Sullivan wrote:
Anything wrong with this? Haven't seen it hit any mut branches.

Thanks,
Cal

On 12/19/2017 02:12 PM, California Sullivan wrote:
initramfs-framework is more modular and expandable. This change was
proposed in commit 28fc6ba761ed4a47efa7c43e7f7dff5e2fe72b5e
"core-image-minimal-initramfs: use initramfs-framework by default" but
reverted due to the selftests runqemu.RunqemuTests.test_boot_machine_iso and runqemu.RunqemuTests.test_boot_deploy_hdd= img failing. Since then,
the kinks have been worked out, and missing functionality that had been
missed (non-EFI installation module) has been added.

Since the PACKAGE_INSTALL variable was getting so long with all these
individual modules getting added, I also introduced a new
INITRAMFS_SCRIPTS variable to the core-image-minimal-initramfs recipe.
This variable makes the recipe look much cleaner, and also allows easier
replacement or additions to the scripts.

Fixes [YOCTO #10987].

Signed-off-by: California Sullivan <california.l= .sullivan@intel.com>
---
=C2=A0 meta/recipes-core/images/= core-image-minimal-initramfs.bb | 10 +++++++++-
=C2=A0 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-= image-minimal-initramfs.bb
index 5794a25952a..a9ba91bd310 100644
--- a/meta/recipes-core/images/c= ore-image-minimal-initramfs.bb
+++ b/meta/recipes-core/images/c= ore-image-minimal-initramfs.bb
@@ -3,7 +3,15 @@ DESCRIPTION =3D "Small image capable of booting a device. The kernel includes \
=C2=A0 the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \
=C2=A0 first 'init' program more effi= ciently."
=C2=A0 -PACKAGE_INSTALL =3D "initramfs-l= ive-boot initramfs-live-install initramfs-live-install-efi ${VIRTUAL-RUNTIME_base-utils} udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"=
+INITRAMFS_SCRIPTS ?=3D "\
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 initramfs-framework-base \
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 initramfs-module-setup-live \
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 initramfs-module-udev \
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 initramfs-module-install \
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 initramfs-module-install-efi \
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 "
+
+PACKAGE_INSTALL =3D "${INITRAMFS_SCRIPT= S} ${VIRTUAL-RUNTIME_base-utils} udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"=
=C2=A0 =C2=A0 # Do not pollute the initrd ima= ge with rootfs features
=C2=A0 IMAGE_FEATURES =3D ""


--
_______________________________________________ Openembedded-core mailing list
Openembedded-core@lists.openembedded.org http://lis= ts.openembedded.org/mailman/listinfo/openembedded-core



--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailma= n/listinfo/openembedded-core
--94eb2c19d500bbf1e9056480859e--