All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-networking][PATCH] openl2tp: update systemd service file
Date: Wed, 18 Dec 2019 19:23:44 -0800	[thread overview]
Message-ID: <CAMKF1spBRVYnnQLVXnN5ciT1SwXEvhQn1pV-rQbRUcorRKLBTA@mail.gmail.com> (raw)
In-Reply-To: <20191219031617.8339-1-kai.kang@windriver.com>

On Wed, Dec 18, 2019 at 7:16 PM <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> It shows an warning of openl2tp in systemd log:
>
> | /lib/systemd/system/openl2tpd.service:8: PIDFile= references a path
> | below legacy directory /var/run/, updating /var/run/openl2tpd.pid →
> | /run/openl2tpd.pid; please update the unit file accordingly.
>
> Update the systemd service file to fix the warning.
>
> Update SRC_URI as well that the homepage openl2tp.org has been closed.
> Use archived file on sourceforge instead.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  .../recipes-protocols/openl2tp/openl2tp/openl2tpd.service       | 2 +-
>  meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> index 7b3faf672..d02d0ff7e 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp/openl2tpd.service
> @@ -5,7 +5,7 @@ Requires=rpcbind.service
>
>  [Service]
>  Type=forking
> -PIDFile=@STATEDIR@/run/openl2tpd.pid
> +PIDFile=/run/openl2tpd.pid
>  EnvironmentFile=@SYSCONFDIR@/default/openl2tpd
>  ExecStartPre=@BASE_BINDIR@/sh -c "@BASE_SBINDIR@/modprobe -sq l2tp_ppp || @BASE_SBINDIR@/modprobe -sq pppol2tp"
>  ExecStart=@SBINDIR@/openl2tpd $OPENL2TPDARGS
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> index 90e8b111d..38d0554e1 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=e9d9259cbbf00945adc25a470c1d3585 \
>
>  DEPENDS = "popt flex readline rpcsvc-proto-native bison-native"
>
> -SRC_URI = "ftp://ftp.openl2tp.org/releases/${BP}/${BP}.tar.gz \
> +SRC_URI = "https://sourceforge.net/projects/openl2tp/files/openl2tp/${PV}/${BP}.tar.gz \

Can we use SOURCEFORGE_MIRROR

>             file://Makefile-modify-CFLAGS-to-aviod-build-error.patch \
>             file://openl2tp-simplify-gcc-warning-hack.patch \
>             file://Makefile-obey-LDFLAGS.patch \
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


  reply	other threads:[~2019-12-19  3:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19  3:16 [meta-networking][PATCH] openl2tp: update systemd service file kai.kang
2019-12-19  3:23 ` Khem Raj [this message]
2019-12-19  3:23   ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1spBRVYnnQLVXnN5ciT1SwXEvhQn1pV-rQbRUcorRKLBTA@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.