All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH] meta-arm-toolchain: Convert to new override syntax
Date: Mon, 2 Aug 2021 22:49:08 -0700	[thread overview]
Message-ID: <CAMKF1spBw8ExPHs6i00ScBViOGSDHWoeS63k+Sixwg4v+BKcDw@mail.gmail.com> (raw)
In-Reply-To: <CAFA6WYODdz23qfQVWFNb5NFb5EmNv4s_fv4sf9jcGsxOHPWe3Q@mail.gmail.com>

yeah ignore this. I have more changes after this

On Mon, Aug 2, 2021 at 10:25 PM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> Hi Khem,
>
> On Mon, 2 Aug 2021 at 22:05, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-arm-toolchain/conf/layer.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
> > index 04486d4..41305ee 100644
> > --- a/meta-arm-toolchain/conf/layer.conf
> > +++ b/meta-arm-toolchain/conf/layer.conf
> > @@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
> >  BB_DANGLINGAPPENDS_WARNONLY = "true"
> >
> >  # These variables are used for armcompiler license
> > -BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
> > +BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
>
> This only looks like change for one instance of override and there are
> many other instances in meta-arm-toolchain. I think the new override
> syntax brings more clarity. So I would suggest converting all other
> instances of overrides to new syntax as well.
>
> -Sumit
>
> > --
> > 2.32.0
> >
> >
> > 
> >

      reply	other threads:[~2021-08-03  5:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 16:35 [PATCH] meta-arm-toolchain: Convert to new override syntax Khem Raj
2021-08-03  5:25 ` [meta-arm] " Sumit Garg
2021-08-03  5:49   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1spBw8ExPHs6i00ScBViOGSDHWoeS63k+Sixwg4v+BKcDw@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=meta-arm@lists.yoctoproject.org \
    --cc=sumit.garg@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.