From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by mx.groups.io with SMTP id smtpd.web12.8940.1610223383263589304 for ; Sat, 09 Jan 2021 12:16:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Vxr6k3+5; spf=pass (domain: gmail.com, ip: 209.85.219.52, mailfrom: raj.khem@gmail.com) Received: by mail-qv1-f52.google.com with SMTP id p5so5898218qvs.7 for ; Sat, 09 Jan 2021 12:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8bVPPjWXDOHyyiE1kc78y9eBgnF1j7d2SM4vxsJBHFI=; b=Vxr6k3+5SFBHLGOHEPxOhH6er1sPs9sfQFDCwJaoV4CcOyIZuG/R1KKXejJsW107rZ B6lHvOrsmQRYvCFCkXVRsl56W+isoMVvkh+w6ibodksLQn4KgbJZ9lV2Q+8OLbNijlYJ +UAU8vLifju72YK0YUy2DMzjiXFB9xhjz1U/KdBk/C8pEBCHLdTcTZVZuaYy8eKJkx4S l9nGWuOdfDqUCFgoZgxAxhwK0Jx9eLnYGOeSIbNc1QQLy8S6Om/CC5Dwd0QMQ5cvOfsN awe4z0q9+pnMbE4Cs+pDVN3Rpk5os554Ta9F6fCdqEXdIQCZ25sqvzRcLVvDqi4irHIE INcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8bVPPjWXDOHyyiE1kc78y9eBgnF1j7d2SM4vxsJBHFI=; b=ZARrm8KyOJAN3X/g8ipHzRQsujfnNN1UH6km4h2/Ny518DCTNZH3rarx4hYJvKHzNt VM9QOm6najwqPQk7u0qPoEhk+1GcwGMfTLDdl8m7ycTbrhulNI+mKyHIgt7mimYgxNhJ J+XmOPmNK9+nRvIQGOF920Z7lPA+pTk3bPLoL4Sh+c21GCgQFt6zGcWs4/WSy8WLMYzy LCtq5twjssHGoLUgWjSKb9gX6VdIN0Z1rZfJAn8OSOR8KzJRXGFiU9d0leTvdaPpTLCr S4y0flVdssSB62vy2QVp/8hFXbpnSwXVv5c20TwHKStFC/jIlW0NK51iBiV3d/7NG1nv ymSA== X-Gm-Message-State: AOAM533CjC7q5Dr7TV/Tr6Fi0SvlmAXQOv+OpwzgQbCkKPB9Ch03NXW+ 3dPn/BnkSsuLc4UYIkp7l1DmwZs+M9/GU40+e3E= X-Google-Smtp-Source: ABdhPJwROlFfZ5i3CK1rcAfE/P2SSYC9aWZMW8keX74WtfP4YUd/WQxvKtMRo+dg8K3XkFq0SL7L2zBg5B8giQhdo+g= X-Received: by 2002:a0c:ea34:: with SMTP id t20mr9369619qvp.5.1610223382288; Sat, 09 Jan 2021 12:16:22 -0800 (PST) MIME-Version: 1.0 References: <20201224065952.3714857-1-raj.khem@gmail.com> In-Reply-To: From: "Khem Raj" Date: Sat, 9 Jan 2021 12:16:11 -0800 Message-ID: Subject: Re: [meta-oe][PATCH v3] beep: Update to 1.4.9 in new repository To: Mark Jonas Cc: openembeded-devel Content-Type: multipart/alternative; boundary="000000000000b5dc0005b87d588e" --000000000000b5dc0005b87d588e Content-Type: text/plain; charset="UTF-8" On Sat, Jan 9, 2021 at 11:12 AM Mark Jonas wrote: > Hi Khem, > > > This patch itself should be first upstreamed > > I had some doubts that removing -Werror would find love upstream. > That's why I started investigating which warning caused the > compilation to break. And then I realized that the upstream already > compiles just fine with Clang 11 from https://apt.llvm.org/ on Ubuntu > 20.04. > > Additionally, the removal of > ifneq ($(call pathsearch,$(COMPILER_clang)),) > breaks the use of make without additional parameters and > auto-detection of the installed compilers. That's what I experienced > on Ubuntu with gcc before installing clang. It will compile fine for native builds because it does not consider cross compiling this patch mainly makes it use compiler from environment firstly Because I might have gcc and clang installed on my build host but only have clang cross compiler and no gcc cross compiler it will break in such cases Warnings happen because it then tries to use gcc specific options which clang rejects and warns as unknown options > > > > On Sat, Jan 9, 2021 at 9:02 AM Mark Jonas wrote: > >> > >> Hi Khem, > >> > >> I wanted to create a patch for beep's mainline so it could be used in > >> meta-openembedded without your patch. That is, what hinders > >> compilation with Clang 11 and -Werror. To my astonishment the > >> unmodified beep v1.4.9 compiles just fine with clang-11 from > >> https://apt.llvm.org/ on Ubuntu 20.04. And it definitely fails when > >> building with meta-clang without your patch. > >> > >> What is the difference between the two Clangs? > >> > >> I have to admit that this is the first time I used clang. > >> > >> $ clang-11 --version > >> Ubuntu clang version > >> 11.0.1-++20201218093155+43ff75f2c3fe-1~exp1~20201218203809.158 > >> Target: x86_64-pc-linux-gnu > >> Thread model: posix > >> InstalledDir: /usr/bin > >> > >> $ make COMPILER_gcc=no COMPILER_clang=clang-11 LINKER_clang=clang-11 > >> /bin/sed -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION@/1.4.9/g > >> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e > >> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/beep|g' < > >> beep-config.h.in > beep-config.h.new > >> mv -f beep-config.h.new beep-config.h > >> clang-11 -MT beep-main.clang-o -MMD -MP -MF > >> .deps/beep-main.clang-o.dep -DPACKAGE_TARNAME='"beep"' > >> -DPACKAGE_VERSION='"1.4.9"' -Wall -Wextra -Weverything -Wno-padded > >> -std=gnu99 -pedantic -Werror -fsanitize=undefined -O -g -o > >> beep-main.clang-o -c beep-main.c > >> /bin/sed -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION@/1.4.9/g > >> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e > >> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/beep|g' < > >> beep-usage.txt.in > beep-usage.txt.new > >> mv -f beep-usage.txt.new beep-usage.txt > >> echo '/* Auto-generated from `beep-usage.txt`. Modify that file > >> instead. */' > beep-usage.c > >> echo '#include "beep-usage.h"' >> beep-usage.c > >> echo 'char beep_usage[] =' >> beep-usage.c > >> set -e; IFS=""; while read line; do \ > >> printf ' "%s\\n"\n' "${line}" >> beep-usage.c; \ > >> done < beep-usage.txt > >> echo ' ;' >> beep-usage.c > >> clang-11 -MT beep-usage.clang-o -MMD -MP -MF > >> .deps/beep-usage.clang-o.dep -DPACKAGE_TARNAME='"beep"' > >> -DPACKAGE_VERSION='"1.4.9"' -Wall -Wextra -Weverything -Wno-padded > >> -std=gnu99 -pedantic -Werror -fsanitize=undefined -O -g -o > >> beep-usage.clang-o -c beep-usage.c > >> clang-11 -Wall -Wextra -Weverything -Wno-padded -std=gnu99 -pedantic > >> -Werror -fsanitize=undefined -O -g -o beep.clang beep-log.clang-o > >> beep-main.clang-o beep-library.clang-o beep-usage.clang-o > >> beep-drivers.clang-o beep-driver-console.clang-o > >> beep-driver-evdev.clang-o > >> cp -f beep.clang beep > >> /bin/sed -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION@/1.4.9/g > >> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e > >> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/beep|g' < > >> beep.1.in > beep.1.new > >> mv -f beep.1.new beep.1 > >> > >> Cheers, > >> Mark > >> > >> On Thu, Dec 24, 2020 at 7:59 AM Khem Raj wrote: > >> > > >> > From: Mark Jonas > >> > > >> > The previous version 1.2.2 of beep was provided by > >> > http://johnath.com/beep and was released in 2002. The latest version > 1.3 > >> > was released 2010-07-13. On https://github.com/johnath/beep the > >> > development stopped 2013-02-07. > >> > > >> > In 2018 a developer worked on fixing CVE-2018-1000532 and realized > that > >> > fixing this would be more than just a simple patch. Because the > original > >> > repository was unmaintained for several years he created > >> > https://github.com/spkr-beep/beep as the new home for beep. > >> > > >> > Debian switched to the new beep with Buster. > >> > https://packages.debian.org/buster/beep > >> > > >> > Alpine 3.11, Arch Linux, Fedora, and Ubuntu 20.04 also switched to the > >> > same new beep. > >> > > >> > Fix build with clang > >> > > >> > Signed-off-by: Mark Jonas > >> > Signed-off-by: Khem Raj > >> > --- > >> > v2: Fix build with clang > >> > v3: Do not build with both clang and gcc > >> > > >> > meta-oe/recipes-extended/beep/beep_1.2.2.bb | 25 -------- > >> > meta-oe/recipes-extended/beep/beep_1.4.9.bb | 32 ++++++++++ > >> > ...rror-as-it-fails-with-newer-clang-11.patch | 63 > +++++++++++++++++++ > >> > 3 files changed, 95 insertions(+), 25 deletions(-) > >> > delete mode 100644 meta-oe/recipes-extended/beep/beep_1.2.2.bb > >> > create mode 100644 meta-oe/recipes-extended/beep/beep_1.4.9.bb > >> > create mode 100644 > meta-oe/recipes-extended/beep/files/0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch > >> > > >> > diff --git a/meta-oe/recipes-extended/beep/beep_1.2.2.bb > b/meta-oe/recipes-extended/beep/beep_1.2.2.bb > >> > deleted file mode 100644 > >> > index cafc869645..0000000000 > >> > --- a/meta-oe/recipes-extended/beep/beep_1.2.2.bb > >> > +++ /dev/null > >> > @@ -1,25 +0,0 @@ > >> > -DESCRIPTION = "beep is a command line tool for linux that beeps the > PC speaker" > >> > -LICENSE = "GPL-2.0" > >> > -LIC_FILES_CHKSUM = > "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" > >> > - > >> > -SRC_URI = "\ > >> > - http://johnath.com/beep/beep-${PV}.tar.gz \ > >> > - file://linux-input.patch \ > >> > -" > >> > - > >> > -SRC_URI[sha256sum] = > "5c0445dac43950b7c7c3f235c6fb21f620ab3fd2f3aafaf09896e5730fcf49a1" > >> > - > >> > -S = "${WORKDIR}/${BPN}-${PV}" > >> > - > >> > -EXTRA_OEMAKE += 'CC="${CC}"' > >> > -EXTRA_OEMAKE += 'FLAGS="${CFLAGS} ${LDFLAGS}"' > >> > - > >> > -do_configure[noexec] = "1" > >> > - > >> > -do_compile() { > >> > - oe_runmake > >> > -} > >> > - > >> > -do_install() { > >> > - install -Dm 0755 ${B}/${PN} ${D}${bindir}/${PN} > >> > -} > >> > diff --git a/meta-oe/recipes-extended/beep/beep_1.4.9.bb > b/meta-oe/recipes-extended/beep/beep_1.4.9.bb > >> > new file mode 100644 > >> > index 0000000000..8d332b2faf > >> > --- /dev/null > >> > +++ b/meta-oe/recipes-extended/beep/beep_1.4.9.bb > >> > @@ -0,0 +1,32 @@ > >> > +SUMMARY = "beep allows you to have the PC speaker issue beeps and > beep patterns" > >> > +DESCRIPTION = "beep allows you to have the PC speaker issue beeps > and beep \ > >> > +patterns with given frequencies, durations, and spacing." > >> > +HOMEPAGE = "https://github.com/spkr-beep/beep" > >> > +BUGTRACKER = "https://github.com/spkr-beep/beep/issues" > >> > + > >> > +LICENSE = "GPLv2+" > >> > +LIC_FILES_CHKSUM = > "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" > >> > + > >> > +SRC_URI = "git://github.com/spkr-beep/beep.git;protocol=https \ > >> > + > file://0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch \ > >> > +" > >> > +SRCREV = "8b85ddd09f73b9fd7caa5679298781a57af194ac" > >> > +S = "${WORKDIR}/git" > >> > + > >> > +EXTRA_OEMAKE = " \ > >> > + COMPILER_gcc='${CC}' \ > >> > + LINKER_gcc='${CC}' \ > >> > + COMPILER_clang=no \ > >> > + LINKER_clang=no \ > >> > +" > >> > + > >> > +EXTRA_OEMAKE_toolchain-clang = " \ > >> > + COMPILER_clang='${CC}' \ > >> > + LINKER_clang='${CC}' \ > >> > + COMPILER_gcc=no \ > >> > + LINKER_gcc=no \ > >> > +" > >> > + > >> > +do_install() { > >> > + oe_runmake install DESTDIR='${D}' > >> > +} > >> > diff --git > a/meta-oe/recipes-extended/beep/files/0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch > b/meta-oe/recipes-extended/beep/files/0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch > >> > new file mode 100644 > >> > index 0000000000..ba7681b983 > >> > --- /dev/null > >> > +++ > b/meta-oe/recipes-extended/beep/files/0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch > >> > @@ -0,0 +1,63 @@ > >> > +From 6b33adfa438e35b6a37cfb0364274370ef4f9fc1 Mon Sep 17 00:00:00 > 2001 > >> > +From: Khem Raj > >> > +Date: Wed, 23 Dec 2020 18:00:59 +0000 > >> > +Subject: [PATCH] Do not use -Werror as it fails with newer clang 11+ > >> > + > >> > +Upstream-Status: Pending > >> > +Signed-off-by: Khem Raj > >> > +--- > >> > + GNUmakefile | 1 - > >> > + 1 file changed, 1 deletion(-) > >> > + > >> > +--- a/GNUmakefile > >> > ++++ b/GNUmakefile > >> > +@@ -91,12 +91,13 @@ comma := , > >> > + # If supported by COMPILER_gcc, add given flags to CFLAGS_gcc. > >> > + # Example usage: > >> > + # $(eval $(call CHECK_CFLAGS_gcc,-fasynchronous-unwind-tables)) > >> > +-define CHECK_CFLAGS_gcc > >> > +-CFLAGS_gcc += $$(if $$(shell if $$(COMPILER_gcc) $(1) -x c -o > compile-check.gcc-o -c - < /dev/null > /dev/null 2>&1; then echo yes; else > :; fi; rm -f compile-check.gcc-o > /dev/null 2>&1),$(1)) > >> > +-endef > >> > + > >> > + COMPILER_gcc = gcc > >> > + LINKER_gcc = gcc > >> > ++ifneq ($(COMPILER_gcc),no) > >> > ++define CHECK_CFLAGS_gcc > >> > ++CFLAGS_gcc += $$(if $$(shell if $$(COMPILER_gcc) $(1) -x c -o > compile-check.gcc-o -c - < /dev/null > /dev/null 2>&1; then echo yes; else > :; fi; rm -f compile-check.gcc-o > /dev/null 2>&1),$(1)) > >> > ++endef > >> > + CPPFLAGS_gcc = > >> > + CFLAGS_gcc = > >> > + CFLAGS_gcc += -std=gnu99 -pedantic > >> > +@@ -113,30 +114,24 @@ CFLAGS_gcc += -save-temps=obj > >> > + LDFLAGS_gcc = > >> > + LIBS_gcc = > >> > + > >> > +-ifneq ($(call pathsearch,$(COMPILER_gcc)),) > >> > +-ifneq ($(COMPILER_gcc)),no) > >> > + COMPILERS += gcc > >> > + endif > >> > +-endif > >> > + > >> > + COMPILER_clang = clang > >> > + LINKER_clang = clang > >> > ++ > >> > ++ifneq ($(COMPILER_clang),no) > >> > + CPPFLAGS_clang = > >> > + CFLAGS_clang += -Wall -Wextra > >> > + CFLAGS_clang += -Weverything > >> > + CFLAGS_clang += -Wno-padded > >> > + CFLAGS_clang += -std=gnu99 -pedantic > >> > +-CFLAGS_clang += -Werror > >> > +-CFLAGS_clang += -fsanitize=undefined > >> > + CFLAGS_clang += -O -g > >> > + LDFLAGS_clang = > >> > + LIBS_clang = > >> > + > >> > +-ifneq ($(call pathsearch,$(COMPILER_clang)),) > >> > +-ifneq ($(COMPILER_clang),no) > >> > + COMPILERS += clang > >> > + endif > >> > +-endif > >> > + > >> > + > >> > + > ######################################################################## > >> > -- > >> > 2.29.2 > >> > > --000000000000b5dc0005b87d588e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Jan 9, 2021 at 11:12 AM Mark Jonas <toertel@gmail.com> wrote:
Hi Khem,

> This patch itself should be first upstreamed

I had some doubts that removing -Werror would find love upstream.
That's why I started investigating which warning caused the
compilation to break. And then I realized that the upstream already
compiles just fine with Clang 11 from https://apt.llvm.org/ on Ubuntu
20.04.

Additionally, the removal of
=C2=A0 =C2=A0 ifneq ($(call pathsearch,$(COMPILER_clang)),)
breaks the use of make without additional parameters and
auto-detection of the installed compilers. That's what I experienced on Ubuntu with gcc before installing clang.
<= br>

It will compile fine= for native builds because it does not consider cross compiling this patch = mainly makes it use compiler from environment firstly

Because I might have gcc and clang installed = on my build host but only have clang cross compiler and no gcc cross compil= er it will break in such cases

Warnings happen because it then tries to use gcc specific options wh= ich clang rejects and warns as unknown options=C2=A0


> On Sat, Jan 9, 2021 at 9:02 AM Mark Jonas <toertel@gmail.com> wrote:
>>
>> Hi Khem,
>>
>> I wanted to create a patch for beep's mainline so it could be = used in
>> meta-openembedded without your patch. That is, what hinders
>> compilation with Clang 11 and -Werror. To my astonishment the
>> unmodified beep v1.4.9 compiles just fine with clang-11 from
>> https://apt.llvm.org/ on Ubuntu 20.04. And it definitely fails whe= n
>> building with meta-clang without your patch.
>>
>> What is the difference between the two Clangs?
>>
>> I have to admit that this is the first time I used clang.
>>
>> $ clang-11 --version
>> Ubuntu clang version
>> 11.0.1-++20201218093155+43ff75f2c3fe-1~exp1~20201218203809.158
>> Target: x86_64-pc-linux-gnu
>> Thread model: posix
>> InstalledDir: /usr/bin
>>
>> $ make COMPILER_gcc=3Dno COMPILER_clang=3Dclang-11 LINKER_clang=3D= clang-11
>> /bin/sed=C2=A0 -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION= @/1.4.9/g
>> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e
>> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/bee= p|g' <
>> beep-config.h.in > beep-config.h.new
>> mv -f beep-config.h.new beep-config.h
>> clang-11 -MT beep-main.clang-o -MMD -MP -MF
>> .deps/beep-main.clang-o.dep=C2=A0 =C2=A0-DPACKAGE_TARNAME=3D'&= quot;beep"'
>> -DPACKAGE_VERSION=3D'"1.4.9"'=C2=A0 =C2=A0 -Wall= -Wextra -Weverything -Wno-padded
>> -std=3Dgnu99 -pedantic -Werror -fsanitize=3Dundefined -O -g -o
>> beep-main.clang-o -c beep-main.c
>> /bin/sed=C2=A0 -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION= @/1.4.9/g
>> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e
>> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/bee= p|g' <
>> beep-usage.txt.in > beep-usage.txt.new
>> mv -f beep-usage.txt.new beep-usage.txt
>> echo '/* Auto-generated from `beep-usage.txt`. Modify that fil= e
>> instead. */' > beep-usage.c
>> echo '#include "beep-usage.h"' >> beep-usa= ge.c
>> echo 'char beep_usage[] =3D' >> beep-usage.c
>> set -e; IFS=3D""; while read line; do \
>>=C2=A0 =C2=A0 =C2=A0printf '=C2=A0 "%s\\n"\n' &qu= ot;${line}" >> beep-usage.c; \
>> done < beep-usage.txt
>> echo '=C2=A0 ;' >> beep-usage.c
>> clang-11 -MT beep-usage.clang-o -MMD -MP -MF
>> .deps/beep-usage.clang-o.dep=C2=A0 =C2=A0-DPACKAGE_TARNAME=3D'= "beep"'
>> -DPACKAGE_VERSION=3D'"1.4.9"'=C2=A0 =C2=A0 -Wall= -Wextra -Weverything -Wno-padded
>> -std=3Dgnu99 -pedantic -Werror -fsanitize=3Dundefined -O -g -o
>> beep-usage.clang-o -c beep-usage.c
>> clang-11=C2=A0 -Wall -Wextra -Weverything -Wno-padded -std=3Dgnu99= -pedantic
>> -Werror -fsanitize=3Dundefined -O -g=C2=A0 =C2=A0-o beep.clang bee= p-log.clang-o
>> beep-main.clang-o beep-library.clang-o beep-usage.clang-o
>> beep-drivers.clang-o beep-driver-console.clang-o
>> beep-driver-evdev.clang-o
>> cp -f beep.clang beep
>> /bin/sed=C2=A0 -e s/@PACKAGE_TARNAME@/beep/g -e s/@PACKAGE_VERSION= @/1.4.9/g
>> -e s/@DEFAULT_FREQ@/440/g -e s/@DEFAULT_LENGTH@/200/g -e
>> s/@DEFAULT_DELAY@/100/g -e 's|[@]pkgdocdir@|/usr/share/doc/bee= p|g' <
>> = beep.1.in > beep.1.new
>> mv -f beep.1.new beep.1
>>
>> Cheers,
>> Mark
>>
>> On Thu, Dec 24, 2020 at 7:59 AM Khem Raj <raj.khem@gmail.com> wrote:
>> >
>> > From: Mark Jonas <toertel@gmail.com>
>> >
>> > The previous version 1.2.2 of beep was provided by
>> > http://johnath.com/beep and was released in 2002. The lates= t version 1.3
>> > was released 2010-07-13. On https://github.com/johnath/= beep the
>> > development stopped 2013-02-07.
>> >
>> > In 2018 a developer worked on fixing CVE-2018-1000532 and rea= lized that
>> > fixing this would be more than just a simple patch. Because t= he original
>> > repository was unmaintained for several years he created
>> > https://github.com/spkr-beep/beep as the new home= for beep.
>> >
>> > Debian switched to the new beep with Buster.
>> >=C2=A0 =C2=A0 =C2=A0https://packages.debian.org/= buster/beep
>> >
>> > Alpine 3.11, Arch Linux, Fedora, and Ubuntu 20.04 also switch= ed to the
>> > same new beep.
>> >
>> > Fix build with clang
>> >
>> > Signed-off-by: Mark Jonas <toertel@gmail.com>
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> > v2: Fix build with clang
>> > v3: Do not build with both clang and gcc
>> >
>> >=C2=A0 meta-oe/recipes-extended/beep/beep_1.2.2.bb=C2=A0 =C2=A0= | 25 --------
>> >=C2=A0 meta-oe/recipes-extended/beep/beep_1.4.9.bb=C2=A0 =C2=A0= | 32 ++++++++++
>> >=C2=A0 ...rror-as-it-fails-with-newer-clang-11.patch | 63 ++++= +++++++++++++++
>> >=C2=A0 3 files changed, 95 insertions(+), 25 deletions(-)
>> >=C2=A0 delete mode 100644 meta-oe/recipes-extended/beep/beep_1.2.2.= bb
>> >=C2=A0 create mode 100644 meta-oe/recipes-extended/beep/beep_1.4.9.= bb
>> >=C2=A0 create mode 100644 meta-oe/recipes-extended/beep/files/= 0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch
>> >
>> > diff --git a/meta-oe/recipes-extended/beep/beep_1.2.2.bb b/met= a-oe/recipes-extended/beep/beep_1.2.2.bb
>> > deleted file mode 100644
>> > index cafc869645..0000000000
>> > --- a/meta-oe/recipes-extended/beep/beep_1.2.2.bb
>> > +++ /dev/null
>> > @@ -1,25 +0,0 @@
>> > -DESCRIPTION =3D "beep is a command line tool for linux = that beeps the PC speaker"
>> > -LICENSE =3D "GPL-2.0"
>> > -LIC_FILES_CHKSUM =3D "file://COPYING;md5=3D0636e73ff021= 5e8d672dc4c32c317bb3"
>> > -
>> > -SRC_URI =3D "\
>> > -=C2=A0 =C2=A0 http://johnath.com/beep/be= ep-${PV}.tar.gz \
>> > -=C2=A0 =C2=A0 file://linux-input.patch \
>> > -"
>> > -
>> > -SRC_URI[sha256sum] =3D "5c0445dac43950b7c7c3f235c6fb21f= 620ab3fd2f3aafaf09896e5730fcf49a1"
>> > -
>> > -S =3D "${WORKDIR}/${BPN}-${PV}"
>> > -
>> > -EXTRA_OEMAKE +=3D 'CC=3D"${CC}"'
>> > -EXTRA_OEMAKE +=3D 'FLAGS=3D"${CFLAGS} ${LDFLAGS}&qu= ot;'
>> > -
>> > -do_configure[noexec] =3D "1"
>> > -
>> > -do_compile() {
>> > -=C2=A0 =C2=A0oe_runmake
>> > -}
>> > -
>> > -do_install() {
>> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm 0755 ${B}/${PN} ${D}$= {bindir}/${PN}
>> > -}
>> > diff --git a/meta-oe/recipes-extended/beep/beep_1.4.9.bb b/met= a-oe/recipes-extended/beep/beep_1.4.9.bb
>> > new file mode 100644
>> > index 0000000000..8d332b2faf
>> > --- /dev/null
>> > +++ b/meta-oe/recipes-extended/beep/beep_1.4.9.bb
>> > @@ -0,0 +1,32 @@
>> > +SUMMARY =3D "beep allows you to have the PC speaker iss= ue beeps and beep patterns"
>> > +DESCRIPTION =3D "beep allows you to have the PC speaker= issue beeps and beep \
>> > +patterns with given frequencies, durations, and spacing.&quo= t;
>> > +HOMEPAGE =3D "https://github.com/spkr-beep/beep= "
>> > +BUGTRACKER =3D "https://github.com/spkr-= beep/beep/issues"
>> > +
>> > +LICENSE =3D "GPLv2+"
>> > +LIC_FILES_CHKSUM =3D "file://COPYING;md5=3Db234ee4d69f5= fce4486a80fdaf4a4263"
>> > +
>> > +SRC_URI =3D "git://github.c= om/spkr-beep/beep.git;protocol=3Dhttps \
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://0001-Do-not-= use-Werror-as-it-fails-with-newer-clang-11.patch \
>> > +"
>> > +SRCREV =3D "8b85ddd09f73b9fd7caa5679298781a57af194ac&qu= ot;
>> > +S =3D "${WORKDIR}/git"
>> > +
>> > +EXTRA_OEMAKE =3D " \
>> > +=C2=A0 =C2=A0 COMPILER_gcc=3D'${CC}' \
>> > +=C2=A0 =C2=A0 LINKER_gcc=3D'${CC}' \
>> > +=C2=A0 =C2=A0 COMPILER_clang=3Dno \
>> > +=C2=A0 =C2=A0 LINKER_clang=3Dno \
>> > +"
>> > +
>> > +EXTRA_OEMAKE_toolchain-clang =3D " \
>> > +=C2=A0 =C2=A0 COMPILER_clang=3D'${CC}' \
>> > +=C2=A0 =C2=A0 LINKER_clang=3D'${CC}' \
>> > +=C2=A0 =C2=A0 COMPILER_gcc=3Dno \
>> > +=C2=A0 =C2=A0 LINKER_gcc=3Dno \
>> > +"
>> > +
>> > +do_install() {
>> > +=C2=A0 =C2=A0 oe_runmake install DESTDIR=3D'${D}' >> > +}
>> > diff --git a/meta-oe/recipes-extended/beep/files/0001-Do-not-= use-Werror-as-it-fails-with-newer-clang-11.patch b/meta-oe/recipes-extended= /beep/files/0001-Do-not-use-Werror-as-it-fails-with-newer-clang-11.patch >> > new file mode 100644
>> > index 0000000000..ba7681b983
>> > --- /dev/null
>> > +++ b/meta-oe/recipes-extended/beep/files/0001-Do-not-use-Wer= ror-as-it-fails-with-newer-clang-11.patch
>> > @@ -0,0 +1,63 @@
>> > +From 6b33adfa438e35b6a37cfb0364274370ef4f9fc1 Mon Sep 17 00:= 00:00 2001
>> > +From: Khem Raj <raj.khem@gmail.com>
>> > +Date: Wed, 23 Dec 2020 18:00:59 +0000
>> > +Subject: [PATCH] Do not use -Werror as it fails with newer c= lang 11+
>> > +
>> > +Upstream-Status: Pending
>> > +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > +---
>> > + GNUmakefile | 1 -
>> > + 1 file changed, 1 deletion(-)
>> > +
>> > +--- a/GNUmakefile
>> > ++++ b/GNUmakefile
>> > +@@ -91,12 +91,13 @@ comma :=3D ,
>> > + # If supported by COMPILER_gcc, add given flags to CFLAGS_g= cc.
>> > + # Example usage:
>> > + #=C2=A0 =C2=A0$(eval $(call CHECK_CFLAGS_gcc,-fasynchronous= -unwind-tables))
>> > +-define CHECK_CFLAGS_gcc
>> > +-CFLAGS_gcc +=3D $$(if $$(shell if $$(COMPILER_gcc) $(1) -x = c -o compile-check.gcc-o -c - < /dev/null > /dev/null 2>&1; th= en echo yes; else :; fi; rm -f compile-check.gcc-o > /dev/null 2>&= ;1),$(1))
>> > +-endef
>> > +
>> > + COMPILER_gcc =3D gcc
>> > + LINKER_gcc =3D gcc
>> > ++ifneq ($(COMPILER_gcc),no)
>> > ++define CHECK_CFLAGS_gcc
>> > ++CFLAGS_gcc +=3D $$(if $$(shell if $$(COMPILER_gcc) $(1) -x = c -o compile-check.gcc-o -c - < /dev/null > /dev/null 2>&1; th= en echo yes; else :; fi; rm -f compile-check.gcc-o > /dev/null 2>&= ;1),$(1))
>> > ++endef
>> > + CPPFLAGS_gcc =3D
>> > + CFLAGS_gcc =3D
>> > + CFLAGS_gcc +=3D -std=3Dgnu99 -pedantic
>> > +@@ -113,30 +114,24 @@ CFLAGS_gcc +=3D -save-temps=3Dobj
>> > + LDFLAGS_gcc =3D
>> > + LIBS_gcc =3D
>> > +
>> > +-ifneq ($(call pathsearch,$(COMPILER_gcc)),)
>> > +-ifneq ($(COMPILER_gcc)),no)
>> > + COMPILERS +=3D gcc
>> > + endif
>> > +-endif
>> > +
>> > + COMPILER_clang =3D clang
>> > + LINKER_clang =3D clang
>> > ++
>> > ++ifneq ($(COMPILER_clang),no)
>> > + CPPFLAGS_clang =3D
>> > + CFLAGS_clang +=3D -Wall -Wextra
>> > + CFLAGS_clang +=3D -Weverything
>> > + CFLAGS_clang +=3D -Wno-padded
>> > + CFLAGS_clang +=3D -std=3Dgnu99 -pedantic
>> > +-CFLAGS_clang +=3D -Werror
>> > +-CFLAGS_clang +=3D -fsanitize=3Dundefined
>> > + CFLAGS_clang +=3D -O -g
>> > + LDFLAGS_clang =3D
>> > + LIBS_clang =3D
>> > +
>> > +-ifneq ($(call pathsearch,$(COMPILER_clang)),)
>> > +-ifneq ($(COMPILER_clang),no)
>> > + COMPILERS +=3D clang
>> > + endif
>> > +-endif
>> > +
>> > +
>> > + ###########################################################= #############
>> > --
>> > 2.29.2
>> >
--000000000000b5dc0005b87d588e--