Re: [meta-oe][PATCH] abseil-cpp: add recipe for git version

[Khem Raj <raj.khem@gmail.com>]

On Sun, Feb 9, 2020 at 9:45 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> On 2/9/2020 11:56 AM, Khem Raj wrote:
> > It also fails to build on musl
> > https://errors.yoctoproject.org/Errors/Details/390527/
> >
> > On Sat, Feb 8, 2020 at 11:53 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>
> This library requires "-march=armv8-a+crypto"
>
> -fvisibility-inlines-hidden
>
> Yet, it is getting compiled with: -march=armv8-a+crc
>

This means the recipe should be checking for crypto being present in
TUNE_FEATURES
and be marked incompatible if this is not available.

mark it compatible only on architectures where
it works which it seems are only arm/x86, and on aarch64 particularly
check for CPU feature it requires
something on the lines below

python () {
    arch = d.getVar("TARGET_ARCH")

    if arch == "aarch64":
        tunes = d.getVar("TUNE_FEATURES")
        if not tunes:
            return
        pkgn = d.getVar("PN")
        pkgv = d.getVar("PV")
        if "crypto" not in tunes:
            raise bb.parse.SkipPackage("%s-%s Needs support for crypto
on armv8" % (pkgn, pkgv))
}

> What's the bet way to handle this