All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] perf: make sure that the tools/include/uapi/asm-generic directory exists
Date: Sat, 11 May 2019 07:51:46 -0700	[thread overview]
Message-ID: <CAMKF1spT7=rt=JrAqT44h7KjqAHr342Ew5SxrcPJB0EA3bXJPA@mail.gmail.com> (raw)
In-Reply-To: <20190511140824.4624-1-Martin.Jansa@gmail.com>

On Sat, May 11, 2019 at 7:08 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> * before trying to copy unistd.h into it
>
> * older kernels don't have uapi in tools/include and do_configure fails
>   with:
>   DEBUG: Executing shell function do_configure
>   cp: cannot create regular file '.../perf/1.0-r9/perf-1.0/tools/include/uapi/asm-generic/unistd.h':
>   No such file or directory
>   WARNING: exit code 1 from a shell command.
>
> * tools/include/uapi was added in kernel 4.8 with
>   https://github.com/torvalds/linux/commit/c4b6014e8bb0c8d47fe5c71ebc604f31091e5d3f
>   tools: Add copy of perf_event.h to tools/include/linux/
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-kernel/perf/perf.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 546076f84b..215d0a38f9 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -238,6 +238,7 @@ do_configure_prepend () {
>
>      # unistd.h can be out of sync between libc-headers and the captured version in the perf source
>      # so we copy it from the sysroot unistd.h to the perf unistd.h
> +    [ -d ${S}/tools/include/uapi/asm-generic/ ] || mkdir -p ${S}/tools/include/uapi/asm-generic/
>      cp ${STAGING_INCDIR}/asm-generic/unistd.h ${S}/tools/include/uapi/asm-generic/unistd.h

you can also use
install -D 0644 ${STAGING_INCDIR}/asm-generic/unistd.h
${S}/tools/include/uapi/asm-generic/unistd.h
and get both done is one call.


>  }
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


  reply	other threads:[~2019-05-11 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-11 14:08 [PATCH] perf: make sure that the tools/include/uapi/asm-generic directory exists Martin Jansa
2019-05-11 14:51 ` Khem Raj [this message]
2019-05-11 16:36   ` [PATCHv2] " Martin Jansa
2019-05-11 20:54     ` Martin Jansa
2019-05-14  7:30       ` [PATCHv3] " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1spT7=rt=JrAqT44h7KjqAHr342Ew5SxrcPJB0EA3bXJPA@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.