From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by mail.openembedded.org (Postfix) with ESMTP id 2EABD6C566 for ; Tue, 27 Nov 2018 19:04:25 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id e5so23032950qtr.12 for ; Tue, 27 Nov 2018 11:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r8LfYPLo3nq2wzTPSJLcTonBEIdTrIJwpsEZKlmbDdo=; b=EE01DGJQHBkod5QI1fCsvJHags6iTDAFLvhIRedO0tVlpPrUw7wHN+JT9bLhhZfS0n S7sF+BIFukMd3xE+qzz2ljWZdi7Dg3R5Gpl9Uc6iylgY4/oLbNqMjt400sldMmt3b/yo hhEzhokuUPmg++AHujE8JZ850+e7qAeEpmvaEdU+JcenbDBB5ixRbHnj7cLqHX0kG8dk OEVYCl9b/gdAk6+4m9Rc7S19enXW1MjpCXQxavUJo1fFnK7hdEqGWzDssGQBGluvPJCS sSrhE9t+TotnalMaQsqkS6+yPiTkIj7T6uzeyVdJ/9g5lmbPMKcd8SUY7BGCIQ6zUQ1T 5xxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8LfYPLo3nq2wzTPSJLcTonBEIdTrIJwpsEZKlmbDdo=; b=PArDOEEbsJmvHSRKoTHu6bpAeEJi+ngbwT163Syy9VQ+Eoxk/m8VMZBhAIZqSa/7Op /WZ6/YvkeewjaJd2vEwTJOuHLMt/Ci/VN1n/RWlJBv4ZwW6SQ1OR5PzzeDqxr4CmPcQe 690HHhN+JT7MgyRHPfRhLSbTqresHyC8DlSYtn2KJmiOdSYVRTU1UiXZN5h2W01bh/6Z PyeRNFrPuoJEE+ebssfX8hp+91BaIgl9fjx6Twq9eKAXh4dGi+SYBPXr1PuZTJmVOolL 2qMtSIEKg/lRrIqTglqCRlc2n6RiAJ0j5W6pg7hMgiPT5RzguXlg89QlbsmaqWpTtu1e chuw== X-Gm-Message-State: AGRZ1gKN3Smkw/b0WErYwnaVForxIYccID9Ybzp2J5UkLQ99hufQ5vrC fmclelj5ScE/RN5tc3knrmzIQJocrFHsHytB3xY= X-Google-Smtp-Source: AJdET5fW98x+qm14uoSZ1Vg5d+krpNAzYPjBSPA05na6OhSYaj2pGX7dtXQrGhBgJnYJaW7nsgFVUm3qB9WzNKgpJPc= X-Received: by 2002:ac8:16d8:: with SMTP id y24mr32542246qtk.253.1543345465822; Tue, 27 Nov 2018 11:04:25 -0800 (PST) MIME-Version: 1.0 References: <1542696483-278773-1-git-send-email-changqing.li@windriver.com> In-Reply-To: From: Khem Raj Date: Tue, 27 Nov 2018 11:03:59 -0800 Message-ID: To: Martin Jansa Cc: openembeded-devel Subject: Re: [meta-networking][PATCH] geoip: add downloadfilename for geoip database files X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 19:04:25 -0000 Content-Type: text/plain; charset="UTF-8" I am seeing errors on some builders http://errors.yoctoproject.org/Errors/Details/202341/ On Mon, Nov 19, 2018 at 11:29 PM Martin Jansa wrote: > > Looks, good. > > Adding variable for 20181120 might help with maintenance (if we need to > change just checksums in future). And with good variable name (or a > comment) it would also document in the recipe why we're using this in > downloadfilename. > > On Tue, Nov 20, 2018 at 7:48 AM wrote: > > > From: Changqing Li > > > > previous change of checksum don't trigger archive to re-downloaded, > > , which will cause checksum mismatch. add downloadfilename to > > trigger re-download. > > > > 1. for user with PREMIRROR, another benefit is it can still compile > > success event upstream checksum change frequently. > > 2. but for user don't use PREMIRROR, if upstream checksum changed, > > still might have checksum mismatch problem. > > > > Signed-off-by: Changqing Li > > --- > > .../recipes-support/geoip/geoip_1.6.12.bb | 24 > > +++++++++++----------- > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb > > b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb > > index 1e1a7ff..57f0b67 100644 > > --- a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb > > +++ b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb > > @@ -9,10 +9,10 @@ HOMEPAGE = "http://dev.maxmind.com/geoip/" > > SECTION = "libdevel" > > > > SRC_URI = "git://github.com/maxmind/geoip-api-c.git \ > > - > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat > > \ > > - > > http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat > > \ > > - > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat > > \ > > - > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat > > \ > > + > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat;downloadfilename=GeoIP.dat.20181120.gz > > \ > > + > > http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat;downloadfilename=GeoIPv6.dat.20181120.gz > > \ > > + > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat;downloadfilename=GeoLiteCity.dat.20181120.gz > > \ > > + > > http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat;downloadfilename=GeoLiteCityv6.dat.20181120.gz > > \ > > file://run-ptest \ > > " > > SRCREV = "4b526e7331ca1d692b74a0509ddcc725622ed31a" > > @@ -20,14 +20,14 @@ SRCREV = "4b526e7331ca1d692b74a0509ddcc725622ed31a" > > SRC_URI[GeoIP-dat.md5sum] = "d538e57ad9268fdc7955c6cf9a37c4a9" > > SRC_URI[GeoIP-dat.sha256sum] = > > "b9c05eb8bfcf90a6ddfdc6815caf40a8db2710f0ce3dd48fbd6c24d485ae0449" > > > > -SRC_URI[GeoIPv6-dat.md5sum] = "00dc3b3f53eb5f7bf6915f939998f12c" > > -SRC_URI[GeoIPv6-dat.sha256sum] = > > "e72221fc630094d7256521b307e9142fb77d2167a27de2c11da536a2ba1d1480" > > +SRC_URI[GeoIPv6-dat.md5sum] = "a908d7a51c3883eb8f693ca197c7a142" > > +SRC_URI[GeoIPv6-dat.sha256sum] = > > "1b06e34eed2c539606a9ab4d97b2140ac80bf9f528d16ad2e3831c75014c2710" > > > > SRC_URI[GeoLiteCity-dat.md5sum] = "d700c137232f8e077ac8db8577f699d9" > > SRC_URI[GeoLiteCity-dat.sha256sum] = > > "90db2e52195e3d1bcdb2c2789209006d09de5c742812dbd9a1b36c12675ec4cd" > > > > -SRC_URI[GeoLiteCityv6-dat.md5sum] = "7f6333d433d8127181ea3c5828287c98" > > -SRC_URI[GeoLiteCityv6-dat.sha256sum] = > > "c339e20cdf326c18aa3571bcd27845e6daf41ca5bfe9401bc472908aaeb42ac7" > > +SRC_URI[GeoLiteCityv6-dat.md5sum] = "8ac3506ccabaae7e9f7d6301c2654313" > > +SRC_URI[GeoLiteCityv6-dat.sha256sum] = > > "1c5fced1657d09448b3ecc14b65c9536228a627d93ed4159d3438b2c6faa8506" > > > > LICENSE = "LGPL-2.1" > > > > @@ -44,10 +44,10 @@ EXTRA_OECONF = "--disable-static \ > > do_install() { > > make DESTDIR=${D} install > > install -d ${D}/${datadir}/GeoIP > > - install ${WORKDIR}/GeoIP.dat ${D}/${datadir}/GeoIP/ > > - install ${WORKDIR}/GeoIPv6.dat ${D}/${datadir}/GeoIP/ > > - install ${WORKDIR}/GeoLiteCity.dat ${D}/${datadir}/GeoIP/ > > - install ${WORKDIR}/GeoLiteCityv6.dat ${D}/${datadir}/GeoIP/ > > + install ${WORKDIR}/GeoIP.dat.20181120 ${D}/${datadir}/GeoIP/GeoIP.dat > > + install ${WORKDIR}/GeoIPv6.dat.20181120 > > ${D}/${datadir}/GeoIP/GeoIPv6.dat > > + install ${WORKDIR}/GeoLiteCity.dat.20181120 > > ${D}/${datadir}/GeoIP/GeoLiteCity.dat > > + install ${WORKDIR}/GeoLiteCityv6.dat.20181120 > > ${D}/${datadir}/GeoIP/GeoLiteCityv6.dat > > ln -s GeoLiteCity.dat ${D}${datadir}/GeoIP/GeoIPCity.dat > > } > > > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel