Re: [meta-oe][PATCH 8/9] libgpiod: ptest: warn if the gpio-mockup kernel module is not selected

["Khem Raj" <raj.khem@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]

On Mon, Jun 7, 2021 at 1:55 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> On Sun, Jun 6, 2021 at 12:17 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Wed, Jun 2, 2021 at 7:15 AM Bartosz Golaszewski <brgl@bgdev.pl>
> wrote:
> > >
> > > libgpiod test-suites work with the gpio-mockup kernel module. When
> using
> > > linux-yocto, it's enabled using the gpio/mockup.scc kernel feature.
> Check
> > > if this feature is present in KERNEL_FEATURE and warn if not.
> > >
> > > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> > > ---
> > >  meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> > > index 874453fbd..febf625a6 100644
> > > --- a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> > > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> > > @@ -52,6 +52,13 @@ RRECOMMENDS_${PN} +=
> "${@bb.utils.contains('PACKAGECONFIG', 'python3', '${PN}-py
> > >  PACKAGECONFIG_append = " ${@bb.utils.contains('DISTRO_FEATURES',
> 'ptest', 'tests', '', d)}"
> > >
> > >  do_install_ptest() {
> > > +    if [ "${PREFERRED_PROVIDER_virtual/kernel}" = "linux-yocto" ] && \
> > > +       ${@bb.utils.contains('KERNEL_FEATURES',
> 'features/gpio/mockup.scc', 'false', 'true',d)}; then
> > > +        bbwarn "libgpiod test-suites need the gpio-mockup
> > > +module and will not work without it. Consider adding
> > > +'features/gpio/mockup.scc' to KERNEL_FEATURES"
> > > +    fi
> > > +
> >
> > perhaps turn this into a bbnote something like what libbpf is doing see
> >
> http://cgit.openembedded.org/meta-openembedded/tree/meta-oe/recipes-kernel/libbpf/libbpf_0.3.bb?h=master
> >
>
> I really think that a warning is in order here. The ptests won't work
> without this module. At the same time we can't really skip the package
> altogether because the build may be using a different kernel recipe
> with its own defconfig - this is why we first check if we're using
> linux-yocto.


It should check for module being built in kernel irrespective of Linux
yocto that is right but we perhaps need a logic to consider the case where
I might have a kernel without this option and distro is using ptest feature

>
>
> Bart
>

[-- Attachment #2: Type: text/html, Size: 3880 bytes --]