From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by mail.openembedded.org (Postfix) with ESMTP id 65DC860B34 for ; Mon, 10 Feb 2020 16:01:29 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id v25so5474682qto.7 for ; Mon, 10 Feb 2020 08:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h+paI7xUgFuNsBvn992Iyx4476H7F9S5iy9umEOufqA=; b=Z4TN7LtmCR2KzGO3H5j0Uorr5fQkXeA3syAAjyFNTyVFjkI0dFdFSFtaOB2GK5M9XC aq0opd8k/GDOtYhPXH1Yny95+WRqk+5beS8AUhVPzQ5DOEFsXdw6jpOOREfHM1QytyF2 1qqJq1IffiztLddi2eciKdq/w+hAOtZBVuMoN/C1QlbarUbHHttQ5QcagRNAH8nDaz5n AxTjqj4auhq4PwfDx87nmsaS0q70NSC4dC/dbJ0ODowc4LdCWnStikZ/kN8VeXaxLIWx /3AC341gPa28b92iZgWmeKFX7Ec3DmzmaH5H1hY9Uiyc4V0VH5nyQ08zurVKfi7phbxj 0VYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h+paI7xUgFuNsBvn992Iyx4476H7F9S5iy9umEOufqA=; b=TQr7yNmZoP12gSIm/DvMBXGAxMnvO7bPkMMjiN1KJJL9WjYIzpptv+vmgOlcnl15N3 K5ZYr6H9yLc44toAsdFy1Ria8yniYFAekI8mSvpdIz9MnTXuVWKLbPwVKWs0PD35j8VA MOKbkzAz471t5tt9qt3LeDYYqzVuGY3MCgoLBBl7Brqqli2v8xvFw084cF4eGyzqNFBT xm6rE9VyvOcN/naZatTmWuxwQroh/BhaVB3fT5srjJhFLYeY3qwAewT1K95Y1W/KBv1Q OWRu/6U//UcIK1g2oYu5+4WQip+DUmETryV1tTzZWzjRJMMxtlRoaDBsNmqcZTLhXjFB c5OA== X-Gm-Message-State: APjAAAWz21LEfRuNTtcO6LYIOGNh4+H1KUjJWQ89u3EhVbnleMrF8ydt X+qDY2DpYIF/dc+Au1jzbUcEg7yddZA4zVHZItU= X-Google-Smtp-Source: APXvYqwdwwwfXV4I2haRU1rONjXoQ5HEhO/yAlay/1m6uzXdjTzPzfD4tZ/zi65aldYLEFGNK1N9mpEvDikc+4QpGZY= X-Received: by 2002:ac8:4419:: with SMTP id j25mr10596626qtn.378.1581350490175; Mon, 10 Feb 2020 08:01:30 -0800 (PST) MIME-Version: 1.0 References: <20200208000110.29065-1-scott.branden@broadcom.com> <55bb9c66-a419-c43d-111b-e5442db8df91@broadcom.com> <2159565f-eaca-697d-0711-e39aeccb1ba2@broadcom.com> <6cf5b86f-5055-0573-61ab-ad4717af5c2d@broadcom.com> In-Reply-To: From: Khem Raj Date: Mon, 10 Feb 2020 08:01:03 -0800 Message-ID: To: Alexander Kanavin Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH v2 1/2] x265: add x265 recipe X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 16:01:30 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, Feb 10, 2020 at 3:42 AM Alexander Kanavin wrote: > > As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call. > > The usecase is fine, as long as we add x265 support to gst plugins and ffmeg and it gets tested via reference images, I see no issues adding it. > Alex > > On Mon, 10 Feb 2020 at 07:16, Scott Branden via Openembedded-core wrote: >> >> >> >> On 2020-02-09 3:35 p.m., Khem Raj wrote: >> > On Sun, Feb 9, 2020 at 11:27 AM Scott Branden >> > wrote: >> >> >> >> >> >> On 2020-02-08 11:18 a.m., Khem Raj wrote: >> >>> On Fri, Feb 7, 2020 at 8:02 PM Scott Branden wrote: >> >>>> Hi Khem, >> >>>> >> >>>> On 2020-02-07 5:12 p.m., Khem Raj wrote: >> >>>> >> >>>> >> >>>> >> >>>> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core wrote: >> >>>>> Add x265 recipe from latest revision of stable branch. >> >>>> I wonder if it belongs to core are there deps on it that we need in common metadata >> >>>> >> >>>> I simply followed where x264 recipe is located and placed x265 beside it. >> >>>> Both are needed when enabled in ffmpeg. >> >>>> >> >>>> I don't know if that answers your question as to where they should be located. >> >>> idea is to keep small and therefore we should assess the inclusions in core >> >>> we have many packageconfigs which require packages from other layers >> >>> so if ffmpeg needs it and is optional then it should be fine to keep >> >>> it in meta-multimedia and packageconfig in ffmpeg disabled by default. >> >> I don't see why x264 would be in core and x265 in meta-multimedia. >> >> Both should be moved to meta-multimedia then? >> >> >> > I followed the thread a bit and I see there are followups where >> > usecase for other recipes in core is now >> > established, where this seemed a leaf package being added to oe-core, >> > So perhaps it should be added >> > to validation loops as well like x264. >> I leave it to the powers that be to decide where to place this recipe. >> > >> >> I think you would also require a bbappend to fffmpeg recipe to add x264 >> >> and x265 to ffmpeg packageconfig. >> >> if that is the case, why not move ffmpeg to meta-multimedia as well? >> >> >> > You would not go down that line of thought since these packages are in >> > the dependency chain for validating reference >> > images in core along with they being used by other packages from other layers. >> > >> >>>>> Signed-off-by: Scott Branden >> >>>>> --- >> >>>>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >> >>>>> 1 file changed, 20 insertions(+) >> >>>>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >> >>>>> >> >>>>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >> >>>>> new file mode 100644 >> >>>>> index 0000000000..796fbbc13a >> >>>>> --- /dev/null >> >>>>> +++ b/meta/recipes-multimedia/x265/x265_git.bb >> >>>>> @@ -0,0 +1,20 @@ >> >>>>> +SUMMARY = "H.265/HEVC video encoder" >> >>>>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >> >>>>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >> >>>>> + >> >>>>> +LICENSE = "GPLv2" >> >>>>> +LICENSE_FLAGS = "commercial" >> >>>>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >> >>>>> + >> >>>>> +DEPENDS = "gnutls zlib libpcre" >> >>>>> + >> >>>>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >> >>>>> + " >> >>>>> + >> >>>>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >> >>>>> + >> >>>>> +S = "${WORKDIR}/git/source" >> >>>>> + >> >>>>> +inherit lib_package pkgconfig cmake >> >>>>> + >> >>>>> +AS[unexport] = "1" >> >>>>> -- >> >>>>> 2.17.1 >> >>>>> >> >>>>> -- >> >>>>> _______________________________________________ >> >>>>> Openembedded-core mailing list >> >>>>> Openembedded-core@lists.openembedded.org >> >>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core