From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by mail.openembedded.org (Postfix) with ESMTP id 3F8937E507 for ; Tue, 3 Dec 2019 23:35:34 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id d202so5387829qkb.1 for ; Tue, 03 Dec 2019 15:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GwvKPX2PqxVmY1NS1sIxV1veZLjmvPUkaUk5N46fN3E=; b=BEceSvOVjnFhDd+zunqhTG8l9syTiQpwdGPofxkzSybKe1IJHW+dU99fBr2BuVJ9tF KrGfIX+wtsQam8Jf5hVc5jqTp+gaSzDU7ZhADFkly6MHc37RujxIFg3+OJ8hCZ0+707H RhgmPlF+No6tfVmko9BgERLbH1mpc3chrIgaM4vfqBoHCrsVd7FR2kwR/SGsZAvphhZR EYcaVSa9JaOHpTVOLWv8atNo8wnPoscpjYngkAgADzCHYj6RaQpR6uvqULv9jK6B5pi4 htey95uZpz3BdsYmKwgn3FQzQQ0nJSdTuhxvCGPO0OVL3MF2qyrON19S+Zobf//HqmXm GPug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GwvKPX2PqxVmY1NS1sIxV1veZLjmvPUkaUk5N46fN3E=; b=lxngSmcbq6BgFOgDuK69ClhD5jPwljZ0NVV2/zmwT81DWMdoex0WDHBesx8iszbGGO dBPYHSG7pSSaoIQkykPUtu2DswbLdKU6fgX/BuNq69MhoV9VFeM1DhQrQtHoc1lK1BUQ jPBfbSphtN+WARcqt8zIaU8UYuOOgonPAvND0+1nZcDa12dNRc2paCVSnVFGEdBpRAP2 dPDHPBbpEqh7L873wteaW4QhWRt0r8d1UF/KT6OQTFJC4x1bFM5DllK338vCNDtt5+n5 1BrvEL0VP4MIOfCp8n9L0agA5/aJ8G+Tb8SW7kOdt61KsAnreHblszswTblyeBmTaR+D PQWw== X-Gm-Message-State: APjAAAWpAQ4lH7mqFule7xjfExka7T3O5aVnbi+c2Le+Os+uRcvFbOhB VETNMPeh/Q12yf+nLoHVWLANl/En3KTX50Uhllg= X-Google-Smtp-Source: APXvYqzMoprdRzUCBEY+MZ+9ZtY6klFH8gwjreMqEztrMiYzlqQw8ykl5t2NLxS83ZPiSUZ3i3zJBAsx/6cidS4ke8Q= X-Received: by 2002:a37:4cd3:: with SMTP id z202mr49697qka.212.1575416134586; Tue, 03 Dec 2019 15:35:34 -0800 (PST) MIME-Version: 1.0 References: <1575398680-3272-1-git-send-email-liu.ming50@gmail.com> In-Reply-To: From: Khem Raj Date: Tue, 3 Dec 2019 15:35:23 -0800 Message-ID: To: Ming Liu Cc: Stefan Agner , Patches and discussions about the oe-core layer Subject: Re: [PATCH] glibc: fix ldconfig packaging issue X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 23:35:34 -0000 Content-Type: multipart/alternative; boundary="0000000000001354fa0598d52779" --0000000000001354fa0598d52779 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 3, 2019 at 1:53 PM Ming Liu wrote: > Hi, Khem: > > I don't think so, the problem is the package names in PACKAGES are being > handled in package task in order, if ldconfig is after glibc-utils, and > they both contains /sbin (or /usr/sbin for usermerge) path, then > /sbin/ldconfig (or /usr/sbin/usermerge) would be split into glibc-utils. > > It could be reproduced by enabling usermerge distro feature. > Yes no worries I see that we are defining PACKAGES variable there so this change is ok > //Ming Liu > > Khem Raj =E6=96=BC 2019=E5=B9=B412=E6=9C=883=E6=97= =A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=889:16=E5=AF=AB=E9=81=93=EF=BC=9A > >> On Tue, Dec 3, 2019 at 10:45 AM wrote: >> > >> > From: Ming Liu >> > >> > ldconfig should be prior to glibc-utils in PACKAGES variable, or else >> > ldconfig binary would not be split to its own package, hence will lead >> > to runtime issues for the packages that depending on ldconfig, like >> > systemd. >> >> hmmm perhaps FILES_ldconfig =3D+ would help ? >> >> > >> > Signed-off-by: Ming Liu >> > --- >> > meta/recipes-core/glibc/glibc-package.inc | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/meta/recipes-core/glibc/glibc-package.inc >> b/meta/recipes-core/glibc/glibc-package.inc >> > index 9dd5a0d..ede9e9b 100644 >> > --- a/meta/recipes-core/glibc/glibc-package.inc >> > +++ b/meta/recipes-core/glibc/glibc-package.inc >> > @@ -1,6 +1,6 @@ >> > INHIBIT_SYSROOT_STRIP =3D "1" >> > >> > -PACKAGES =3D "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db >> ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile >> libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev >> ${PN}-doc ldconfig" >> > +PACKAGES =3D "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode >> glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault >> ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev >> ${PN}-staticdev ${PN}-doc" >> > >> > # The ld.so in this glibc supports the GNU_HASH >> > RPROVIDES_${PN} =3D "eglibc rtld(GNU_HASH)" >> > -- >> > 2.7.4 >> > >> > -- >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> > http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > --0000000000001354fa0598d52779 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Dec 3, 2019 at 1:53 PM Ming Liu <liu.ming50@gmail.com> wrote:
Hi, Khem:

I d= on't think so, the problem is the package names in PACKAGES are being h= andled in package task in order, if ldconfig is after glibc-utils, and they= both contains /sbin (or /usr/sbin for usermerge) path, then /sbin/ldconfig= (or /usr/sbin/usermerge) would be split into=C2=A0glibc-utils.
<= br>
It could be reproduced by enabling=C2=A0usermerge distro feat= ure.

Yes no worries I see that we are defining PACKAGES variable ther= e so this change is ok=C2=A0


//Ming Liu

Khem= Raj <raj.khem@g= mail.com> =E6=96=BC 2019=E5=B9=B412=E6=9C=883=E6=97=A5 =E9=80=B1=E4= =BA=8C =E4=B8=8B=E5=8D=889:16=E5=AF=AB=E9=81=93=EF=BC=9A
O= n Tue, Dec 3, 2019 at 10:45 AM <liu.ming50@gmail.com> wrote:
>
> From: Ming Liu <liu.ming50@gmail.com>
>
> ldconfig should be prior to glibc-utils in PACKAGES variable, or else<= br> > ldconfig binary would not be split to its own package, hence will lead=
> to runtime issues for the packages that depending on ldconfig, like > systemd.

hmmm perhaps FILES_ldconfig =3D+ would help ?

>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>=C2=A0 meta/recipes-core/glibc/glibc-package.inc | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-= core/glibc/glibc-package.inc
> index 9dd5a0d..ede9e9b 100644
> --- a/meta/recipes-core/glibc/glibc-package.inc
> +++ b/meta/recipes-core/glibc/glibc-package.inc
> @@ -1,6 +1,6 @@
>=C2=A0 INHIBIT_SYSROOT_STRIP =3D "1"
>
> -PACKAGES =3D "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thre= ad-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile l= ibsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}= -doc ldconfig"
> +PACKAGES =3D "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode g= libc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pc= profile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-static= dev ${PN}-doc"
>
>=C2=A0 # The ld.so in this glibc supports the GNU_HASH
>=C2=A0 RPROVIDES_${PN} =3D "eglibc rtld(GNU_HASH)"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/m= ailman/listinfo/openembedded-core
--0000000000001354fa0598d52779--