Re: [PATCH 12/13] sqlite3: make CFLAGS consistent across native, nativesdk and target cases

[Khem Raj <raj.khem@gmail.com>]

On Fri, Aug 23, 2019 at 1:54 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> The previous simplification:
>
>   https://git.openembedded.org/openembedded-core/commit/?id=604777acfc54d285f315b622bd147ed02d55d6fd
>
> looked OK but didn't actually work as expected. The native and
> nativesdk classes re-set CFLAGS after the += has been applied and
> so any modifications made via += are lost. Use _append instead.
>

Not a question for this patch but the original patch which attemped to
unify patches for native nativesdk and target recipes. In my opinion
native and nativesdk and native particularly should be compiled with
default options and flags as much as possible, unless necessary
is this needed in this case?

> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/recipes-support/sqlite/sqlite3.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
> index 7cf23d0..044af5e 100644
> --- a/meta/recipes-support/sqlite/sqlite3.inc
> +++ b/meta/recipes-support/sqlite/sqlite3.inc
> @@ -47,10 +47,10 @@ EXTRA_OECONF = " \
>  CFLAGS_append = " -fPIC"
>
>  # pread() is in POSIX.1-2001 so any reasonable system must surely support it
> -CFLAGS += "-DUSE_PREAD"
> +CFLAGS_append = " -DUSE_PREAD"
>
>  # Provide column meta-data API
> -CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> +CFLAGS_append = " -DSQLITE_ENABLE_COLUMN_METADATA"
>
>  PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core