All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Alan Perry <alanp@snowmoose.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] binutils: add libopcodes package for perf
Date: Wed, 16 Dec 2020 10:27:59 -0800	[thread overview]
Message-ID: <CAMKF1sq+_YGUfaKVDYW8APSFdMDC8BWV+Tdf4mm+XjJ+w4_BvQ@mail.gmail.com> (raw)
In-Reply-To: <20201216073754.4371-1-alanp@snowmoose.com>

On Tue, Dec 15, 2020 at 11:38 PM Alan Perry <alanp@snowmoose.com> wrote:
>
> Add a package for libopcodes, since, like libbfd, it is needed by
> perf. Without separate packages for these libraries, all of the
> binutil tools get added as well.
>

libopcodes is not an API that binutils publish for wider consumption,
its meant for internal components and
external components can use it from binutils itself knowing very well
that it will change with binutils and therefore
I would prefer to not separate it out into separate package like this
which can appear as if its an external API
that binutils will respect.

> Signed-off-by: Alan Perry <alanp@snowmoose.com>
> ---
>  meta/recipes-devtools/binutils/binutils_2.35.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils_2.35.bb b/meta/recipes-devtools/binutils/binutils_2.35.bb
> index 2e645e1ed8..976e49765a 100644
> --- a/meta/recipes-devtools/binutils/binutils_2.35.bb
> +++ b/meta/recipes-devtools/binutils/binutils_2.35.bb
> @@ -52,9 +52,11 @@ do_install_class-native () {
>         rmdir ${D}/${libdir}64 || :
>  }
>
> -# Split out libbfd-*.so so including perf doesn't include extra stuff
> -PACKAGE_BEFORE_PN += "libbfd"
> +# Split out libbfd-*.so and libopcodes-*.so so including perf doesn't include
> +# extra stuff
> +PACKAGE_BEFORE_PN += "libbfd libopcodes"
>  FILES_libbfd = "${libdir}/libbfd-*.so.* ${libdir}/libbfd-*.so"
> +FILES_libopcodes = "${libdir}/libopcodes-*.so.* ${libdir}/libopcodes-*.so"
>
>  SRC_URI_append_class-nativesdk =  " file://0003-binutils-nativesdk-Search-for-alternative-ld.so.conf.patch "
>
> --
> 2.17.1
>
>
> 
>

  reply	other threads:[~2020-12-16 18:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  7:37 [PATCH] binutils: add libopcodes package for perf Alan Perry
2020-12-16 18:27 ` Khem Raj [this message]
2020-12-16 18:57   ` [OE-core] " Alan Perry
2020-12-16 19:00     ` Khem Raj
2020-12-16 20:06       ` Alan Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1sq+_YGUfaKVDYW8APSFdMDC8BWV+Tdf4mm+XjJ+w4_BvQ@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=alanp@snowmoose.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.