On Thu, Apr 22, 2021 at 7:42 AM Mikko Rapeli <mikko.rapeli@bmw.de> wrote:

> Currently lz4 uses it's own defaults which include O3 optimization.
> Switch from O3 to bitbake default O2 reduces binary package size
> from 467056 to 331888 bytes. Enables also building with Os if needed.


These could impact runtime performance have you
Checked what the rough impact is ?
Secondly we will be using non default set which could result in errors less
seen by others over time I have realized it’s also good to open a dialog
upstream and get the reasoning behind not letting distro defaults apply
some packages do have valid reasons


>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
> ---
>  meta/recipes-support/lz4/lz4_1.9.3.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/lz4/lz4_1.9.3.bb
> b/meta/recipes-support/lz4/lz4_1.9.3.bb
> index effc530b94..3905ef7dbc 100644
> --- a/meta/recipes-support/lz4/lz4_1.9.3.bb
> +++ b/meta/recipes-support/lz4/lz4_1.9.3.bb
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/git"
>  # Fixed in r118, which is larger than the current version.
>  CVE_CHECK_WHITELIST += "CVE-2014-4715"
>
> -EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' DESTDIR=${D} LIBDIR=${libdir}
> INCLUDEDIR=${includedir} BUILD_STATIC=no"
> +EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' CFLAGS='${CFLAGS}'
> DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir} BUILD_STATIC=no"
>
>  do_install() {
>         oe_runmake install
> --
> 2.20.1
>
>
> 
>
>