Re: [meta-browser][PATCH 1/2] chromium: don't pass is_official_build=true when doing a component-build

[Khem Raj <raj.khem@gmail.com>]

On Fri, Aug 9, 2019 at 2:20 AM Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> When setting the PACKAGECONFIG component-build, the build breaks
> immediately due to this from the toplevel BUILD.gn:
>
> if (is_official_build) {
>   # An official (maximally optimized!) component (optimized for build times)
>   # build doesn't make sense and usually doesn't work.
>   assert(!is_component_build)
> }
>
> So we must make is_official_build the negative of component-build.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
>  recipes-browser/chromium/chromium-gn.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-browser/chromium/chromium-gn.inc b/recipes-browser/chromium/chromium-gn.inc
> index d5258c0..d9735ab 100644
> --- a/recipes-browser/chromium/chromium-gn.inc
> +++ b/recipes-browser/chromium/chromium-gn.inc
> @@ -138,7 +138,8 @@ GN_ARGS += 'host_pkg_config="pkg-config-native"'
>  # (debug, release, official) but for historical reasons there are two
>  # separate flags.
>  # See also: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/hkcb6AOX5gE/PPT1ukWoBwAJ
> -GN_ARGS += "is_debug=false is_official_build=true"
> +GN_ARGS += "is_debug=false"
> +GN_ARGS += "is_official_build=${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'false', 'true', d)}"
>

this looks good.

>  # Starting with M61, Chromium defaults to building with its own copy of libc++
>  # instead of the system's libstdc++. Explicitly disable this behavior.
> --
> 2.20.1
>