All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	qemu-ppc@nongnu.org, "QEMU Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v3] ppc64: Avoid pt_regs struct definition
Date: Mon, 14 Mar 2022 18:51:22 -0700	[thread overview]
Message-ID: <CAMKF1sqAncDKXunwjS6aNEPk4LNU9OUnPe_eDb+6=rrWTzXqnA@mail.gmail.com> (raw)
In-Reply-To: <b6b966c3-dd49-74aa-e9be-7da716d28a3b@linaro.org>

On Mon, Mar 14, 2022 at 5:13 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 3/14/22 14:51, Khem Raj wrote:
> > +static inline uintptr_t host_signal_pc(host_sigcontext *uc)
> > +{
> > +    return uc->uc_mcontext.gp_regs[32];
> > +}
> > +
> > +static inline void host_signal_set_pc(host_sigcontext *uc, uintptr_t pc)
> > +{
> > +    uc->uc_mcontext.gp_regs[32] = pc;
> > +}
> > +
> > +static inline void *host_signal_mask(host_sigcontext *uc)
> > +{
> > +    return &uc->uc_sigmask;
> > +}
> > +
> > +static inline bool host_signal_write(siginfo_t *info, host_sigcontext *uc)
> > +{
> > +    return uc->uc_mcontext.gp_regs[40] != 0x400
> > +        && (uc->uc_mcontext.gp_regs[42] & 0x02000000);
> > +}
>
> Oh, dear.
>
> I didn't realize that the symbolic constants are also in <asm/ptrace.h>. We really don't
> want magic numbers.  We'll have to have the include and use PT_NIP, PT_TRAP, PT_DSISR.
>

yeah :) removing asm/ptrace.h sounded lucrative but it does make it
cryptic. I will send v4 soon.

>
> r~


      reply	other threads:[~2022-03-15  1:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 21:51 [PATCH v3] ppc64: Avoid pt_regs struct definition Khem Raj
2022-03-15  0:13 ` Richard Henderson
2022-03-15  1:51   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1sqAncDKXunwjS6aNEPk4LNU9OUnPe_eDb+6=rrWTzXqnA@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.