Re: [PATCH] webkitgtk: Reduce stack and heap sizes for jsc on musl

["Khem Raj" <raj.khem@gmail.com>]

On Wed, Mar 17, 2021 at 9:06 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>
> Hi,
>
> On Wed, 17 Mar 2021, at 00:31, Khem Raj wrote:
> > Fixes
> >
> > [YOCTO #14281]
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > Cc: Andrei Gherzan <andrei@gherzan.com>
> > ---
> >  .../webkitgtk/musl-lower-stack-usage.patch    | 51 +++++++++++++++++++
> >  meta/recipes-sato/webkit/webkitgtk_2.30.5.bb  |  1 +
> >  2 files changed, 52 insertions(+)
> >  create mode 100644
> > meta/recipes-sato/webkit/webkitgtk/musl-lower-stack-usage.patch
> >
> > diff --git
> > a/meta/recipes-sato/webkit/webkitgtk/musl-lower-stack-usage.patch
> > b/meta/recipes-sato/webkit/webkitgtk/musl-lower-stack-usage.patch
> > new file mode 100644
> > index 0000000000..3d66766d9a
> > --- /dev/null
> > +++ b/meta/recipes-sato/webkit/webkitgtk/musl-lower-stack-usage.patch
> > @@ -0,0 +1,51 @@
> > +reduce thread stack and heap usage for javascriptcore on musl
> > +
> > +default sizes for musl are smaller compared to glibc, this matches
> > +to musl defaults, avoid stack overflow crashes in jscore
>
> Tested and it works as expected. I was fixing it a bit hacky doing something similar to https://github.com/yaegashi/muslstack but this is cleaner.
>
Thanks for testing, I have sent a v2 which should be better. I would
rather not use muslstack utility as it papers over real issues. I
think real fix would
be in webkit to use pthread_attr_setstacksize() instead of hardcoding
the values, but I will let some experts in webkit to take it on.

> I've backported your patch for dunfell too (rebased the patch).
>
> Andrei