From: Khem Raj <raj.khem@gmail.com>
To: "S. Lockwood-Childs" <sjl@vctlabs.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] sqlite3: consistent set of features for nativesdk
Date: Fri, 15 Jun 2018 11:54:39 -0700 [thread overview]
Message-ID: <CAMKF1sqHeUyehiWW+_WsXST4Az8m0Fq6sTQLp2U1cXfKm2QeHw@mail.gmail.com> (raw)
In-Reply-To: <20180615075618.GL31886@vctlabs.com>
On Fri, Jun 15, 2018 at 12:58 AM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
>
> Enable use of pread() and enable column metadata API for nativesdk builds.
> This brings nativesdk in line with target and native builds.
> ---
> meta/recipes-support/sqlite/sqlite3.inc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
> index 95ec89c..30847b9 100644
> --- a/meta/recipes-support/sqlite/sqlite3.inc
> +++ b/meta/recipes-support/sqlite/sqlite3.inc
> @@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
>
> # pread() is in POSIX.1-2001 so any reasonable system must surely support it
> BUILD_CFLAGS += "-DUSE_PREAD"
> +BUILDSDK_CFLAGS += "-DUSE_PREAD"
> TARGET_CFLAGS += "-DUSE_PREAD"
>
Perhaps, we can just add it to CPPFLAGS and remove all three lines above
> # Provide column meta-data API
> BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> +BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
>
same as above
> PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
> --
> 1.9.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2018-06-15 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 7:56 [PATCH] sqlite3: consistent set of features for nativesdk S. Lockwood-Childs
2018-06-15 18:54 ` Khem Raj [this message]
2018-06-15 19:26 ` [PATCH V2] " S. Lockwood-Childs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1sqHeUyehiWW+_WsXST4Az8m0Fq6sTQLp2U1cXfKm2QeHw@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sjl@vctlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.