From: "Khem Raj" <raj.khem@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] packagegroup: rrecommend perf also for musl
Date: Wed, 23 Sep 2020 09:38:06 -0700 [thread overview]
Message-ID: <CAMKF1sqTT==wZ7a_HzzvsETmJeYAzX16E3y+RrnZF_kw92HuMg@mail.gmail.com> (raw)
In-Reply-To: <20200923084544.32128-1-ceggers@arri.de>
On Wed, Sep 23, 2020 at 1:46 AM Christian Eggers <ceggers@arri.de> wrote:
>
> The perf recipe builds fine for musl.
which all architectures did you build on musl ?
Regardless of that we should still use PERF var so non-core
architectures can still override it
>
> Fixes: d758a4445a ("packagegroup: Disable packages not available on musl")
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> .../packagegroups/packagegroup-core-tools-profile.bb | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> index 1c94653d72..a5dca95c2a 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> @@ -17,7 +17,7 @@ PROFILE_TOOLS_X_nios2 = ""
> PROFILE_TOOLS_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd-analyze', '', d)}"
>
> RRECOMMENDS_${PN} = "\
> - ${PERF} \
> + perf \
> blktrace \
> ${PROFILE_TOOLS_X} \
> ${PROFILE_TOOLS_SYSTEMD} \
> @@ -26,8 +26,6 @@ RRECOMMENDS_${PN} = "\
> PROFILETOOLS = "\
> powertop \
> "
> -PERF = "perf"
> -PERF_libc-musl = ""
>
> # systemtap needs elfutils which is not fully buildable on some arches/libcs
> SYSTEMTAP = "systemtap"
> --
> Christian Eggers
> Embedded software developer
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>
next prev parent reply other threads:[~2020-09-23 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 8:45 [PATCH] packagegroup: rrecommend perf also for musl Christian Eggers
2020-09-23 16:38 ` Khem Raj [this message]
2020-09-24 9:32 ` [PATCH v2] packagegroup: rrecommend perf also for musl on ARM Christian Eggers
2020-09-25 16:28 ` [OE-core] " Steve Sakoman
[not found] ` <3205654.9nU1JGFCk1@n95hx1g2>
2020-09-25 19:49 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1sqTT==wZ7a_HzzvsETmJeYAzX16E3y+RrnZF_kw92HuMg@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=ceggers@arri.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.